Re: [Mesa-dev] [PATCH] egl/android: Remove handling of RGB_888 pixel format

2016-11-20 Thread Tomasz Figa
On Thu, Nov 10, 2016 at 5:21 AM, Emil Velikov wrote: > On 9 November 2016 at 08:32, Tomasz Figa wrote: >> It is currently completely broken, as it ends up using RGBX_ on >> hardware side, due to no way of distinguishing between these two in the >> DRI API, while HAL_PIXEL_FORMAT_RGB_888 is cl

Re: [Mesa-dev] [PATCH] egl/android: Remove handling of RGB_888 pixel format

2016-11-10 Thread Rob Clark
On Thu, Nov 10, 2016 at 10:29 AM, Tomasz Figa wrote: > On Thu, Nov 10, 2016 at 11:42 PM, Rob Clark wrote: >> On Wed, Nov 9, 2016 at 11:23 PM, Tomasz Figa wrote: >>> On Thu, Nov 10, 2016 at 5:21 AM, Emil Velikov >>> wrote: On 9 November 2016 at 08:32, Tomasz Figa wrote: > It is curren

Re: [Mesa-dev] [PATCH] egl/android: Remove handling of RGB_888 pixel format

2016-11-10 Thread Tomasz Figa
On Thu, Nov 10, 2016 at 11:42 PM, Rob Clark wrote: > On Wed, Nov 9, 2016 at 11:23 PM, Tomasz Figa wrote: >> On Thu, Nov 10, 2016 at 5:21 AM, Emil Velikov >> wrote: >>> On 9 November 2016 at 08:32, Tomasz Figa wrote: It is currently completely broken, as it ends up using RGBX_ on

Re: [Mesa-dev] [PATCH] egl/android: Remove handling of RGB_888 pixel format

2016-11-10 Thread Rob Clark
On Wed, Nov 9, 2016 at 11:23 PM, Tomasz Figa wrote: > On Thu, Nov 10, 2016 at 5:21 AM, Emil Velikov > wrote: >> On 9 November 2016 at 08:32, Tomasz Figa wrote: >>> It is currently completely broken, as it ends up using RGBX_ on >>> hardware side, due to no way of distinguishing between thes

Re: [Mesa-dev] [PATCH] egl/android: Remove handling of RGB_888 pixel format

2016-11-09 Thread Tomasz Figa
On Thu, Nov 10, 2016 at 5:21 AM, Emil Velikov wrote: > On 9 November 2016 at 08:32, Tomasz Figa wrote: >> It is currently completely broken, as it ends up using RGBX_ on >> hardware side, due to no way of distinguishing between these two in the >> DRI API, while HAL_PIXEL_FORMAT_RGB_888 is cl

Re: [Mesa-dev] [PATCH] egl/android: Remove handling of RGB_888 pixel format

2016-11-09 Thread Emil Velikov
On 9 November 2016 at 08:32, Tomasz Figa wrote: > It is currently completely broken, as it ends up using RGBX_ on > hardware side, due to no way of distinguishing between these two in the > DRI API, while HAL_PIXEL_FORMAT_RGB_888 is clearly defined to be the > 3-byte per pixel RGB format. > >

[Mesa-dev] [PATCH] egl/android: Remove handling of RGB_888 pixel format

2016-11-09 Thread Tomasz Figa
It is currently completely broken, as it ends up using RGBX_ on hardware side, due to no way of distinguishing between these two in the DRI API, while HAL_PIXEL_FORMAT_RGB_888 is clearly defined to be the 3-byte per pixel RGB format. Signed-off-by: Tomasz Figa --- src/egl/drivers/dri2/platfo