Re: [Mesa-dev] [PATCH] dri_util: remove ALLOW_RGB10_CONFIGS option (v2)

Hi; On 11.01.2018 20:20, Mario Kleiner wrote: On 01/11/2018 09:14 AM, Tapani Pälli wrote: Yes, but as it broke regular visuals (on some of our testing machines as well) we needed a fast fix for this. While this is an issue, I think the visual corruption has higher priority than this. This ca

Re: [Mesa-dev] [PATCH] dri_util: remove ALLOW_RGB10_CONFIGS option (v2)

On 01/11/2018 09:14 AM, Tapani Pälli wrote: Yes, but as it broke regular visuals (on some of our testing machines as well) we needed a fast fix for this. While this is an issue, I think the visual corruption has higher priority than this. This can be fixed meanwhile or afterwards when things

Re: [Mesa-dev] [PATCH] dri_util: remove ALLOW_RGB10_CONFIGS option (v2)

On 01/11/2018 02:39 PM, Marek Olšák wrote: On Jan 11, 2018 7:14 AM, "Mario Kleiner" > wrote: On 01/10/2018 07:04 AM, Tapani Pälli wrote: Hi Marek; This one works but only if you add DRI_CONF_ALLOW_RGB10_CONFIGS("false")

Re: [Mesa-dev] [PATCH] dri_util: remove ALLOW_RGB10_CONFIGS option (v2)

On Jan 11, 2018 7:14 AM, "Mario Kleiner" wrote: On 01/10/2018 07:04 AM, Tapani Pälli wrote: > Hi Marek; > > This one works but only if you add > > DRI_CONF_ALLOW_RGB10_CONFIGS("false") > > to the DRI_CONF_SECTION_MISCELLANEOUS section in intel_screen. With that > change: Reviewed-by: Tapani Päll

Re: [Mesa-dev] [PATCH] dri_util: remove ALLOW_RGB10_CONFIGS option (v2)

On 01/11/2018 08:14 AM, Mario Kleiner wrote: On 01/10/2018 07:04 AM, Tapani Pälli wrote: Hi Marek; This one works but only if you add DRI_CONF_ALLOW_RGB10_CONFIGS("false") to the DRI_CONF_SECTION_MISCELLANEOUS section in intel_screen. With that change: Reviewed-by: Tapani Pälli With t

Re: [Mesa-dev] [PATCH] dri_util: remove ALLOW_RGB10_CONFIGS option (v2)

On 01/10/2018 07:04 AM, Tapani Pälli wrote: Hi Marek; This one works but only if you add DRI_CONF_ALLOW_RGB10_CONFIGS("false") to the DRI_CONF_SECTION_MISCELLANEOUS section in intel_screen. With that change: Reviewed-by: Tapani Pälli With this patch now committed to master, rgb10 visuals

Re: [Mesa-dev] [PATCH] dri_util: remove ALLOW_RGB10_CONFIGS option (v2)

Hi Marek; This one works but only if you add DRI_CONF_ALLOW_RGB10_CONFIGS("false") to the DRI_CONF_SECTION_MISCELLANEOUS section in intel_screen. With that change: Reviewed-by: Tapani Pälli On 01/09/2018 04:04 PM, Marek Olšák wrote: From: Marek Olšák This is unused because it's for libG

[Mesa-dev] [PATCH] dri_util: remove ALLOW_RGB10_CONFIGS option (v2)

From: Marek Olšák This is unused because it's for libGL/libEGL, not drivers. v2: i965 was wrong, because it used dri_util instead of its own config. --- src/mesa/drivers/dri/common/dri_util.c | 4 src/mesa/drivers/dri/i965/intel_screen.c | 2 +- 2 files changed, 1 insertion(+), 5 deletio

Re: [Mesa-dev] [PATCH] dri_util: remove ALLOW_RGB10_CONFIGS option

On Tue, Jan 9, 2018 at 9:59 AM, Tapani Pälli wrote: > > > On 01/09/2018 08:37 AM, Tapani Pälli wrote: >> >> >> On 01/08/2018 06:59 PM, Marek Olšák wrote: >>> >>> From: Marek Olšák >>> >>> This is unused because it's for libGL/libEGL, not drivers. >> >> >> IMO this is not enough, you would need to

Re: [Mesa-dev] [PATCH] dri_util: remove ALLOW_RGB10_CONFIGS option

On 01/09/2018 08:37 AM, Tapani Pälli wrote: On 01/08/2018 06:59 PM, Marek Olšák wrote: From: Marek Olšák This is unused because it's for libGL/libEGL, not drivers. IMO this is not enough, you would need to also remove the query for this as well (driQueryOptionb in intel_screen.c), otherw

Re: [Mesa-dev] [PATCH] dri_util: remove ALLOW_RGB10_CONFIGS option

On 01/08/2018 06:59 PM, Marek Olšák wrote: From: Marek Olšák This is unused because it's for libGL/libEGL, not drivers. IMO this is not enough, you would need to also remove the query for this as well (driQueryOptionb in intel_screen.c), otherwise we hit assertion. Maybe just set bool allo

[Mesa-dev] [PATCH] dri_util: remove ALLOW_RGB10_CONFIGS option

From: Marek Olšák This is unused because it's for libGL/libEGL, not drivers. --- src/mesa/drivers/dri/common/dri_util.c | 4 1 file changed, 4 deletions(-) diff --git a/src/mesa/drivers/dri/common/dri_util.c b/src/mesa/drivers/dri/common/dri_util.c index d4fba0b..e6a7d23 100644 --- a/src/