Re: [Mesa-dev] [PATCH] dri3: Prevent multiple freeing of buffers.

2018-04-16 Thread Sergii Romantsov
Hello (ping) Thomas and Daniel, any more suggestions? As i can see Eero has done a test-run and v2 also looks good. As alternative solution we also may try to call '*dri3_fence_await(draw->conn, draw, buffer)'* with '*draw*'-parameter as '*NULL'.* What do you think? On Tue, Apr 10, 2018 at 11:10

Re: [Mesa-dev] [PATCH] dri3: Prevent multiple freeing of buffers.

2018-04-10 Thread Sergii Romantsov
Hello, i've updated patch simply, but that seems requires additional checking because in call *dri3_handle_present_event *potentially may happens reset of '*busy*' with condition '*buf->pixmap == ie->pixmap*' On Fri, Apr 6, 2018 at 9:03 PM, Thomas Hellstrom wrote: > Hi, > > > On 04/06/2018 04:51

Re: [Mesa-dev] [PATCH] dri3: Prevent multiple freeing of buffers.

2018-04-06 Thread Thomas Hellstrom
Hi, On 04/06/2018 04:51 PM, Daniel Stone wrote: Hi Sergii, On 6 April 2018 at 09:12, Sergii Romantsov wrote: Commit 3160cb86aa92 adds optimization with flag 'reallocate'. Processing of flag causes buffers freeing while pointer is still hold in caller stack and than again used to be freed. Th

Re: [Mesa-dev] [PATCH] dri3: Prevent multiple freeing of buffers.

2018-04-06 Thread Daniel Stone
Hi Sergii, On 6 April 2018 at 09:12, Sergii Romantsov wrote: > Commit 3160cb86aa92 adds optimization with flag 'reallocate'. > Processing of flag causes buffers freeing while pointer > is still hold in caller stack and than again used to be freed. Thanks a lot for writing this. I take it the cor

Re: [Mesa-dev] [PATCH] dri3: Prevent multiple freeing of buffers.

2018-04-06 Thread Eero Tamminen
Hi, I tested this on KBL GT2. Compiz crashes during 3h test run dropped from 30 to none. There were couple of percent changes in few synthetic tests, but I think that's just because Compiz is now running properly. -> looks good! - Eero Tested-by: Eero Tamminen On 06.04.2018 11

[Mesa-dev] [PATCH] dri3: Prevent multiple freeing of buffers.

2018-04-06 Thread Sergii Romantsov
Commit 3160cb86aa92 adds optimization with flag 'reallocate'. Processing of flag causes buffers freeing while pointer is still hold in caller stack and than again used to be freed. Fixes: 3160cb86aa92 "egl/x11: Re-allocate buffers if format is suboptimal" Bugzilla: https://bugs.freedesktop.org/sh