Re: [Mesa-dev] [PATCH] dri2: add code to flush function of DRI2_Flush extension

2011-08-16 Thread Alan Hourihane
On 08/16/11 10:26, Alan Hourihane wrote: > On 08/16/11 10:05, Michel Dänzer wrote: >> On Die, 2011-08-16 at 16:55 +0800, Cooper Yuan wrote: >>> We still call flush method of DRI2_Flush extension in other functions >>> of egl_dri2 driver. for example, dri2_copy_buffers(), because we >>> expect all t

Re: [Mesa-dev] [PATCH] dri2: add code to flush function of DRI2_Flush extension

2011-08-16 Thread Alan Hourihane
On 08/16/11 10:05, Michel Dänzer wrote: > On Die, 2011-08-16 at 16:55 +0800, Cooper Yuan wrote: >> We still call flush method of DRI2_Flush extension in other functions >> of egl_dri2 driver. for example, dri2_copy_buffers(), because we >> expect all the rendering to this drawable have been flushed

Re: [Mesa-dev] [PATCH] dri2: add code to flush function of DRI2_Flush extension

2011-08-16 Thread Michel Dänzer
On Die, 2011-08-16 at 16:55 +0800, Cooper Yuan wrote: > We still call flush method of DRI2_Flush extension in other functions > of egl_dri2 driver. for example, dri2_copy_buffers(), because we > expect all the rendering to this drawable have been flushed before > copying the buffers. > > > The co

Re: [Mesa-dev] [PATCH] dri2: add code to flush function of DRI2_Flush extension

2011-08-16 Thread Cooper Yuan
We still call flush method of DRI2_Flush extension in other functions of egl_dri2 driver. for example, dri2_copy_buffers(), because we expect all the rendering to this drawable have been flushed before copying the buffers. The code I added eventually invokes st->pipe->flush(), so I think it handle

Re: [Mesa-dev] [PATCH] dri2: add code to flush function of DRI2_Flush extension

2011-08-16 Thread Chia-I Wu
2011/8/16 Cooper Yuan : > this DRI2_Flush extension is used by egl driver, but DRI2_Flush extension > doesn't implement dri2_flush_drawable() function. I do not recall what DRI2_Flush is for. It makes sense to simply call glFinish when eglWaitClient is called, if DRI2_Flush has different semantic

Re: [Mesa-dev] [PATCH] dri2: add code to flush function of DRI2_Flush extension

2011-08-16 Thread Cooper Yuan
this DRI2_Flush extension is used by egl driver, but DRI2_Flush extension doesn't implement dri2_flush_drawable() function. 2011/8/16 Michel Dänzer > On Mon, 2011-08-15 at 19:32 +0800, Cooper Yuan wrote: > > Hi All, please review this changelist that's going to enable > > eglWaitClient() which h

Re: [Mesa-dev] [PATCH] dri2: add code to flush function of DRI2_Flush extension

2011-08-15 Thread Michel Dänzer
On Mon, 2011-08-15 at 19:32 +0800, Cooper Yuan wrote: > Hi All, please review this changelist that's going to enable > eglWaitClient() which has the same effect with glFinish according to > specification. > before, egl applications using pixmap or pbuffer flicker always > because of no flush. >

[Mesa-dev] [PATCH] dri2: add code to flush function of DRI2_Flush extension

2011-08-15 Thread Cooper Yuan
Hi All, please review this changelist that's going to enable eglWaitClient() which has the same effect with glFinish according to specification. before, egl applications using pixmap or pbuffer flicker always because of no flush. Cooper --- src/gallium/state_trackers/dri/drm/dri2.c |4 1