Re: [Mesa-dev] [PATCH] dri2: Insert a synchronisation point for glXWaitX

2016-08-17 Thread Chris Wilson
On Wed, Aug 17, 2016 at 06:51:24PM +0100, Chris Wilson wrote: > However, X will always send a fake front if the real front is requested, > and the real front buffer is requested if either the read or write > buffer is GL_FRONT. So the fake front copy should suffice to trigger the > flush. Except f

Re: [Mesa-dev] [PATCH] dri2: Insert a synchronisation point for glXWaitX

2016-08-17 Thread Chris Wilson
On Wed, Aug 17, 2016 at 01:34:48PM -0400, Adam Jackson wrote: > On Wed, 2016-08-17 at 17:50 +0100, Chris Wilson wrote: > > On Wed, Aug 17, 2016 at 12:13:23PM -0400, Adam Jackson wrote: > > > > > > On Wed, 2016-08-17 at 08:17 -0700, Eric Anholt wrote: > > >   > > > > > > > > All I'm saying is that

Re: [Mesa-dev] [PATCH] dri2: Insert a synchronisation point for glXWaitX

2016-08-17 Thread Adam Jackson
On Wed, 2016-08-17 at 17:50 +0100, Chris Wilson wrote: > On Wed, Aug 17, 2016 at 12:13:23PM -0400, Adam Jackson wrote: > > > > On Wed, 2016-08-17 at 08:17 -0700, Eric Anholt wrote: > >   > > > > > > All I'm saying is that it's the thing that was intentionally used for > > > this purpose in DRI1 a

Re: [Mesa-dev] [PATCH] dri2: Insert a synchronisation point for glXWaitX

2016-08-17 Thread Chris Wilson
On Wed, Aug 17, 2016 at 12:13:23PM -0400, Adam Jackson wrote: > On Wed, 2016-08-17 at 08:17 -0700, Eric Anholt wrote: >   > > All I'm saying is that it's the thing that was intentionally used for > > this purpose in DRI1 and early DRI2, and maybe if it works we shouldn't > > just accidentally drop

Re: [Mesa-dev] [PATCH] dri2: Insert a synchronisation point for glXWaitX

2016-08-17 Thread Adam Jackson
On Wed, 2016-08-17 at 08:17 -0700, Eric Anholt wrote:   > All I'm saying is that it's the thing that was intentionally used for > this purpose in DRI1 and early DRI2, and maybe if it works we shouldn't > just accidentally drop it in a refactor. I don't see how the patch in this thread does that. I

Re: [Mesa-dev] [PATCH] dri2: Insert a synchronisation point for glXWaitX

2016-08-17 Thread Eric Anholt
Adam Jackson writes: > On Tue, 2016-08-16 at 15:55 +0100, Chris Wilson wrote: >> On Mon, Aug 17, 2015 at 03:17:30PM -0700, Eric Anholt wrote: >> > >> > I think XSync makes more sense.  It's cheaper, and it does exactly what >> > you're supposed to do at this point -- make sure that all your X >>

Re: [Mesa-dev] [PATCH] dri2: Insert a synchronisation point for glXWaitX

2016-08-16 Thread Adam Jackson
On Tue, 2016-08-16 at 15:55 +0100, Chris Wilson wrote: > On Mon, Aug 17, 2015 at 03:17:30PM -0700, Eric Anholt wrote: > > > > I think XSync makes more sense.  It's cheaper, and it does exactly what > > you're supposed to do at this point -- make sure that all your X > > requests have been processe

Re: [Mesa-dev] [PATCH] dri2: Insert a synchronisation point for glXWaitX

2016-08-16 Thread Chris Wilson
On Mon, Aug 17, 2015 at 03:17:30PM -0700, Eric Anholt wrote: > Chris Wilson writes: > > > "X rendering calls made prior to glXWaitX are guaranteed to be > > executed before GL rendering calls made after glXWaitX." > > > > The goal is to implement that without adding a round-trip to the > > Xserve

Re: [Mesa-dev] [PATCH] dri2: Insert a synchronisation point for glXWaitX

2016-08-03 Thread Chris Wilson
On Mon, Aug 17, 2015 at 03:17:30PM -0700, Eric Anholt wrote: > Chris Wilson writes: > > > "X rendering calls made prior to glXWaitX are guaranteed to be > > executed before GL rendering calls made after glXWaitX." > > > > The goal is to implement that without adding a round-trip to the > > Xserve

Re: [Mesa-dev] [PATCH] dri2: Insert a synchronisation point for glXWaitX

2015-08-17 Thread Eric Anholt
Chris Wilson writes: > "X rendering calls made prior to glXWaitX are guaranteed to be > executed before GL rendering calls made after glXWaitX." > > The goal is to implement that without adding a round-trip to the > Xserver. Adding one using XSync() is easy, but we can piggy-back > another, the D

[Mesa-dev] [PATCH] dri2: Insert a synchronisation point for glXWaitX

2015-08-10 Thread Chris Wilson
"X rendering calls made prior to glXWaitX are guaranteed to be executed before GL rendering calls made after glXWaitX." The goal is to implement that without adding a round-trip to the Xserver. Adding one using XSync() is easy, but we can piggy-back another, the DRI2GetBuffers request made to upda