Re: [Mesa-dev] [PATCH] dri: use 'bool' instead 'int' for boolean variables

2016-08-08 Thread Michel Dänzer
On 09/08/16 05:59 AM, ⚛ wrote: > On Mon, Aug 8, 2016 at 7:14 PM, Ian Romanick wrote: >> On 08/08/2016 09:38 AM, ⚛ wrote: >>> On Mon, Aug 8, 2016 at 6:22 PM, Ian Romanick wrote: I'm pretty sure this breaks ABI. Did you try using an unpatched libGL with a patched *_dri.so (and vice-versa

Re: [Mesa-dev] [PATCH] dri: use 'bool' instead 'int' for boolean variables

2016-08-08 Thread ⚛
On Mon, Aug 8, 2016 at 7:14 PM, Ian Romanick wrote: > On 08/08/2016 09:38 AM, ⚛ wrote: >> On Mon, Aug 8, 2016 at 6:22 PM, Ian Romanick wrote: >>> I'm pretty sure this breaks ABI. Did you try using an unpatched libGL >>> with a patched *_dri.so (and vice-versa)? >> >> Can you be more specific? >

Re: [Mesa-dev] [PATCH] dri: use 'bool' instead 'int' for boolean variables

2016-08-08 Thread Ian Romanick
On 08/08/2016 10:20 AM, Rob Clark wrote: > how strict are we on that actually? I think whenever we add new gl > entry points (ie. implementing new extension, etc) we kinda sorta > break ABI, don't we? I thought mixing/matching libGL vs *_dri.so was > at least not recommended.. No... we go to gre

Re: [Mesa-dev] [PATCH] dri: use 'bool' instead 'int' for boolean variables

2016-08-08 Thread Ian Romanick
On 08/08/2016 09:38 AM, ⚛ wrote: > On Mon, Aug 8, 2016 at 6:22 PM, Ian Romanick wrote: >> I'm pretty sure this breaks ABI. Did you try using an unpatched libGL >> with a patched *_dri.so (and vice-versa)? > > Can you be more specific? Eh... build Mesa. Save the libGL and *_dri.so. Apply patch

Re: [Mesa-dev] [PATCH] dri: use 'bool' instead 'int' for boolean variables

2016-08-08 Thread Rob Clark
how strict are we on that actually? I think whenever we add new gl entry points (ie. implementing new extension, etc) we kinda sorta break ABI, don't we? I thought mixing/matching libGL vs *_dri.so was at least not recommended.. BR, -R On Mon, Aug 8, 2016 at 12:22 PM, Ian Romanick wrote: > I'm

Re: [Mesa-dev] [PATCH] dri: use 'bool' instead 'int' for boolean variables

2016-08-08 Thread ⚛
On Mon, Aug 8, 2016 at 6:22 PM, Ian Romanick wrote: > I'm pretty sure this breaks ABI. Did you try using an unpatched libGL > with a patched *_dri.so (and vice-versa)? Can you be more specific? Where is the ABI documented? ___ mesa-dev mailing list me

Re: [Mesa-dev] [PATCH] dri: use 'bool' instead 'int' for boolean variables

2016-08-08 Thread Ian Romanick
I'm pretty sure this breaks ABI. Did you try using an unpatched libGL with a patched *_dri.so (and vice-versa)? On 08/01/2016 06:21 AM, Jan Ziak wrote: > Signed-off-by: Jan Ziak (http://atom-symbol.net) <0xe2.0x9a.0...@gmail.com> > --- > src/egl/drivers/dri2/egl_dri2.h | 19 ++-

Re: [Mesa-dev] [PATCH] dri: use 'bool' instead 'int' for boolean variables

2016-08-02 Thread Eric Engestrom
On Mon, Aug 01, 2016 at 03:43:17PM +0200, ⚛ wrote: > On Mon, Aug 1, 2016 at 2:46 PM, Eric Engestrom > wrote: > > On Sun, Jul 31, 2016 at 05:49:02PM +0200, Jan Ziak wrote: > >> Signed-off-by: Jan Ziak (http://atom-symbol.net) <0xe2.0x9a.0...@gmail.com> > > > > This is a good change, and with a coup

Re: [Mesa-dev] [PATCH] dri: use 'bool' instead 'int' for boolean variables

2016-08-02 Thread Nicolai Hähnle
On 01.08.2016 15:21, Jan Ziak wrote: Signed-off-by: Jan Ziak (http://atom-symbol.net) <0xe2.0x9a.0...@gmail.com> --- src/egl/drivers/dri2/egl_dri2.h | 19 ++- src/gallium/auxiliary/vl/vl_winsys_dri3.c | 3 ++- src/glx/dri3_priv.h | 5 +++-- src/l

Re: [Mesa-dev] [PATCH] dri: use 'bool' instead 'int' for boolean variables

2016-08-01 Thread ⚛
On Mon, Aug 1, 2016 at 2:46 PM, Eric Engestrom wrote: > On Sun, Jul 31, 2016 at 05:49:02PM +0200, Jan Ziak wrote: >> Signed-off-by: Jan Ziak (http://atom-symbol.net) <0xe2.0x9a.0...@gmail.com> > > This is a good change, and with a couple things to fix below, it is: > Reviewed-by: Eric Engestrom >

[Mesa-dev] [PATCH] dri: use 'bool' instead 'int' for boolean variables

2016-08-01 Thread Jan Ziak
Signed-off-by: Jan Ziak (http://atom-symbol.net) <0xe2.0x9a.0...@gmail.com> --- src/egl/drivers/dri2/egl_dri2.h | 19 ++- src/gallium/auxiliary/vl/vl_winsys_dri3.c | 3 ++- src/glx/dri3_priv.h | 5 +++-- src/loader/loader.c |

Re: [Mesa-dev] [PATCH] dri: use 'bool' instead 'int' for boolean variables

2016-08-01 Thread Eric Engestrom
On Sun, Jul 31, 2016 at 05:49:02PM +0200, Jan Ziak wrote: > Signed-off-by: Jan Ziak (http://atom-symbol.net) <0xe2.0x9a.0...@gmail.com> This is a good change, and with a couple things to fix below, it is: Reviewed-by: Eric Engestrom > --- > src/egl/drivers/dri2/egl_dri2.h| 19 ++

[Mesa-dev] [PATCH] dri: use 'bool' instead 'int' for boolean variables

2016-07-31 Thread Jan Ziak
Signed-off-by: Jan Ziak (http://atom-symbol.net) <0xe2.0x9a.0...@gmail.com> --- src/egl/drivers/dri2/egl_dri2.h| 19 ++- src/gallium/auxiliary/vl/vl_winsys_dri3.c | 2 +- src/glx/dri3_glx.c | 1 + src/glx/dri3_priv.h|