Re: [Mesa-dev] [PATCH] dri: Choose a decent global driNConfigOptions.

2013-08-08 Thread Kenneth Graunke
On 08/08/2013 03:59 AM, Eric Anholt wrote: Previously, we were asserting that each driver specified an NConfigOptions exactly equal to the number of options they supplied, leading to frequent bugs when people would forget to adjust the value when adjusting driver options. Instead, just overalloc

Re: [Mesa-dev] [PATCH] dri: Choose a decent global driNConfigOptions.

2013-08-08 Thread Eric Anholt
Ian Romanick writes: > On 08/08/2013 03:59 AM, Eric Anholt wrote: >> Previously, we were asserting that each driver specified an NConfigOptions >> exactly equal to the number of options they supplied, leading to frequent >> bugs when people would forget to adjust the value when adjusting driver >

Re: [Mesa-dev] [PATCH] dri: Choose a decent global driNConfigOptions.

2013-08-08 Thread Ian Romanick
On 08/08/2013 03:59 AM, Eric Anholt wrote: Previously, we were asserting that each driver specified an NConfigOptions exactly equal to the number of options they supplied, leading to frequent bugs when people would forget to adjust the value when adjusting driver options. Instead, just overalloc

[Mesa-dev] [PATCH] dri: Choose a decent global driNConfigOptions.

2013-08-08 Thread Eric Anholt
Previously, we were asserting that each driver specified an NConfigOptions exactly equal to the number of options they supplied, leading to frequent bugs when people would forget to adjust the value when adjusting driver options. Instead, just overallocate the table by a bit and leave sanity check