Re: [Mesa-dev] [PATCH] draw: fix key comparison with uninitialized value

2016-01-12 Thread Jose Fonseca
On 12/01/16 17:49, srol...@vmware.com wrote: From: Roland Scheidegger Discovered by accident, valgrind was complaining (could have possibly caused us to create redundant geometry shader variants). v2: convinced by Brian and Jose, just use memset for both gs and vs keys, just as easy and less e

Re: [Mesa-dev] [PATCH] draw: fix key comparison with uninitialized value

2016-01-12 Thread Brian Paul
On 01/12/2016 10:49 AM, srol...@vmware.com wrote: From: Roland Scheidegger Discovered by accident, valgrind was complaining (could have possibly caused us to create redundant geometry shader variants). v2: convinced by Brian and Jose, just use memset for both gs and vs keys, just as easy and l

[Mesa-dev] [PATCH] draw: fix key comparison with uninitialized value

2016-01-12 Thread sroland
From: Roland Scheidegger Discovered by accident, valgrind was complaining (could have possibly caused us to create redundant geometry shader variants). v2: convinced by Brian and Jose, just use memset for both gs and vs keys, just as easy and less error prone. --- src/gallium/auxiliary/draw/dra

Re: [Mesa-dev] [PATCH] draw: fix key comparison with uninitialized value

2016-01-12 Thread Roland Scheidegger
Am 12.01.2016 um 10:49 schrieb Jose Fonseca: > On 12/01/16 02:11, srol...@vmware.com wrote: >> From: Roland Scheidegger >> >> Discovered by accident, valgrind was complaining (could have possibly >> caused >> us to create redundant geometry shader variants). > > Great fine. > >> --- >> src/gal

Re: [Mesa-dev] [PATCH] draw: fix key comparison with uninitialized value

2016-01-12 Thread Brian Paul
On 01/12/2016 02:49 AM, Jose Fonseca wrote: On 12/01/16 02:11, srol...@vmware.com wrote: From: Roland Scheidegger Discovered by accident, valgrind was complaining (could have possibly caused us to create redundant geometry shader variants). Great fine. --- src/gallium/auxiliary/draw/draw

Re: [Mesa-dev] [PATCH] draw: fix key comparison with uninitialized value

2016-01-12 Thread Jose Fonseca
On 12/01/16 02:11, srol...@vmware.com wrote: From: Roland Scheidegger Discovered by accident, valgrind was complaining (could have possibly caused us to create redundant geometry shader variants). Great fine. --- src/gallium/auxiliary/draw/draw_llvm.c | 3 +++ src/gallium/auxiliary/draw/

[Mesa-dev] [PATCH] draw: fix key comparison with uninitialized value

2016-01-11 Thread sroland
From: Roland Scheidegger Discovered by accident, valgrind was complaining (could have possibly caused us to create redundant geometry shader variants). --- src/gallium/auxiliary/draw/draw_llvm.c | 3 +++ src/gallium/auxiliary/draw/draw_llvm.h | 5 + 2 files changed, 8 insertions(+) diff --g