Re: [Mesa-dev] [PATCH] draw: don't crash if GS doesn't emit anything

2013-05-01 Thread Zack Rusin
- Original Message - > Primitive culling in the geometry shader can be faster if emitting > lots of primitives is a bottleneck, for example rendering to multiple > viewports. The geometry shader execution is not slow per se. It's the > stuff around it that makes it slow. (the primitives mig

Re: [Mesa-dev] [PATCH] draw: don't crash if GS doesn't emit anything

2013-05-01 Thread Marek Olšák
Primitive culling in the geometry shader can be faster if emitting lots of primitives is a bottleneck, for example rendering to multiple viewports. The geometry shader execution is not slow per se. It's the stuff around it that makes it slow. (the primitives might need to be stored in video memory

Re: [Mesa-dev] [PATCH] draw: don't crash if GS doesn't emit anything

2013-05-01 Thread Jose Fonseca
- Original Message - > > > What is "IA"? > > > > "Input Assembly", a D3D10 term that roughly matches pipe_vertex_elements / > > pipe_vertex_buffer state. > > > > BTW, I think that Chris Forbes makes a good point -- a GS might choose to > > not emit any vertices (e.g., that does fancy c

Re: [Mesa-dev] [PATCH] draw: don't crash if GS doesn't emit anything

2013-04-30 Thread Zack Rusin
> > What is "IA"? > > "Input Assembly", a D3D10 term that roughly matches pipe_vertex_elements / > pipe_vertex_buffer state. > > BTW, I think that Chris Forbes makes a good point -- a GS might choose to > not emit any vertices (e.g., that does fancy culling) -- so maybe this > debugging message

Re: [Mesa-dev] [PATCH] draw: don't crash if GS doesn't emit anything

2013-04-30 Thread Jose Fonseca
- Original Message - > On 04/27/2013 06:57 AM, Zack Rusin wrote: > > Technically it's legal for geometry shader to not emit any > > vertices. It's silly, but perfectly legal, so lets make draw > > stop crashing if it happens. > > > > Signed-off-by: Zack Rusin > > --- > > src/gallium/aux

Re: [Mesa-dev] [PATCH] draw: don't crash if GS doesn't emit anything

2013-04-30 Thread Alex Deucher
On Tue, Apr 30, 2013 at 9:40 AM, Brian Paul wrote: > On 04/27/2013 06:57 AM, Zack Rusin wrote: >> >> Technically it's legal for geometry shader to not emit any >> vertices. It's silly, but perfectly legal, so lets make draw >> stop crashing if it happens. >> >> Signed-off-by: Zack Rusin >> --- >>

Re: [Mesa-dev] [PATCH] draw: don't crash if GS doesn't emit anything

2013-04-30 Thread Brian Paul
On 04/27/2013 06:57 AM, Zack Rusin wrote: Technically it's legal for geometry shader to not emit any vertices. It's silly, but perfectly legal, so lets make draw stop crashing if it happens. Signed-off-by: Zack Rusin --- src/gallium/auxiliary/draw/draw_pt_fetch_shade_pipeline.c |9

Re: [Mesa-dev] [PATCH] draw: don't crash if GS doesn't emit anything

2013-04-29 Thread Jose Fonseca
- Original Message - > Technically it's legal for geometry shader to not emit any > vertices. It's silly, but perfectly legal, so lets make draw > stop crashing if it happens. > > Signed-off-by: Zack Rusin > --- > src/gallium/auxiliary/draw/draw_pt_fetch_shade_pipeline.c |9 >

Re: [Mesa-dev] [PATCH] draw: don't crash if GS doesn't emit anything

2013-04-29 Thread Roland Scheidegger
Am 27.04.2013 14:57, schrieb Zack Rusin: > Technically it's legal for geometry shader to not emit any > vertices. It's silly, but perfectly legal, so lets make draw > stop crashing if it happens. > > Signed-off-by: Zack Rusin > --- > src/gallium/auxiliary/draw/draw_pt_fetch_shade_pipeline.c

Re: [Mesa-dev] [PATCH] draw: don't crash if GS doesn't emit anything

2013-04-29 Thread Chris Forbes
It's only silly if the GS *never* emits any verts... On Sun, Apr 28, 2013 at 12:57 AM, Zack Rusin wrote: > Technically it's legal for geometry shader to not emit any > vertices. It's silly, but perfectly legal, so lets make draw > stop crashing if it happens. > > Signed-off-by: Zack Rusin > ---

[Mesa-dev] [PATCH] draw: don't crash if GS doesn't emit anything

2013-04-29 Thread Zack Rusin
Technically it's legal for geometry shader to not emit any vertices. It's silly, but perfectly legal, so lets make draw stop crashing if it happens. Signed-off-by: Zack Rusin --- src/gallium/auxiliary/draw/draw_pt_fetch_shade_pipeline.c |9 + .../auxiliary/draw/draw_pt_fetch_shad