On 16/5/19 13:35, Eric Engestrom wrote:
On Thursday, 2019-05-16 13:14:46 +0200, Connor Abbott wrote:
Some grammar nits:
- "Resolve Discussion" goes before "button" as it modifies it.
- It's either "This way..." or "In this manner...", not "In this
way...", although the latter is a little too s
On Thursday, 2019-05-16 13:14:46 +0200, Connor Abbott wrote:
> Some grammar nits:
>
> - "Resolve Discussion" goes before "button" as it modifies it.
> - It's either "This way..." or "In this manner...", not "In this
> way...", although the latter is a little too stilted/over-formal here.
> - This
Some grammar nits:
- "Resolve Discussion" goes before "button" as it modifies it.
- It's either "This way..." or "In this manner...", not "In this
way...", although the latter is a little too stilted/over-formal here.
- This isn't a hypothetical or another situation where "would know..."
is approp
For newcomers to gitlab, it is not evident that it is better to press
the "Resolve Discussion" button when you update your branch handling
feedback.
---
As the commit message says, it is not always evident. I was pointed to
do that when I started to use gitlab, and just today I mentioned it to
two
