Re: [Mesa-dev] [PATCH] cso: add context cleanup code from st/mesa

2015-05-18 Thread Marek Olšák
I think Signed-off-by is only required for kernel patches. Marek On Mon, May 18, 2015 at 3:39 PM, Tobias Klausmann wrote: > Reviewed-by: Tobias Klausmann > > On 18.05.2015 11:29, Marek Olšák wrote: >> >> From: Marek Olšák >> >> This fixes a crash in nouveau which can't handle >> set_constant_b

Re: [Mesa-dev] [PATCH] cso: add context cleanup code from st/mesa

2015-05-18 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Mon, May 18, 2015 at 5:29 AM, Marek Olšák wrote: > From: Marek Olšák > > This fixes a crash in nouveau which can't handle > set_constant_buffer(PIPE_SHADER_TESS_*). > --- > src/gallium/auxiliary/cso_cache/cso_context.c | 7 +++ > src/mesa/state_tracker/st_contex

Re: [Mesa-dev] [PATCH] cso: add context cleanup code from st/mesa

2015-05-18 Thread Tobias Klausmann
Reviewed-by: Tobias Klausmann On 18.05.2015 11:29, Marek Olšák wrote: From: Marek Olšák This fixes a crash in nouveau which can't handle set_constant_buffer(PIPE_SHADER_TESS_*). where is the S-o-b ? ;-) --- src/gallium/auxiliary/cso_cache/cso_context.c | 7 +++ src/mesa/state_track

Re: [Mesa-dev] [PATCH] cso: add context cleanup code from st/mesa

2015-05-18 Thread Samuel Pitoiset
On 05/18/2015 02:08 PM, Marek Olšák wrote: Technically speaking, nothing needs to be destroyed. It's the responsibility of the driver to clean up after itself. The answer is no, because the compute shader isn't used by cso_context and st/mesa. Sounds good to me. Thanks for your answer Marek.

Re: [Mesa-dev] [PATCH] cso: add context cleanup code from st/mesa

2015-05-18 Thread Marek Olšák
Technically speaking, nothing needs to be destroyed. It's the responsibility of the driver to clean up after itself. The answer is no, because the compute shader isn't used by cso_context and st/mesa. Marek On Mon, May 18, 2015 at 1:15 PM, Samuel Pitoiset wrote: > > > On 05/18/2015 11:29 AM, Ma

Re: [Mesa-dev] [PATCH] cso: add context cleanup code from st/mesa

2015-05-18 Thread Samuel Pitoiset
On 05/18/2015 11:29 AM, Marek Olšák wrote: From: Marek Olšák This fixes a crash in nouveau which can't handle set_constant_buffer(PIPE_SHADER_TESS_*). --- src/gallium/auxiliary/cso_cache/cso_context.c | 7 +++ src/mesa/state_tracker/st_context.c | 6 -- 2 files changed,

[Mesa-dev] [PATCH] cso: add context cleanup code from st/mesa

2015-05-18 Thread Marek Olšák
From: Marek Olšák This fixes a crash in nouveau which can't handle set_constant_buffer(PIPE_SHADER_TESS_*). --- src/gallium/auxiliary/cso_cache/cso_context.c | 7 +++ src/mesa/state_tracker/st_context.c | 6 -- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/src/