Re: [Mesa-dev] [PATCH] configure.ac: Strip patch version from LLVM version.

2016-12-05 Thread Emil Velikov
On 4 December 2016 at 20:21, Jan Vesely wrote: > On Sat, 2016-12-03 at 14:33 -0800, Vinson Lee wrote: >> Hi, Tobias. >> >> /bin/llvm-config --includedir returns /include. I am >> not setting the "--with-llvm-prefix" configure option. > > Have you completed mesa build with only the configure.ac fix

Re: [Mesa-dev] [PATCH] configure.ac: Strip patch version from LLVM version.

2016-12-04 Thread Jan Vesely
On Sat, 2016-12-03 at 14:33 -0800, Vinson Lee wrote: > Hi, Tobias. > > /bin/llvm-config --includedir returns /include. I am > not setting the "--with-llvm-prefix" configure option. Have you completed mesa build with only the configure.ac fix? I'm not sure if using llvm without make install is sup

Re: [Mesa-dev] [PATCH] configure.ac: Strip patch version from LLVM version.

2016-12-03 Thread Tobias Droste
Hi Vinson, ah sorry, CMAKE_INSTALL_PREFIX=~/code/llvm/build/result. and you have to run make install. Tobias Am Samstag, 3. Dezember 2016, 23:54:37 CET schrieb Tobias Droste: > Hi Vinson, > > are you sure you are using the correct one? > > I'm building llvm in ~/code/llvm. > CMAKE_INSTALL_PREF

Re: [Mesa-dev] [PATCH] configure.ac: Strip patch version from LLVM version.

2016-12-03 Thread Tobias Droste
Hi Vinson, are you sure you are using the correct one? I'm building llvm in ~/code/llvm. CMAKE_INSTALL_PREFIX is set to ~/code/llvm/build. The final build results ends in ~/code/llvm/build/result (and not ~/code/llvm/ build)! If you use ~/code/llvm/build/bin/llvm-config you get wrong values. Yo

Re: [Mesa-dev] [PATCH] configure.ac: Strip patch version from LLVM version.

2016-12-03 Thread Vinson Lee
Hi, Tobias. /bin/llvm-config --includedir returns /include. I am not setting the "--with-llvm-prefix" configure option. Cheers, Vinson On Sat, Dec 3, 2016 at 1:46 PM, Tobias Droste wrote: > Hi Vinson, > > > > why is LLVM_INCLUDEDIR not /include? How does this happen? > > Do you set "--with-llv

Re: [Mesa-dev] [PATCH] configure.ac: Strip patch version from LLVM version.

2016-12-03 Thread Tobias Droste
Hi Vinson, why is LLVM_INCLUDEDIR not /include? How does this happen? Do you set "--with-llvm-prefix=" when building mesa? Tobias Am Samstag, 3. Dezember 2016, 11:53:53 CET schrieb Vinson Lee: > Hi, Tobias. > > I actually need this when using LLVM from a build tree and the header > files are n

Re: [Mesa-dev] [PATCH] configure.ac: Strip patch version from LLVM version.

2016-12-03 Thread Vinson Lee
Hi, Tobias. I actually need this when using LLVM from a build tree and the header files are not found. LLVM_INCLUDEDIR is /include and the header files are in /include. Cheers, Vinson On Sat, Dec 3, 2016 at 4:55 AM, Tobias Droste wrote: > Hi Vinson, > > this should not be needed and is obsolete

Re: [Mesa-dev] [PATCH] configure.ac: Strip patch version from LLVM version.

2016-12-03 Thread Tobias Droste
Hi Vinson, this should not be needed and is obsolete as soon as this gets merged (Emil?): https://lists.freedesktop.org/archives/mesa-dev/2016-November/135840.html Did you actually need this or were you just seeing that the code is wrong? Because LLVM >=3.1 has the header files and this code shou

[Mesa-dev] [PATCH] configure.ac: Strip patch version from LLVM version.

2016-12-02 Thread Vinson Lee
HAVE_LLVM variable included the patch version if the LLVM version had a patch version. For LLVM version '4.0.0', HAVE_LLVM would be '0x0400.0'. Fixes: 45574ab2e92f ("configure.ac: better detection of LLVM version") Signed-off-by: Vinson Lee --- configure.ac | 2 +- 1 file changed, 1 insertion(+