Re: [Mesa-dev] [PATCH] configure.ac: Respect LLVM_CFLAGS in LLVM version detection

2016-12-19 Thread Tomasz Figa
On Mon, Dec 19, 2016 at 8:06 PM, Emil Velikov wrote: > On 19 December 2016 at 08:52, Tomasz Figa wrote: >> Hi Tobias, >> >> On Sat, Dec 17, 2016 at 2:15 AM, Tobias Droste wrote: >>> Hi Tomasz, >>> >>> does this actually fix anything? >>> >>> Because right now llvm-config.h does not include anyth

Re: [Mesa-dev] [PATCH] configure.ac: Respect LLVM_CFLAGS in LLVM version detection

2016-12-19 Thread Emil Velikov
On 19 December 2016 at 08:52, Tomasz Figa wrote: > Hi Tobias, > > On Sat, Dec 17, 2016 at 2:15 AM, Tobias Droste wrote: >> Hi Tomasz, >> >> does this actually fix anything? >> >> Because right now llvm-config.h does not include anything and I doubt it will >> in the future, as it's just a collect

Re: [Mesa-dev] [PATCH] configure.ac: Respect LLVM_CFLAGS in LLVM version detection

2016-12-19 Thread Tomasz Figa
Hi Tobias, On Sat, Dec 17, 2016 at 2:15 AM, Tobias Droste wrote: > Hi Tomasz, > > does this actually fix anything? > > Because right now llvm-config.h does not include anything and I doubt it will > in the future, as it's just a collection of defines. > The path to the header file itself is given

Re: [Mesa-dev] [PATCH] configure.ac: Respect LLVM_CFLAGS in LLVM version detection

2016-12-16 Thread Tobias Droste
Hi Tomasz, does this actually fix anything? Because right now llvm-config.h does not include anything and I doubt it will in the future, as it's just a collection of defines. The path to the header file itself is given by llvm-config ($LLVM_INCLUDEDIR). Did you just happen to see this or do you

[Mesa-dev] [PATCH] configure.ac: Respect LLVM_CFLAGS in LLVM version detection

2016-12-14 Thread Tomasz Figa
When compiling LLVM headers, including llvm-config.h, we need to respect LLVM_CFLAGS. This is especially crucial if LLVM is located in a non-standard location and it happens that llvm-config.h includes another header. In such case the detection would fail due to missing header, because the path is