Re: [Mesa-dev] [PATCH] clover: fix piglit cl-api-build-program test

2014-08-17 Thread Francisco Jerez
EdB writes: > On Sunday, August 17, 2014 11:50:12 PM Francisco Jerez wrote: >> EdB writes: >> > Hello >> > >> > There is a crash with your version. >> > This one works >> >> Oops, sorry for that. It seems like a hack to me to force the kernel >> reference count to one to keep it from being de

Re: [Mesa-dev] [PATCH] clover: fix piglit cl-api-build-program test

2014-08-17 Thread EdB
On Sunday, August 17, 2014 11:50:12 PM Francisco Jerez wrote: > EdB writes: > > Hello > > > > There is a crash with your version. > > This one works > > Oops, sorry for that. It seems like a hack to me to force the kernel > reference count to one to keep it from being destroyed... Can you try

Re: [Mesa-dev] [PATCH] clover: fix piglit cl-api-build-program test

2014-08-17 Thread Francisco Jerez
EdB writes: > Hello > > There is a crash with your version. > This one works > Oops, sorry for that. It seems like a hack to me to force the kernel reference count to one to keep it from being destroyed... Can you try the attached patch instead on top of my clover-next branch [1]? 8010325eaf a

Re: [Mesa-dev] [PATCH] clover: fix piglit cl-api-build-program test

2014-08-16 Thread EdB
Hello There is a crash with your version. This one works --- diff --git a/src/gallium/state_trackers/clover/api/program.cpp b/src/gallium/state_trackers/clover/api/program.cpp index b81ce69..ab6cf7c 100644 --- a/src/gallium/state_trackers/clover/api/program.cpp +++ b/src/gallium/state_trackers/c

Re: [Mesa-dev] [PATCH] clover: fix piglit cl-api-build-program test

2014-08-16 Thread Francisco Jerez
EdB writes: > On Saturday, August 16, 2014 04:37:08 PM Francisco Jerez wrote: >> EdB writes: >> > program build should failed if there is created kernel attached to program >> > >> > piglit error: >> > "Trigger CL_INVALID_OPERATION if there are kernel objects attached to >> > program"> >> >[...

Re: [Mesa-dev] [PATCH] clover: fix piglit cl-api-build-program test

2014-08-16 Thread EdB
On Saturday, August 16, 2014 04:37:08 PM Francisco Jerez wrote: > EdB writes: > > program build should failed if there is created kernel attached to program > > > > piglit error: > > "Trigger CL_INVALID_OPERATION if there are kernel objects attached to > > program"> > >[...] > > How about doing

Re: [Mesa-dev] [PATCH] clover: fix piglit cl-api-build-program test

2014-08-16 Thread Francisco Jerez
EdB writes: > program build should failed if there is created kernel attached to program > > piglit error: > "Trigger CL_INVALID_OPERATION if there are kernel objects attached to program" >[...] How about doing it as follows? From 4c18eaad1a2c741152a913795814092bf026 Mon Sep 17 00:00:00 200

[Mesa-dev] [PATCH] clover: fix piglit cl-api-build-program test

2014-08-10 Thread EdB
program build should failed if there is created kernel attached to program piglit error: "Trigger CL_INVALID_OPERATION if there are kernel objects attached to program" --- src/gallium/state_trackers/clover/api/kernel.cpp | 10 -- src/gallium/state_trackers/clover/core/kernel.cpp | 1 +