Re: [Mesa-dev] [PATCH] clover: Fix clBuildProgram piglit regression

2014-11-03 Thread Francisco Jerez
Tom Stellard writes: > Should trigger CL_INVALID_VALUE if device_list is NULL and num_devices > is greater than zero. > > Introduced by e5468dfa523be2a7a0d04bb9efcf8ae780957563 > > Reported by: EdB > --- > > Hi Francisco, > > I understand what you are saying now about why we don't need to pass th

[Mesa-dev] [PATCH] clover: Fix clBuildProgram piglit regression

2014-11-03 Thread Tom Stellard
Should trigger CL_INVALID_VALUE if device_list is NULL and num_devices is greater than zero. Introduced by e5468dfa523be2a7a0d04bb9efcf8ae780957563 Reported by: EdB --- Hi Francisco, I understand what you are saying now about why we don't need to pass the vector of devices. It's because the de

Re: [Mesa-dev] [PATCH] clover: fix clBuildProgram Piglit regression

2014-11-03 Thread Francisco Jerez
Tom Stellard writes: > On Sun, Nov 02, 2014 at 08:03:31PM +0200, Francisco Jerez wrote: >> EdB writes: >> >> > should trigger CL_INVALID_VALUE >> > if device_list is NULL and num_devices is greater than zero. >> > >> > introduced by e5468dfa523be2a7a0d04bb9efcf8ae780957563 >> >> Tom, can you j

Re: [Mesa-dev] [PATCH] clover: fix clBuildProgram Piglit regression

2014-11-02 Thread Tom Stellard
On Sun, Nov 02, 2014 at 08:03:31PM +0200, Francisco Jerez wrote: > EdB writes: > > > should trigger CL_INVALID_VALUE > > if device_list is NULL and num_devices is greater than zero. > > > > introduced by e5468dfa523be2a7a0d04bb9efcf8ae780957563 > > Tom, can you just drop the the vector of device

Re: [Mesa-dev] [PATCH] clover: fix clBuildProgram Piglit regression

2014-11-02 Thread Francisco Jerez
EdB writes: > should trigger CL_INVALID_VALUE > if device_list is NULL and num_devices is greater than zero. > > introduced by e5468dfa523be2a7a0d04bb9efcf8ae780957563 Tom, can you just drop the the vector of devices parameter and validate the d_devs/num_devs arguments from validate_build_progra

[Mesa-dev] [PATCH] clover: fix clBuildProgram Piglit regression

2014-11-02 Thread EdB
should trigger CL_INVALID_VALUE if device_list is NULL and num_devices is greater than zero. introduced by e5468dfa523be2a7a0d04bb9efcf8ae780957563 --- src/gallium/state_trackers/clover/api/program.cpp | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/src/g