Re: [Mesa-dev] [PATCH] centroid affects interpolation

2014-02-05 Thread Rogovin, Kevin
h Graunke [kenn...@whitecape.org] Sent: Wednesday, February 05, 2014 6:02 AM To: Rogovin, Kevin; mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [PATCH] centroid affects interpolation On 02/04/2014 05:01 AM, Kevin Rogovin wrote: > Place centroid keyword as an interpolation qualifier. > Previously wa

Re: [Mesa-dev] [PATCH] centroid affects interpolation

2014-02-04 Thread Kenneth Graunke
On 02/04/2014 05:01 AM, Kevin Rogovin wrote: > Place centroid keyword as an interpolation qualifier. > Previously was a storage qualifier. Fixes front end > to accept input of the form "centroid in type variable" No, it doesn't. Without your patch, Mesa successfully compiles the following shader:

Re: [Mesa-dev] [PATCH] centroid affects interpolation

2014-02-04 Thread Chris Forbes
`centroid` has never been an interpolation qualifier, though. In GLSL 1.20, `centroid varying` is a storage qualifier. In GLSL 1.30, `centroid in`, `centroid out` are added as storage qualifiers. In GLSL 4.20 (or ARB_shading_language_420pack), `centroid`, `sample`, and `patch` are split from `in`

[Mesa-dev] [PATCH] centroid affects interpolation

2014-02-04 Thread Kevin Rogovin
Place centroid keyword as an interpolation qualifier. Previously was a storage qualifier. Fixes front end to accept input of the form "centroid in type variable" --- src/glsl/glsl_parser.yy | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/src/glsl/glsl_parser.yy b