Re: [Mesa-dev] [PATCH] blit : only error when the stencil and depth bits do not match (v2)

2017-02-19 Thread Max Qian
Yes, that's correct. Mesa was throwing errors for glBlitFramebuffer in the same situations other (e.g nvidia) drivers weren't, causing artifacting for some applications (e.g wine). The bugzilla link has a test apitrace for it. I'll work on the commit and post the revision when I'm done. __

Re: [Mesa-dev] [PATCH] blit : only error when the stencil and depth bits do not match (v2)

2017-02-19 Thread Nicolai Hähnle
Hi Max, can you explain a bit more about the error you're seeing? It looks like the actual functional change is that previously an INVALID_OPERATION error was generated when /mask/ includes DEPTH_BUFFER_BIT but either source or destination had no depth buffer, and with your change no error is

[Mesa-dev] [PATCH] blit : only error when the stencil and depth bits do not match (v2)

2017-02-18 Thread Max Qian
From: Maxqia Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97921 v2 : fix unintentional line removal --- src/mesa/main/blit.c | 84 +--- 1 file changed, 34 insertions(+), 50 deletions(-) diff --git a/src/mesa/main/blit.c b/src/mesa/main/b

[Mesa-dev] [PATCH] blit : only error when the stencil and depth bits do not match

2017-02-18 Thread Max Qian
From: Maxqia Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97921 --- src/mesa/main/blit.c | 85 +--- 1 file changed, 34 insertions(+), 51 deletions(-) diff --git a/src/mesa/main/blit.c b/src/mesa/main/blit.c index e739130f98..2f7b076667 1