Re: [Mesa-dev] [PATCH] aux/pipe_loader: Don't leak error string on dlopen failure

2014-11-14 Thread Ilia Mirkin
On Fri, Nov 14, 2014 at 1:31 PM, Aaron Watry wrote: > On Fri, Nov 14, 2014 at 12:04 PM, Ilia Mirkin wrote: >> On Fri, Nov 14, 2014 at 12:48 PM, Aaron Watry wrote: >>> Signed-off-by: Aaron Watry >>> CC: Ilia Mirkin >>> >>> v4: Call dlerror() twice instead of freeing glibc's memory. >>> Prev

Re: [Mesa-dev] [PATCH] aux/pipe_loader: Don't leak error string on dlopen failure

2014-11-14 Thread Aaron Watry
On Fri, Nov 14, 2014 at 12:04 PM, Ilia Mirkin wrote: > On Fri, Nov 14, 2014 at 12:48 PM, Aaron Watry wrote: >> Signed-off-by: Aaron Watry >> CC: Ilia Mirkin >> >> v4: Call dlerror() twice instead of freeing glibc's memory. >> Prevents issues on C Libraries that don't malloc the error string

Re: [Mesa-dev] [PATCH] aux/pipe_loader: Don't leak error string on dlopen failure

2014-11-14 Thread Ilia Mirkin
On Fri, Nov 14, 2014 at 12:48 PM, Aaron Watry wrote: > Signed-off-by: Aaron Watry > CC: Ilia Mirkin > > v4: Call dlerror() twice instead of freeing glibc's memory. > Prevents issues on C Libraries that don't malloc the error string. > v3: Switch comment to C-Style > v2: Use strdup instead of

[Mesa-dev] [PATCH] aux/pipe_loader: Don't leak error string on dlopen failure

2014-11-14 Thread Aaron Watry
Signed-off-by: Aaron Watry CC: Ilia Mirkin v4: Call dlerror() twice instead of freeing glibc's memory. Prevents issues on C Libraries that don't malloc the error string. v3: Switch comment to C-Style v2: Use strdup instead of calloc/strcpy --- src/gallium/auxiliary/pipe-loader/pipe_loader.c