Re: [Mesa-dev] [PATCH] ast: Updated AST_NUM_OPERATORS for coherence with ast_operators

2016-08-02 Thread Andres Gomez
On Tue, 2016-08-02 at 17:04 +0100, Eric Engestrom wrote: > On Tue, Aug 02, 2016 at 12:20:54PM +0300, Andres Gomez wrote: [snip] > > I'm not sure I'm understanding what you mean. > > > > If you mean to remove the #define and add the value as and additional > > element to the enum, the existence o

Re: [Mesa-dev] [PATCH] ast: Updated AST_NUM_OPERATORS for coherence with ast_operators

2016-08-02 Thread Eric Engestrom
On Tue, Aug 02, 2016 at 12:20:54PM +0300, Andres Gomez wrote: > On Mon, 2016-08-01 at 14:02 +0100, Eric Engestrom wrote: > > On Sun, Jul 31, 2016 at 07:07:34PM +0300, Andres Gomez wrote: > > [snip] > > > > diff --git a/src/compiler/glsl/ast.h b/src/compiler/glsl/ast.h > > > index 157895d..89f531c

Re: [Mesa-dev] [PATCH] ast: Updated AST_NUM_OPERATORS for coherence with ast_operators

2016-08-02 Thread Andres Gomez
On Mon, 2016-08-01 at 14:02 +0100, Eric Engestrom wrote: > On Sun, Jul 31, 2016 at 07:07:34PM +0300, Andres Gomez wrote: [snip] > > diff --git a/src/compiler/glsl/ast.h b/src/compiler/glsl/ast.h > > index 157895d..89f531c 100644 > > --- a/src/compiler/glsl/ast.h > > +++ b/src/compiler/glsl/ast.h

Re: [Mesa-dev] [PATCH] ast: Updated AST_NUM_OPERATORS for coherence with ast_operators

2016-08-01 Thread Matt Turner
On Mon, Aug 1, 2016 at 6:02 AM, Eric Engestrom wrote: > On Sun, Jul 31, 2016 at 07:07:34PM +0300, Andres Gomez wrote: >> AST_NUM_OPERATORS stores the dimension of the ast_operators >> enumeration but was not updated after its last modification. >> >> This doesn't add any real modification for any

Re: [Mesa-dev] [PATCH] ast: Updated AST_NUM_OPERATORS for coherence with ast_operators

2016-08-01 Thread Eric Engestrom
On Sun, Jul 31, 2016 at 07:07:34PM +0300, Andres Gomez wrote: > AST_NUM_OPERATORS stores the dimension of the ast_operators > enumeration but was not updated after its last modification. > > This doesn't add any real modification for any code paths but it makes > sense for coherence. > > Signed-o

[Mesa-dev] [PATCH] ast: Updated AST_NUM_OPERATORS for coherence with ast_operators

2016-07-31 Thread Andres Gomez
AST_NUM_OPERATORS stores the dimension of the ast_operators enumeration but was not updated after its last modification. This doesn't add any real modification for any code paths but it makes sense for coherence. Signed-off-by: Andres Gomez --- src/compiler/glsl/ast.h | 19 ++--