Re: [Mesa-dev] [PATCH] anv: blorp: support multiple aspect blits

2018-08-30 Thread Dylan Baker
Quoting Lionel Landwerlin (2018-08-30 06:42:06) > Newer blit tests are enabling depth&stencils blits. We currently don't > support it but can do by iterating over the aspects masks (copy some > logic from the CopyImage function). > > Signed-off-by: Lionel Landwerlin > Fixes: 9f44745eca0e41 ("anv:

[Mesa-dev] [PATCH] anv: blorp: support multiple aspect blits

2018-08-30 Thread Lionel Landwerlin
Newer blit tests are enabling depth&stencils blits. We currently don't support it but can do by iterating over the aspects masks (copy some logic from the CopyImage function). Signed-off-by: Lionel Landwerlin Fixes: 9f44745eca0e41 ("anv: Use blorp to implement VkBlitImage") Reviewed-by: Jason Eks

Re: [Mesa-dev] [PATCH] anv: blorp: support multiple aspect blits

2018-08-29 Thread Dylan Baker
Quoting Lionel Landwerlin (2018-08-28 04:27:13) > Newer blit tests are enabling depth&stencils blits. We currently don't > support it but can do by iterating over the aspects masks (copy some > logic from the CopyImage function). > > Signed-off-by: Lionel Landwerlin > Fixes: 9f44745eca0e41 ("anv:

Re: [Mesa-dev] [PATCH] anv: blorp: support multiple aspect blits

2018-08-28 Thread Lionel Landwerlin
Thanks a lot! Looks like reviewing patches on gitlab could really help ;) - Lionel On 28/08/2018 18:18, Jason Ekstrand wrote: Assuming nothing got lost in the indent, looks good to me. Reviewed-by: Jason Ekstrand > On Tue, Aug 28, 2018 at 6:27 AM Lionel Landwerl

Re: [Mesa-dev] [PATCH] anv: blorp: support multiple aspect blits

2018-08-28 Thread Jason Ekstrand
Assuming nothing got lost in the indent, looks good to me. Reviewed-by: Jason Ekstrand On Tue, Aug 28, 2018 at 6:27 AM Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > Newer blit tests are enabling depth&stencils blits. We currently don't > support it but can do by iterating over the

[Mesa-dev] [PATCH] anv: blorp: support multiple aspect blits

2018-08-28 Thread Lionel Landwerlin
Newer blit tests are enabling depth&stencils blits. We currently don't support it but can do by iterating over the aspects masks (copy some logic from the CopyImage function). Signed-off-by: Lionel Landwerlin Fixes: 9f44745eca0e41 ("anv: Use blorp to implement VkBlitImage") --- src/intel/vulkan/