Re: [Mesa-dev] [PATCH] anv: Properly initialize device->slice_hash.

2019-08-15 Thread Jason Ekstrand
On Thu, Aug 15, 2019 at 10:48 AM Rafael Antognolli < rafael.antogno...@intel.com> wrote: > On Wed, Aug 14, 2019 at 10:05:34PM -0500, Jason Ekstrand wrote: > > I take it this happens when subslices_delta == 0 and we take the early > return? > > Yes, exactly, in that case device->slice_hash is not i

Re: [Mesa-dev] [PATCH] anv: Properly initialize device->slice_hash.

2019-08-15 Thread Rafael Antognolli
On Wed, Aug 14, 2019 at 10:05:34PM -0500, Jason Ekstrand wrote: > I take it this happens when subslices_delta == 0 and we take the early return? Yes, exactly, in that case device->slice_hash is not initialized. I can add this to the commit message to make it more clear. > On Wed, Aug 14, 2019 at

Re: [Mesa-dev] [PATCH] anv: Properly initialize device->slice_hash.

2019-08-14 Thread Jason Ekstrand
I take it this happens when subslices_delta == 0 and we take the early return? On Wed, Aug 14, 2019 at 5:45 PM Rafael Antognolli < rafael.antogno...@intel.com> wrote: > I failed to initialize it on the other cases in GEN11 and it was causing > a segfault when going through anv_DestroyDevice, if c

[Mesa-dev] [PATCH] anv: Properly initialize device->slice_hash.

2019-08-14 Thread Rafael Antognolli
I failed to initialize it on the other cases in GEN11 and it was causing a segfault when going through anv_DestroyDevice, if compiled with valgrind. Fixes: 7bc022b4bbc ("anv/gen11: Emit SLICE_HASH_TABLE when pipes are unbalanced.) --- src/intel/vulkan/genX_state.c | 4 ++-- 1