Re: [Mesa-dev] [PATCH] anv: Link to libX11-xcb only when unneeded

2016-09-09 Thread Chad Versace
On Thu 08 Sep 2016, Nanley Chery wrote: > Should the title the say needed instead of unneeded? Oops :/ It's already pushed. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] anv: Link to libX11-xcb only when unneeded

2016-09-08 Thread Chad Versace
On Thu 08 Sep 2016, Emil Velikov wrote: > On 8 September 2016 at 04:29, Chad Versace wrote: > > The Makefile unconditionally linked libX11-xcb into libvulkan_intel.so. > > But it's needed only if HAVE_PLATFORM_X11. > > > > Fixes build of libvulkan_intel.so on Chromium OS, which has no X11 > > libr

Re: [Mesa-dev] [PATCH] anv: Link to libX11-xcb only when unneeded

2016-09-08 Thread Nanley Chery
Should the title the say needed instead of unneeded? - Nanley On Wed, Sep 07, 2016 at 08:29:30PM -0700, Chad Versace wrote: > The Makefile unconditionally linked libX11-xcb into libvulkan_intel.so. > But it's needed only if HAVE_PLATFORM_X11. > > Fixes build of libvulkan_intel.so on Chromium OS,

Re: [Mesa-dev] [PATCH] anv: Link to libX11-xcb only when unneeded

2016-09-08 Thread Emil Velikov
On 8 September 2016 at 04:29, Chad Versace wrote: > The Makefile unconditionally linked libX11-xcb into libvulkan_intel.so. > But it's needed only if HAVE_PLATFORM_X11. > > Fixes build of libvulkan_intel.so on Chromium OS, which has no X11 > libraries. > Pretty sure that was the "must fix" part of

Re: [Mesa-dev] [PATCH] anv: Link to libX11-xcb only when unneeded

2016-09-08 Thread Jason Ekstrand
Thanks. Rb On Sep 7, 2016 8:29 PM, "Chad Versace" wrote: > The Makefile unconditionally linked libX11-xcb into libvulkan_intel.so. > But it's needed only if HAVE_PLATFORM_X11. > > Fixes build of libvulkan_intel.so on Chromium OS, which has no X11 > libraries. > > Cc: Kevin Strasser > Cc: Jason

[Mesa-dev] [PATCH] anv: Link to libX11-xcb only when unneeded

2016-09-07 Thread Chad Versace
The Makefile unconditionally linked libX11-xcb into libvulkan_intel.so. But it's needed only if HAVE_PLATFORM_X11. Fixes build of libvulkan_intel.so on Chromium OS, which has no X11 libraries. Cc: Kevin Strasser Cc: Jason Ekstrand Change-Id: Ib42db7db582c4531cf13db65f2ad5d57db1d774d --- src/in