Re: [Mesa-dev] [PATCH] anv/formats: Fix build on gcc-4 and earlier

2016-10-03 Thread Ville Syrjälä
On Fri, Sep 30, 2016 at 04:11:51PM -0700, Jason Ekstrand wrote: > I remember the first tone you fixed this but when I was going the > ISL_SWIZZLE stuff, Wasn't me, or at least I can't recall doing anything of the sort :) > I couldn't find it in the git log so I went ahead and > pushed the change.

Re: [Mesa-dev] [PATCH] anv/formats: Fix build on gcc-4 and earlier

2016-09-30 Thread Jason Ekstrand
I remember the first tone you fixed this but when I was going the ISL_SWIZZLE stuff, I couldn't find it in the git log so I went ahead and pushed the change. Thanks for fixing it again. Reviewed-by: Jason Ekstrand On Sep 30, 2016 1:00 PM, wrote: > From: Ville Syrjälä > > gcc-4 and earlier don

[Mesa-dev] [PATCH] anv/formats: Fix build on gcc-4 and earlier

2016-09-30 Thread ville . syrjala
From: Ville Syrjälä gcc-4 and earlier don't allow compound literals where a constant is required in -std=c99/gnu99 mode, so we can't use ISL_SWIZZLE() when populating the anv_formats[] array. There are a few ways around it: First one would be -std=c89/gnu89, but the rest of the code depends on c9