Re: [Mesa-dev] [PATCH] anv/device: Remove a use of a compound literal

2017-03-17 Thread Ville Syrjälä
On Fri, Mar 17, 2017 at 09:13:39AM -0700, Matt Turner wrote: > On Fri, Mar 17, 2017 at 9:05 AM, Jason Ekstrand wrote: > > On Fri, Mar 17, 2017 at 8:45 AM, Matt Turner wrote: > >> > >> On Thu, Mar 16, 2017 at 2:09 PM, Jason Ekstrand > >> wrote: > >> > Older versions of GCC don't like compound lit

Re: [Mesa-dev] [PATCH] anv/device: Remove a use of a compound literal

2017-03-17 Thread Jason Ekstrand
On Fri, Mar 17, 2017 at 3:15 PM, Ville Syrjälä wrote: > On Fri, Mar 17, 2017 at 09:13:39AM -0700, Matt Turner wrote: > > On Fri, Mar 17, 2017 at 9:05 AM, Jason Ekstrand > wrote: > > > On Fri, Mar 17, 2017 at 8:45 AM, Matt Turner > wrote: > > >> > > >> On Thu, Mar 16, 2017 at 2:09 PM, Jason Ekst

Re: [Mesa-dev] [PATCH] anv/device: Remove a use of a compound literal

2017-03-17 Thread Matt Turner
On Fri, Mar 17, 2017 at 9:05 AM, Jason Ekstrand wrote: > On Fri, Mar 17, 2017 at 8:45 AM, Matt Turner wrote: >> >> On Thu, Mar 16, 2017 at 2:09 PM, Jason Ekstrand >> wrote: >> > Older versions of GCC don't like compound literals in static const >> > variable declarations because they don't think

Re: [Mesa-dev] [PATCH] anv/device: Remove a use of a compound literal

2017-03-17 Thread Jason Ekstrand
On Fri, Mar 17, 2017 at 9:05 AM, Jason Ekstrand wrote: > On Fri, Mar 17, 2017 at 8:45 AM, Matt Turner wrote: > >> On Thu, Mar 16, 2017 at 2:09 PM, Jason Ekstrand >> wrote: >> > Older versions of GCC don't like compound literals in static const >> > variable declarations because they don't think

Re: [Mesa-dev] [PATCH] anv/device: Remove a use of a compound literal

2017-03-17 Thread Jason Ekstrand
On Fri, Mar 17, 2017 at 8:45 AM, Matt Turner wrote: > On Thu, Mar 16, 2017 at 2:09 PM, Jason Ekstrand > wrote: > > Older versions of GCC don't like compound literals in static const > > variable declarations because they don't think it's an actual constant > > value. > > Probably because the typ

Re: [Mesa-dev] [PATCH] anv/device: Remove a use of a compound literal

2017-03-17 Thread Matt Turner
On Thu, Mar 16, 2017 at 2:09 PM, Jason Ekstrand wrote: > Older versions of GCC don't like compound literals in static const > variable declarations because they don't think it's an actual constant > value. Probably because the type it was cast to was explicitly non-const.

Re: [Mesa-dev] [PATCH] anv/device: Remove a use of a compound literal

2017-03-17 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 16/03/17 21:09, Jason Ekstrand wrote: Older versions of GCC don't like compound literals in static const variable declarations because they don't think it's an actual constant value. --- src/intel/vulkan/anv_device.c | 2 +- 1 file changed, 1 insertion(+), 1

[Mesa-dev] [PATCH] anv/device: Remove a use of a compound literal

2017-03-16 Thread Jason Ekstrand
Older versions of GCC don't like compound literals in static const variable declarations because they don't think it's an actual constant value. --- src/intel/vulkan/anv_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/an