Re: [Mesa-dev] [PATCH] amd: build addrlib with C++11

2017-11-16 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Wed, Nov 15, 2017 at 12:55 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > It is required for LLVM anyway. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103658 > Fixes: 7f33e94e43a6 ("amd/addrlib: update to latest version") > --- > src/amd/M

Re: [Mesa-dev] [PATCH] amd: build addrlib with C++11

2017-11-16 Thread Vinson Lee
On Wed, Nov 15, 2017 at 3:55 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > It is required for LLVM anyway. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103658 > Fixes: 7f33e94e43a6 ("amd/addrlib: update to latest version") > --- > src/amd/Makefile.addrlib.am | 2 +- > 1 file

Re: [Mesa-dev] [PATCH] amd: build addrlib with C++11

2017-11-15 Thread Dylan Baker
Quoting Ilia Mirkin (2017-11-15 09:52:06) > On Wed, Nov 15, 2017 at 12:47 PM, Dylan Baker wrote: > > Nope. meson builds all C++ code as C++11 because so much of mesa's C++ code > > cannot be built without it (Because of LLVM). As far as I can tell the GLSL > > compiler and the Intel Compiler are t

Re: [Mesa-dev] [PATCH] amd: build addrlib with C++11

2017-11-15 Thread Ilia Mirkin
On Wed, Nov 15, 2017 at 12:47 PM, Dylan Baker wrote: > Nope. meson builds all C++ code as C++11 because so much of mesa's C++ code > cannot be built without it (Because of LLVM). As far as I can tell the GLSL > compiler and the Intel Compiler are the only C++ code in mesa not using C++11. Actuall

Re: [Mesa-dev] [PATCH] amd: build addrlib with C++11

2017-11-15 Thread Nicolai Hähnle
On 15.11.2017 17:45, Kai Wasserbäch wrote: Doesn't the meson.build file need the same change? I don't really know Meson, but the master build file looks to me like Meson always builds with C++11. Cheers, Nicolai Nicolai Hähnle wrote on 15.11.2017 12:55: From: Nicolai Hähnle It is requi

Re: [Mesa-dev] [PATCH] amd: build addrlib with C++11

2017-11-15 Thread Dylan Baker
Nope. meson builds all C++ code as C++11 because so much of mesa's C++ code cannot be built without it (Because of LLVM). As far as I can tell the GLSL compiler and the Intel Compiler are the only C++ code in mesa not using C++11. Quoting Kai Wasserbäch (2017-11-15 08:45:30) > Doesn't the meson.bu

Re: [Mesa-dev] [PATCH] amd: build addrlib with C++11

2017-11-15 Thread Kai Wasserbäch
Doesn't the meson.build file need the same change? Nicolai Hähnle wrote on 15.11.2017 12:55: > From: Nicolai Hähnle > > It is required for LLVM anyway. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103658 > Fixes: 7f33e94e43a6 ("amd/addrlib: update to latest version") > --- > src/

[Mesa-dev] [PATCH] amd: build addrlib with C++11

2017-11-15 Thread Nicolai Hähnle
From: Nicolai Hähnle It is required for LLVM anyway. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103658 Fixes: 7f33e94e43a6 ("amd/addrlib: update to latest version") --- src/amd/Makefile.addrlib.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/Makefile.a