Re: [Mesa-dev] [PATCH] ac/surface: Don't assert that bpp is power of two.

2018-05-15 Thread Marek Olšák
On Tue, May 15, 2018 at 3:36 PM, Bas Nieuwenhuizen wrote: > On Tue, May 15, 2018 at 9:34 PM, Marek Olšák wrote: > > On Tue, May 15, 2018 at 3:32 PM, Bas Nieuwenhuizen < > b...@basnieuwenhuizen.nl> > > wrote: > >> > >> No, this is a vulkan issue, where we want to let apps create linear > >> RGB f

Re: [Mesa-dev] [PATCH] ac/surface: Don't assert that bpp is power of two.

2018-05-15 Thread Bas Nieuwenhuizen
On Tue, May 15, 2018 at 9:34 PM, Marek Olšák wrote: > On Tue, May 15, 2018 at 3:32 PM, Bas Nieuwenhuizen > wrote: >> >> No, this is a vulkan issue, where we want to let apps create linear >> RGB float surfaces. (AMDVLK exposes this too: >> http://vulkan.gpuinfo.org/displayreport.php?id=3222#forma

Re: [Mesa-dev] [PATCH] ac/surface: Don't assert that bpp is power of two.

2018-05-15 Thread Marek Olšák
On Tue, May 15, 2018 at 3:32 PM, Bas Nieuwenhuizen wrote: > No, this is a vulkan issue, where we want to let apps create linear > RGB float surfaces. (AMDVLK exposes this too: > http://vulkan.gpuinfo.org/displayreport.php?id=3222#formats, see > R32G32B32_SFLOAT and friends) Vulkan has no conecept

Re: [Mesa-dev] [PATCH] ac/surface: Don't assert that bpp is power of two.

2018-05-15 Thread Bas Nieuwenhuizen
No, this is a vulkan issue, where we want to let apps create linear RGB float surfaces. (AMDVLK exposes this too: http://vulkan.gpuinfo.org/displayreport.php?id=3222#formats, see R32G32B32_SFLOAT and friends) Vulkan has no conecept of staging textures (or at least the app does not have to tell the

Re: [Mesa-dev] [PATCH] ac/surface: Don't assert that bpp is power of two.

2018-05-15 Thread Marek Olšák
Would this work for you instead? https://cgit.freedesktop.org/~mareko/mesa/commit/?h=user-stride&id=1fadff480e53fb691add602933c5d711d7e4b6e0 Marek On Mon, May 14, 2018 at 5:10 PM, Bas Nieuwenhuizen wrote: > There are non-shared linear images too, and those don't > need the extra alignment at al

[Mesa-dev] [PATCH] ac/surface: Don't assert that bpp is power of two.

2018-05-14 Thread Bas Nieuwenhuizen
There are non-shared linear images too, and those don't need the extra alignment at all. So just keep track of whether the image can be exported. Fixes: e361970ed73 "radv: Add support for IMG_DATA_FORMAT_32_32_32." --- src/amd/common/ac_surface.c | 10 ++ 1 file changed, 6 insertions(+),