Re: [Mesa-dev] [PATCH] ac/nir: fix image dimension for subpass attachments

2018-04-23 Thread Samuel Pitoiset
On 04/23/2018 01:24 PM, Nicolai Hähnle wrote: On 20.04.2018 18:06, Samuel Pitoiset wrote: For subpass attachments we need one more coordinate with the sample index, so make them array types. Sorry about that. Shouldn't it be layer index instead of sample index though? No worries! Yes, sh

Re: [Mesa-dev] [PATCH] ac/nir: fix image dimension for subpass attachments

2018-04-23 Thread Nicolai Hähnle
On 20.04.2018 18:06, Samuel Pitoiset wrote: For subpass attachments we need one more coordinate with the sample index, so make them array types. Sorry about that. Shouldn't it be layer index instead of sample index though? If I understand this right, I think it would be cleaner to just chang

[Mesa-dev] [PATCH] ac/nir: fix image dimension for subpass attachments

2018-04-20 Thread Samuel Pitoiset
For subpass attachments we need one more coordinate with the sample index, so make them array types. This fixes a bunch of CTS fails with RADV. Fixes: 24fb3e6aa1 ("ac/nir: use ac_build_image_opcode for image intrinsics") Signed-off-by: Samuel Pitoiset --- src/amd/common/ac_nir_to_llvm.c | 18 ++