Re: [Mesa-dev] [PATCH] R600: Verify all instructions in the AsmPrinter on debug builds

2014-02-25 Thread Tom Stellard
I think I'll just drop the bug report url entirely. All R600 bugs so far have been reported to bugs.freedesktop.org, and I'm not sure bugs filed at llvm.org/bugs will get the same level of attention. -Tom On Tue, Feb 25, 2014 at 02:35:32PM -0800, Eric Christopher wrote: > Yep. Pretty sure. > >

Re: [Mesa-dev] [PATCH] R600: Verify all instructions in the AsmPrinter on debug builds

2014-02-25 Thread Eric Christopher
Yep. Pretty sure. -eric On Tue, Feb 25, 2014 at 2:30 PM, Matt Arsenault wrote: > On 02/25/2014 02:01 PM, Eric Christopher wrote: >> >> Also it probably shouldn't reference an external bug reporter. >> >> -eric > > > There's a build configure bug report URL you could use (which is where I > assum

Re: [Mesa-dev] [PATCH] R600: Verify all instructions in the AsmPrinter on debug builds

2014-02-25 Thread Eric Christopher
Also it probably shouldn't reference an external bug reporter. -eric On Tue, Feb 25, 2014 at 1:54 PM, Tom Stellard wrote: > On Tue, Feb 25, 2014 at 01:47:17PM -0800, Matt Arsenault wrote: >> On 02/25/2014 01:42 PM, Tom Stellard wrote: >> > +errs() << "Please file a bug a bugs.freedesktop.org

Re: [Mesa-dev] [PATCH] R600: Verify all instructions in the AsmPrinter on debug builds

2014-02-25 Thread Matt Arsenault
On 02/25/2014 02:01 PM, Eric Christopher wrote: Also it probably shouldn't reference an external bug reporter. -eric There's a build configure bug report URL you could use (which is where I assume the llvm.org/bugs link comes from in the output from a crash) On Tue, Feb 25, 2014 at 1:54 PM,

Re: [Mesa-dev] [PATCH] R600: Verify all instructions in the AsmPrinter on debug builds

2014-02-25 Thread Matt Arsenault
On 02/25/2014 01:42 PM, Tom Stellard wrote: +errs() << "Please file a bug a bugs.freedesktop.org\n"; Typo, s/a/at/ ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] R600: Verify all instructions in the AsmPrinter on debug builds

2014-02-25 Thread Tom Stellard
On Tue, Feb 25, 2014 at 01:47:17PM -0800, Matt Arsenault wrote: > On 02/25/2014 01:42 PM, Tom Stellard wrote: > > +errs() << "Please file a bug a bugs.freedesktop.org\n"; > Typo, s/a/at/ > Thanks, I will fix this before I commit. -Tom > ___ > llvm

[Mesa-dev] [PATCH] R600: Verify all instructions in the AsmPrinter on debug builds

2014-02-25 Thread Tom Stellard
Make a call to R600's implementation of verifyInstruction() to check that instructions are only using legal operands. --- lib/Target/R600/AMDGPUMCInstLower.cpp | 8 1 file changed, 8 insertions(+) diff --git a/lib/Target/R600/AMDGPUMCInstLower.cpp b/lib/Target/R600/AMDGPUMCInstLower.cpp