Re: [Mesa-dev] [PATCH] R600/SI: Fix fneg for 0.0

2014-02-03 Thread Michel Dänzer
On Mon, 2014-02-03 at 14:16 -0800, Tom Stellard wrote: > > It's clear that there a few things that are wrong which are unrelated to this > patch, so I think it is fine as is. Could you add a comment above the pattern > explaining why we need to manually toggle the sign bit and also a todo to fix

Re: [Mesa-dev] [PATCH] R600/SI: Fix fneg for 0.0

2014-02-03 Thread Tom Stellard
On Mon, Feb 03, 2014 at 04:43:10PM +0900, Michel Dänzer wrote: > On Don, 2014-01-30 at 10:43 -0500, Tom Stellard wrote: > > On Wed, Jan 29, 2014 at 06:23:00PM +0900, Michel Dänzer wrote: > > > From: Michel Dänzer > > > > > > V_ADD_F32 with source modifier does not produce -0.0 for this. Just > >

Re: [Mesa-dev] [PATCH] R600/SI: Fix fneg for 0.0

2014-02-02 Thread Michel Dänzer
On Don, 2014-01-30 at 10:43 -0500, Tom Stellard wrote: > On Wed, Jan 29, 2014 at 06:23:00PM +0900, Michel Dänzer wrote: > > From: Michel Dänzer > > > > V_ADD_F32 with source modifier does not produce -0.0 for this. Just > > manipulate the sign bit directly instead. > > That's strange, so does th

Re: [Mesa-dev] [PATCH] R600/SI: Fix fneg for 0.0

2014-01-30 Thread Tom Stellard
On Wed, Jan 29, 2014 at 06:23:00PM +0900, Michel Dänzer wrote: > From: Michel Dänzer > > V_ADD_F32 with source modifier does not produce -0.0 for this. Just > manipulate the sign bit directly instead. > That's strange, so does this mean we can never use these modifiers? > Also add a pattern fo

[Mesa-dev] [PATCH] R600/SI: Fix fneg for 0.0

2014-01-29 Thread Michel Dänzer
From: Michel Dänzer V_ADD_F32 with source modifier does not produce -0.0 for this. Just manipulate the sign bit directly instead. Also add a pattern for (fneg (fabs ...)). Fixes a bunch of bit encoding piglit tests with radeonsi. Signed-off-by: Michel Dänzer --- lib/Target/R600/SIInstruction