Re: [Mesa-dev] [PATCH] R600/SI: Add pattern for fp_to_uint

2013-07-30 Thread Tom Stellard
On Tue, Jul 30, 2013 at 05:54:58PM +0200, Michel Dänzer wrote: > On Die, 2013-07-30 at 07:47 -0700, Tom Stellard wrote: > > > > You will need to include a lit test with this patch. > > Ah yes, this occurred to me after my review. :) > > > > Also, if you try to run piglit with a debug version of

Re: [Mesa-dev] [PATCH] R600/SI: Add pattern for fp_to_uint

2013-07-30 Thread Michel Dänzer
On Die, 2013-07-30 at 07:47 -0700, Tom Stellard wrote: > > You will need to include a lit test with this patch. Ah yes, this occurred to me after my review. :) > Also, if you try to run piglit with a debug version of LLVM, it will > take forever. I always install a release version of llvm for

Re: [Mesa-dev] [PATCH] R600/SI: Add pattern for fp_to_uint

2013-07-30 Thread Tom Stellard
On Tue, Jul 30, 2013 at 03:45:13AM +0200, Marek Olšák wrote: > This fixes the F2U opcode for the Mesa driver. > > Signed-off-by: Marek Olšák Hi Marek, You will need to include a lit test with this patch. lit tests are located in test/CodeGen/R600. You can reuse the existing fp_to_uint.ll test

Re: [Mesa-dev] [PATCH] R600/SI: Add pattern for fp_to_uint

2013-07-30 Thread Marek Olšák
No, I don't. This is a git patch. Marek On Tue, Jul 30, 2013 at 7:53 AM, Michel Dänzer wrote: > On Die, 2013-07-30 at 03:45 +0200, Marek Olšák wrote: >> This fixes the F2U opcode for the Mesa driver. >> >> Signed-off-by: Marek Olšák > > Reviewed-by: Michel Dänzer > > Do you have LLVM SVN write

Re: [Mesa-dev] [PATCH] R600/SI: Add pattern for fp_to_uint

2013-07-29 Thread Michel Dänzer
On Die, 2013-07-30 at 03:45 +0200, Marek Olšák wrote: > This fixes the F2U opcode for the Mesa driver. > > Signed-off-by: Marek Olšák Reviewed-by: Michel Dänzer Do you have LLVM SVN write access? -- Earthling Michel Dänzer | http://www.amd.com Libre software enth

[Mesa-dev] [PATCH] R600/SI: Add pattern for fp_to_uint

2013-07-29 Thread Marek Olšák
This fixes the F2U opcode for the Mesa driver. Signed-off-by: Marek Olšák --- lib/Target/R600/SIInstructions.td | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/Target/R600/SIInstructions.td b/lib/Target/R600/SIInstructions.td index 0d50c5d..c392238 100644 --- a/lib/Ta