Re: [Mesa-dev] [PATCH] Mesa prog_optimize.c: better optimization for Mesa programs

2010-08-13 Thread Segovia, Benjamin
@lists.freedesktop.org Subject: Re: [Mesa-dev] [PATCH] Mesa prog_optimize.c: better optimization for Mesa programs On 08/11/2010 09:21 PM, Segovia, Benjamin wrote: > Corrected. > > I rescaned the whole code and tried to perform more aggressive checks. > I rerun all the tests, warsow and nexuiz. >

Re: [Mesa-dev] [PATCH] Mesa prog_optimize.c: better optimization for Mesa programs

2010-08-13 Thread Brian Paul
On 08/11/2010 09:21 PM, Segovia, Benjamin wrote: Corrected. I rescaned the whole code and tried to perform more aggressive checks. I rerun all the tests, warsow and nexuiz. Please find the updated patch attached. Committed. Thanks. -Brian ___ mesa

Re: [Mesa-dev] [PATCH] Mesa prog_optimize.c: better optimization for Mesa programs

2010-08-11 Thread Segovia, Benjamin
:34 PM To: Segovia, Benjamin Cc: mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [PATCH] Mesa prog_optimize.c: better optimization for Mesa programs On Wed, Aug 11, 2010 at 7:12 PM, Brian Paul wrote: > I'm just reviewing the patch again and doing some testing. I'll > pr

Re: [Mesa-dev] [PATCH] Mesa prog_optimize.c: better optimization for Mesa programs

2010-08-11 Thread Brian Paul
On Wed, Aug 11, 2010 at 7:12 PM, Brian Paul wrote: > I'm just reviewing the patch again and doing some testing.  I'll > probably commit it soon.  Thanks. I found a problem. I was going through the code and added a few new assertions. At line 526 or so we use the loop counter 'arg' after the loo

Re: [Mesa-dev] [PATCH] Mesa prog_optimize.c: better optimization for Mesa programs

2010-08-11 Thread Brian Paul
I'm just reviewing the patch again and doing some testing. I'll probably commit it soon. Thanks. -Brian On Wed, Aug 11, 2010 at 5:19 PM, Segovia, Benjamin wrote: > Hello all, > is there actually any issue with the patch for the commit? > Cheers, > Ben > ___

Re: [Mesa-dev] [PATCH] Mesa prog_optimize.c: better optimization for Mesa programs

2010-08-11 Thread Segovia, Benjamin
Hello all, is there actually any issue with the patch for the commit? Cheers, Ben From: Segovia, Benjamin Sent: Tuesday, July 27, 2010 7:11 PM To: Segovia, Benjamin; mesa-dev@lists.freedesktop.org Subject: RE: [PATCH] Mesa prog_optimize.c: better optimizati

Re: [Mesa-dev] [PATCH] Mesa prog_optimize.c: better optimization for Mesa programs

2010-07-27 Thread Segovia, Benjamin
I made a new patch.It was simpler since there were a lot of small modifications. Overall the code is simpler now with the proper use of masked operations. Thanks for your help. From: Segovia, Benjamin Sent: Tuesday, July 27, 2010 7:10 PM To: mesa-dev@list

[Mesa-dev] [PATCH] Mesa prog_optimize.c: better optimization for Mesa programs

2010-07-27 Thread Benjamin Segovia
- Thanks to Eric Anholt for his comments and his patch. The code is now much simpler (and (more) correct). Also thanks to Jakob Bornecrantz for his explanation of the difference between glsl and mesa IR - Improved optimization of GPU programs. Now, swizzling is taken into account and swizzle