Re: [Mesa-dev] [PATCH] Mesa: Fix error code for glTexImage3D in GLES

2016-12-22 Thread Chad Versace
On Wed 21 Dec 2016, Xu, Randy wrote: > Hi, Kenneth > > The patch https://android-review.googlesource.com/#/c/291429/ for GLES3.1 has > been merged to dEQP master branch, so expect the GLES3 change should be > merged also. > In this case, we don't need this change in Mesa. The dEQP maitainers

Re: [Mesa-dev] [PATCH] Mesa: Fix error code for glTexImage3D in GLES

2016-12-20 Thread Xu, Randy
aunke [mailto:kenn...@whitecape.org] Sent: Wednesday, December 21, 2016 10:00 AM To: mesa-dev@lists.freedesktop.org Cc: Xu, Randy ; mesa-sta...@lists.freedesktop.org Subject: Re: [Mesa-dev] [PATCH] Mesa: Fix error code for glTexImage3D in GLES On Wednesday, December 21, 2016 9:05:27 AM PST Randy Xu

Re: [Mesa-dev] [PATCH] Mesa: Fix error code for glTexImage3D in GLES

2016-12-20 Thread Kenneth Graunke
On Wednesday, December 21, 2016 9:05:27 AM PST Randy Xu wrote: > From the OGLES 3.2 spec, Section 8.5 Texture Image Specification, page 158: > "An INVALID_OPERATION error is generated if a combination of > values for format, type, and internalformat is specified that is > not listed as a valid

[Mesa-dev] [PATCH] Mesa: Fix error code for glTexImage3D in GLES

2016-12-20 Thread Randy Xu
From the OGLES 3.2 spec, Section 8.5 Texture Image Specification, page 158: "An INVALID_OPERATION error is generated if a combination of values for format, type, and internalformat is specified that is not listed as a valid combination in tables 8.2 or 8.3." It means that TexImage3D should ret

Re: [Mesa-dev] [PATCH] Mesa: Fix error code for glTexImage3D in GLES

2016-12-18 Thread Xu, Randy
ktop.org; mesa-sta...@lists.freedesktop.org Subject: RE: [Mesa-dev] [PATCH] Mesa: Fix error code for glTexImage3D in GLES Hi, Chad & Ian Thanks for your suggestion, and I understand and agree your point, while the texsubimage_error_check (in teximage.c) calls _mesa_error_check_format_and_type first, and if

Re: [Mesa-dev] [PATCH] Mesa: Fix error code for glTexImage3D in GLES

2016-12-18 Thread Xu, Randy
2016 6:02 AM To: Chad Versace ; Xu, Randy ; mesa-dev@lists.freedesktop.org; mesa-sta...@lists.freedesktop.org; x...@freedesktop.org Subject: Re: [Mesa-dev] [PATCH] Mesa: Fix error code for glTexImage3D in GLES On 12/16/2016 12:49 PM, Chad Versace wrote: > On Fri 16 Dec 2016, Chad Versace wrote

Re: [Mesa-dev] [PATCH] Mesa: Fix error code for glTexImage3D in GLES

2016-12-16 Thread Ian Romanick
On 12/16/2016 12:49 PM, Chad Versace wrote: > On Fri 16 Dec 2016, Chad Versace wrote: >> On Fri 16 Dec 2016, Randy Xu wrote: >>> From: "Xu,Randy" >>> >>> The ES specification says that TexImage3D should return GL_INVALID_OPERATION >>> if the internal format is DEPTH_COMPONENT, DEPTH_-STENCIL or ST

Re: [Mesa-dev] [PATCH] Mesa: Fix error code for glTexImage3D in GLES

2016-12-16 Thread Chad Versace
On Fri 16 Dec 2016, Chad Versace wrote: > On Fri 16 Dec 2016, Randy Xu wrote: > > From: "Xu,Randy" > > > > The ES specification says that TexImage3D should return GL_INVALID_OPERATION > > if the internal format is DEPTH_COMPONENT, DEPTH_-STENCIL or STENCIL_INDEX. > > The current code returns INVA

Re: [Mesa-dev] [PATCH] Mesa: Fix error code for glTexImage3D in GLES

2016-12-16 Thread Chad Versace
On Fri 16 Dec 2016, Randy Xu wrote: > From: "Xu,Randy" > > The ES specification says that TexImage3D should return GL_INVALID_OPERATION > if the internal format is DEPTH_COMPONENT, DEPTH_-STENCIL or STENCIL_INDEX. > The current code returns INVALID_ENUM as _mesa_error_check_format_and_type is > u

Re: [Mesa-dev] [PATCH] Mesa: Fix error code for glTexImage3D in GLES

2016-12-15 Thread Edward O'Callaghan
Reviewed-by: Edward O'Callaghan On 12/16/2016 12:56 PM, Randy Xu wrote: > From: "Xu,Randy" > > The ES specification says that TexImage3D should return GL_INVALID_OPERATION > if the internal format is DEPTH_COMPONENT, DEPTH_-STENCIL or STENCIL_INDEX. > The current code returns INVALID_ENUM as _m

[Mesa-dev] [PATCH] Mesa: Fix error code for glTexImage3D in GLES

2016-12-15 Thread Randy Xu
From: "Xu,Randy" The ES specification says that TexImage3D should return GL_INVALID_OPERATION if the internal format is DEPTH_COMPONENT, DEPTH_-STENCIL or STENCIL_INDEX. The current code returns INVALID_ENUM as _mesa_error_check_format_and_type is used by glReadPixels also and the GL specificatio