Re: [Mesa-dev] [PATCH] Integrate precise trig into configuration infrastructure

2016-06-07 Thread Stéphane Marchesin
On Wed, May 11, 2016 at 1:32 PM, Gurchetan Singh wrote: > With this change, to enable precise SIN and COS instructions > on Intel hardware, one can put > > > > in the proper drirc file. > > V2: Make option name more generic Reviewed-by: Stéphane Marchesin > --- > src/mesa/drivers/dri/common/x

Re: [Mesa-dev] [PATCH] Integrate precise trig into configuration infrastructure

2016-05-12 Thread Eero Tamminen
Hi, On 12.05.2016 20:11, Matt Turner wrote: On Thu, May 12, 2016 at 4:49 AM, Eero Tamminen wrote: Multiply is faster instruction than sin/cos, and depending on what else the shader does, good scheduler may be able to hide latency of additional multiply, so I don't think it's quite that bad. :-

Re: [Mesa-dev] [PATCH] Integrate precise trig into configuration infrastructure

2016-05-12 Thread Matt Turner
On Thu, May 12, 2016 at 4:49 AM, Eero Tamminen wrote: > Multiply is faster instruction than sin/cos, and depending on what else the > shader does, good scheduler may be able to hide latency of additional > multiply, so I don't think it's quite that bad. :-) I think you misunderstood what was happ

Re: [Mesa-dev] [PATCH] Integrate precise trig into configuration infrastructure

2016-05-12 Thread Eero Tamminen
Hi, On 12.05.2016 11:05, Kenneth Graunke wrote: On Thursday, May 12, 2016 11:15:58 AM PDT Eero Tamminen wrote: The known cases where this workaround caused slowdown were fixed, so why not just unconditionally enable it? Or is there still some case where workaround causes a measurable slowdown

Re: [Mesa-dev] [PATCH] Integrate precise trig into configuration infrastructure

2016-05-12 Thread Kenneth Graunke
On Thursday, May 12, 2016 11:15:58 AM PDT Eero Tamminen wrote: > Hi, > > The known cases where this workaround caused slowdown were fixed, so > why not just unconditionally enable it? > > Or is there still some case where workaround causes a measurable slowdown? > > > - Eero I mean, it

Re: [Mesa-dev] [PATCH] Integrate precise trig into configuration infrastructure

2016-05-12 Thread Eero Tamminen
Hi, The known cases where this workaround caused slowdown were fixed, so why not just unconditionally enable it? Or is there still some case where workaround causes a measurable slowdown? - Eero On 11.05.2016 23:32, Gurchetan Singh wrote: With this change, to enable precise SIN an

[Mesa-dev] [PATCH] Integrate precise trig into configuration infrastructure

2016-05-11 Thread Gurchetan Singh
With this change, to enable precise SIN and COS instructions on Intel hardware, one can put in the proper drirc file. V2: Make option name more generic --- src/mesa/drivers/dri/common/xmlpool/t_options.h | 5 + src/mesa/drivers/dri/i965/brw_compiler.c| 2 -- src/mesa/drivers/dri/i9

Re: [Mesa-dev] [PATCH] Integrate precise trig into configuration infrastructure

2016-05-07 Thread Kenneth Graunke
On Friday, May 6, 2016 11:53:53 PM PDT Jordan Justen wrote: > On 2016-04-27 14:52:34, Gurchetan Singh wrote: > > With this change, to enable precise SIN and COS instructions > > on Intel hardware, one can put > > > > > > > > in the proper drirc file. > > --- > > src/mesa/drivers/dri/common/xmlp

Re: [Mesa-dev] [PATCH] Integrate precise trig into configuration infrastructure

2016-05-06 Thread Jordan Justen
On 2016-04-27 14:52:34, Gurchetan Singh wrote: > With this change, to enable precise SIN and COS instructions > on Intel hardware, one can put > > > > in the proper drirc file. > --- > src/mesa/drivers/dri/common/xmlpool/t_options.h | 5 + > src/mesa/drivers/dri/i965/brw_compiler.c|

[Mesa-dev] [PATCH] Integrate precise trig into configuration infrastructure

2016-04-27 Thread Gurchetan Singh
With this change, to enable precise SIN and COS instructions on Intel hardware, one can put in the proper drirc file. --- src/mesa/drivers/dri/common/xmlpool/t_options.h | 5 + src/mesa/drivers/dri/i965/brw_compiler.c| 2 -- src/mesa/drivers/dri/i965/brw_context.c | 3 +++ s