Re: [Mesa-dev] [PATCH] Gallium: fix buffer overflow

2011-07-01 Thread Jose Fonseca
Looks fine. Commited. Thanks. Jose - Original Message - > Indeed. This was copied from the indices version of the function, > altough that version seems to do some more work to find out the > true_index. The patch as it is fixes a crash when selecting objects > in blender though. > Ple

Re: [Mesa-dev] [PATCH] Gallium: fix buffer overflow

2011-07-01 Thread Micael
Indeed. This was copied from the indices version of the function, altough that version seems to do some more work to find out the true_index. The patch as it is fixes a crash when selecting objects in blender though. Please verify to make sure it's doing everything correctly since I'm still far fro

Re: [Mesa-dev] [PATCH] Gallium: fix buffer overflow

2011-07-01 Thread Jose Fonseca
I recall seeing this issue before, and I though we had fixed it by ensure the vertices are always padded to be multiple of four.. but I suspect it may have been for fetching indices, and not actual vertices. So it looks good, but let me investigate a bit more. Jose - Original Message -

Re: [Mesa-dev] [PATCH] Gallium: fix buffer overflow

2011-07-01 Thread Keith Whitwell
This looks good to me -- Jose? Keith On Thu, 2011-06-30 at 03:33 +0100, Micael Dias wrote: > --- > src/gallium/auxiliary/draw/draw_llvm.c | 12 > 1 files changed, 12 insertions(+), 0 deletions(-) > > diff --git a/src/gallium/auxiliary/draw/draw_llvm.c > b/src/gallium/auxiliary/d

[Mesa-dev] [PATCH] Gallium: fix buffer overflow

2011-07-01 Thread Micael Dias
--- src/gallium/auxiliary/draw/draw_llvm.c | 12 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/src/gallium/auxiliary/draw/draw_llvm.c b/src/gallium/auxiliary/draw/draw_llvm.c index 56c26f5..19134f3 100644 --- a/src/gallium/auxiliary/draw/draw_llvm.c +++ b/src/gall