Re: [Mesa-dev] [PATCH] Convert git_sha1_gen script to Python.

2017-08-01 Thread Rob Herring
On Tue, Aug 1, 2017 at 8:38 AM, Jose Fonseca wrote: > Python is the scripting language we've been using for scripts that need > to run across all supported platforms. > > Shell is *not* a portable language for scripts. > --- [...] > diff --git a/src/mesa/Android.libmesa_git_sha1.mk > b/src/mesa

Re: [Mesa-dev] [PATCH] Convert git_sha1_gen script to Python.

2017-08-01 Thread Emil Velikov
On 1 August 2017 at 15:37, Jose Fonseca wrote: > On 01/08/17 15:32, Emil Velikov wrote: >> >> On 1 August 2017 at 14:38, Jose Fonseca wrote: >>> >>> Python is the scripting language we've been using for scripts that need >>> to run across all supported platforms. >>> >>> Shell is *not* a portable

Re: [Mesa-dev] [PATCH] Convert git_sha1_gen script to Python.

2017-08-01 Thread Jose Fonseca
On 01/08/17 15:32, Emil Velikov wrote: On 1 August 2017 at 14:38, Jose Fonseca wrote: Python is the scripting language we've been using for scripts that need to run across all supported platforms. Shell is *not* a portable language for scripts. Guessing that you've hit some issues on Windows

Re: [Mesa-dev] [PATCH] Convert git_sha1_gen script to Python.

2017-08-01 Thread Emil Velikov
On 1 August 2017 at 14:38, Jose Fonseca wrote: > Python is the scripting language we've been using for scripts that need > to run across all supported platforms. > > Shell is *not* a portable language for scripts. Guessing that you've hit some issues on Windows? All the other platforms should be

Re: [Mesa-dev] [PATCH] Convert git_sha1_gen script to Python.

2017-08-01 Thread Eric Engestrom
On Tuesday, 2017-08-01 14:47:31 +0100, Eric Engestrom wrote: > On Tuesday, 2017-08-01 14:38:31 +0100, Jose Fonseca wrote: > > Python is the scripting language we've been using for scripts that need > > to run across all supported platforms. > > > > Shell is *not* a portable language for scripts. >

Re: [Mesa-dev] [PATCH] Convert git_sha1_gen script to Python.

2017-08-01 Thread Eric Engestrom
On Tuesday, 2017-08-01 14:38:31 +0100, Jose Fonseca wrote: > Python is the scripting language we've been using for scripts that need > to run across all supported platforms. > > Shell is *not* a portable language for scripts. You beat me to it :) I have a note below, but the patch is Reviewed-by:

[Mesa-dev] [PATCH] Convert git_sha1_gen script to Python.

2017-08-01 Thread Jose Fonseca
Python is the scripting language we've been using for scripts that need to run across all supported platforms. Shell is *not* a portable language for scripts. --- Makefile.am | 2 +- bin/git_sha1_gen.py | 20 bin/git_sha1_gen.sh