Re: [Mesa-dev] [PATCH] Android: major/minor/makedev live in

2017-05-31 Thread Emil Velikov
On 30 May 2017 at 17:51, Rob Herring wrote: > On Tue, May 30, 2017 at 11:46 AM, Mauro Rossi wrote: >> >> >> 2017-05-30 14:23 GMT+02:00 Rob Herring : >>> >>> sysmacros.h was getting implicitly included in types.h until recently in >>> AOSP master. Define MAJOR_IN_SYSMACROS to explicitly include sy

Re: [Mesa-dev] [PATCH] Android: major/minor/makedev live in

2017-05-30 Thread Rob Herring
On Tue, May 30, 2017 at 11:46 AM, Mauro Rossi wrote: > > > 2017-05-30 14:23 GMT+02:00 Rob Herring : >> >> sysmacros.h was getting implicitly included in types.h until recently in >> AOSP master. Define MAJOR_IN_SYSMACROS to explicitly include sysmacros.h. >> >> Signed-off-by: Rob Herring >> --- >

Re: [Mesa-dev] [PATCH] Android: major/minor/makedev live in

2017-05-30 Thread Mauro Rossi
2017-05-30 14:23 GMT+02:00 Rob Herring : > sysmacros.h was getting implicitly included in types.h until recently in > AOSP master. Define MAJOR_IN_SYSMACROS to explicitly include sysmacros.h. > > Signed-off-by: Rob Herring > --- > Android.common.mk | 1 + > 1 file changed, 1 insertion(+) > > dif

Re: [Mesa-dev] [PATCH] Android: major/minor/makedev live in

2017-05-30 Thread Mauro Rossi
2017-05-30 15:41 GMT+02:00 Rob Herring : > On Tue, May 30, 2017 at 8:03 AM, Emil Velikov > wrote: > > On 30 May 2017 at 13:23, Rob Herring wrote: > >> sysmacros.h was getting implicitly included in types.h until recently in > >> AOSP master. Define MAJOR_IN_SYSMACROS to explicitly include > sysm

Re: [Mesa-dev] [PATCH] Android: major/minor/makedev live in

2017-05-30 Thread Rob Herring
On Tue, May 30, 2017 at 8:03 AM, Emil Velikov wrote: > On 30 May 2017 at 13:23, Rob Herring wrote: >> sysmacros.h was getting implicitly included in types.h until recently in >> AOSP master. Define MAJOR_IN_SYSMACROS to explicitly include sysmacros.h. >> > As long as it doesn't break the non-mast

Re: [Mesa-dev] [PATCH] Android: major/minor/makedev live in

2017-05-30 Thread Emil Velikov
On 30 May 2017 at 13:23, Rob Herring wrote: > sysmacros.h was getting implicitly included in types.h until recently in > AOSP master. Define MAJOR_IN_SYSMACROS to explicitly include sysmacros.h. > As long as it doesn't break the non-master branches - L, M, ... Reviewed-by: Emil Velikov -Emil ___

Re: [Mesa-dev] [PATCH] Android: major/minor/makedev live in

2017-05-30 Thread Tapani Pälli
Reviewed-by: Tapani Pälli On 05/30/2017 03:23 PM, Rob Herring wrote: sysmacros.h was getting implicitly included in types.h until recently in AOSP master. Define MAJOR_IN_SYSMACROS to explicitly include sysmacros.h. Signed-off-by: Rob Herring --- Android.common.mk | 1 + 1 file changed, 1

[Mesa-dev] [PATCH] Android: major/minor/makedev live in

2017-05-30 Thread Rob Herring
sysmacros.h was getting implicitly included in types.h until recently in AOSP master. Define MAJOR_IN_SYSMACROS to explicitly include sysmacros.h. Signed-off-by: Rob Herring --- Android.common.mk | 1 + 1 file changed, 1 insertion(+) diff --git a/Android.common.mk b/Android.common.mk index b2bb