Re: [Mesa-dev] [PATCH] Android: fix spirv_info.c generation

2017-07-20 Thread Emil Velikov
On 20 July 2017 at 11:30, Chih-Wei Huang wrote: > It's incorrect to use $(LOCAL_PATH) in makefile recipes since it's > changing. The typical way to handle it is to use private variable. > Fortunately in this case we can just simplify them to $^. > > See further: > https://patchwork.freedesktop.org

Re: [Mesa-dev] [PATCH] Android: fix spirv_info.c generation

2017-07-20 Thread Tapani Pälli
Nice, I think it was done like this in some other occurence too; Reviewed-by: Tapani Pälli On 07/20/2017 01:30 PM, Chih-Wei Huang wrote: It's incorrect to use $(LOCAL_PATH) in makefile recipes since it's changing. The typical way to handle it is to use private variable. Fortunately in this cas

[Mesa-dev] [PATCH] Android: fix spirv_info.c generation

2017-07-20 Thread Chih-Wei Huang
It's incorrect to use $(LOCAL_PATH) in makefile recipes since it's changing. The typical way to handle it is to use private variable. Fortunately in this case we can just simplify them to $^. See further: https://patchwork.freedesktop.org/patch/167718/ Also simplify LOCAL_GENERATED_SOURCES. Fixe