Re: [Mesa-dev] [PATCH] Added pbuffer hooks for surfaceless platform

2016-06-14 Thread Chad Versace
On Mon 16 May 2016, Gurchetan Singh wrote: > This change enables the creation of pbuffer > surfaces on the surfaceless platform. > > v3: Going back to single-buffered pbuffer > plus additional code review changes > --- > src/egl/drivers/dri2/egl_dri2.h | 7 +- > src/egl/drivers/dri2

Re: [Mesa-dev] [PATCH] Added pbuffer hooks for surfaceless platform

2016-06-14 Thread Chad Versace
On Mon 16 May 2016, Gurchetan Singh wrote: > Hi Chad, > > Yes, we are running dEQP on the surfaceless platform. The front-buffered > pbuffer approach mostly works, though with a double-buffered pbuffer or > back-buffered pbuffer + the pastebin changes we do pass an additional 70 > GLES3 tests. I

[Mesa-dev] [PATCH] Added pbuffer hooks for surfaceless platform

2016-05-16 Thread Gurchetan Singh
This change enables the creation of pbuffer surfaces on the surfaceless platform. v3: Going back to single-buffered pbuffer plus additional code review changes --- src/egl/drivers/dri2/egl_dri2.h | 7 +- src/egl/drivers/dri2/platform_surfaceless.c | 213 +++-

Re: [Mesa-dev] [PATCH] Added pbuffer hooks for surfaceless platform

2016-05-16 Thread Gurchetan Singh
Hi Chad, Yes, we are running dEQP on the surfaceless platform. The front-buffered pbuffer approach mostly works, though with a double-buffered pbuffer or back-buffered pbuffer + the pastebin changes we do pass an additional 70 GLES3 tests. It is probably best to follow what X11 does to avoid bre

Re: [Mesa-dev] [PATCH] Added pbuffer hooks for surfaceless platform

2016-05-16 Thread Chad Versace
+Kristian, who also has an interest EGL On Tue 10 May 2016, Gurchetan Singh wrote: > Hi Chad, > > Thanks for the review and good suggestions. I am interested to know your > opinion regarding an issue that comes up when implementing a back-buffered > pbuffer. The problem is we'll be creating a f

Re: [Mesa-dev] [PATCH] Added pbuffer hooks for surfaceless platform

2016-05-10 Thread Gurchetan Singh
Hi Chad, Thanks for the review and good suggestions. I am interested to know your opinion regarding an issue that comes up when implementing a back-buffered pbuffer. The problem is we'll be creating a front renderbuffer, not a back renderbuffer if we pass in single buffered visuals. For example

Re: [Mesa-dev] [PATCH] Added pbuffer hooks for surfaceless platform

2016-05-09 Thread Mark Janes
Gurchetan Singh writes: > This change enables the creation of pbuffer > surfaces on the surfaceless platform. > > V2: Use double-buffered pbuffer configuration > --- > src/egl/drivers/dri2/egl_dri2.h | 8 +- > src/egl/drivers/dri2/platform_surfaceless.c | 219 > +++

Re: [Mesa-dev] [PATCH] Added pbuffer hooks for surfaceless platform

2016-05-06 Thread Chad Versace
On 05/06/2016 03:39 PM, Stéphane Marchesin wrote: > On Fri, May 6, 2016 at 3:32 PM, Gurchetan Singh > wrote: >> This change enables the creation of pbuffer >> surfaces on the surfaceless platform. >> >> V2: Use double-buffered pbuffer configuration > > Reviewed-by: Stéphane Marchesin > > Chad,

Re: [Mesa-dev] [PATCH] Added pbuffer hooks for surfaceless platform

2016-05-06 Thread Stéphane Marchesin
On Fri, May 6, 2016 at 3:32 PM, Gurchetan Singh wrote: > This change enables the creation of pbuffer > surfaces on the surfaceless platform. > > V2: Use double-buffered pbuffer configuration Reviewed-by: Stéphane Marchesin Chad, do you also want to take a look at it? > --- > src/egl/drivers/

[Mesa-dev] [PATCH] Added pbuffer hooks for surfaceless platform

2016-05-06 Thread Gurchetan Singh
This change enables the creation of pbuffer surfaces on the surfaceless platform. V2: Use double-buffered pbuffer configuration --- src/egl/drivers/dri2/egl_dri2.h | 8 +- src/egl/drivers/dri2/platform_surfaceless.c | 219 +++- 2 files changed, 222 insertions