Re: [Mesa-dev] [PATCH] Add support for GL_EXT_unpack_subimage on GLES2

2012-03-27 Thread Kristian Høgsberg
On Thu, Mar 22, 2012 at 10:02 AM, Kristian Høgsberg wrote: > On Wed, Mar 21, 2012 at 2:08 PM, Neil Roberts wrote: >> This extension just permits GL_UNPACK_ROW_LENGTH, GL_UNPACK_SKIP_ROWS >> and GL_UNPACK_SKIP_PIXELS to be passed to glPixelStore on GLES2 so it >> is trivial to implement. > > Looks

Re: [Mesa-dev] [PATCH] Add support for GL_EXT_unpack_subimage on GLES2

2012-03-22 Thread Neil Roberts
On Thu, 22 Mar 2012 10:56:09 -0700, Ian Romanick wrote: > I'm not a fan of the wrappers generated from APIspec.xml. It allowed > quick implementation of the extra enum rejection required by ES, but > it's a real hassle. I don't track the Mesa development that much but I'm not sure what you're

Re: [Mesa-dev] [PATCH] Add support for GL_EXT_unpack_subimage on GLES2

2012-03-22 Thread Ian Romanick
On 03/21/2012 11:08 AM, Neil Roberts wrote: This extension just permits GL_UNPACK_ROW_LENGTH, GL_UNPACK_SKIP_ROWS and GL_UNPACK_SKIP_PIXELS to be passed to glPixelStore on GLES2 so it is trivial to implement. I'm not a fan of the wrappers generated from APIspec.xml. It allowed quick implement

Re: [Mesa-dev] [PATCH] Add support for GL_EXT_unpack_subimage on GLES2

2012-03-22 Thread Kristian Høgsberg
On Wed, Mar 21, 2012 at 2:08 PM, Neil Roberts wrote: > This extension just permits GL_UNPACK_ROW_LENGTH, GL_UNPACK_SKIP_ROWS > and GL_UNPACK_SKIP_PIXELS to be passed to glPixelStore on GLES2 so it > is trivial to implement. Looks good, this should make GLES2 a lot more useful. Reviewed-by: Krist

[Mesa-dev] [PATCH] Add support for GL_EXT_unpack_subimage on GLES2

2012-03-21 Thread Neil Roberts
This extension just permits GL_UNPACK_ROW_LENGTH, GL_UNPACK_SKIP_ROWS and GL_UNPACK_SKIP_PIXELS to be passed to glPixelStore on GLES2 so it is trivial to implement. --- src/mesa/main/APIspec.xml | 26 +- src/mesa/main/extensions.c |1 + 2 files changed, 22 insertions