Re: [Mesa-dev] [PATCH v2] i965: Implement ARB_pipeline_statistics_query tessellation counters.

2015-11-17 Thread Ben Widawsky
On Tue, Nov 17, 2015 at 11:28:25AM -0800, Kristian Høgsberg wrote: > On Tue, Nov 17, 2015 at 11:25 AM, Kenneth Graunke > wrote: > > We basically just need to uncomment Ben's code. > > Reviewed-by: Kristian Høgsberg > Reviewed-by: Ben Widawsky ___

Re: [Mesa-dev] [PATCH v2] i965: Implement ARB_pipeline_statistics_query tessellation counters.

2015-11-17 Thread Kristian Høgsberg
On Tue, Nov 17, 2015 at 11:25 AM, Kenneth Graunke wrote: > We basically just need to uncomment Ben's code. Reviewed-by: Kristian Høgsberg > Signed-off-by: Kenneth Graunke > --- > src/mesa/drivers/dri/i965/gen6_queryobj.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-)

[Mesa-dev] [PATCH v2] i965: Implement ARB_pipeline_statistics_query tessellation counters.

2015-11-17 Thread Kenneth Graunke
We basically just need to uncomment Ben's code. Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/gen6_queryobj.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) Still totally untested, but now less blatantly broken... diff --git a/src/mesa/drivers/dri/i965/ge

Re: [Mesa-dev] [PATCH] [v2] i965: implement ARB_pipeline_statistics_query

2015-02-04 Thread Ben Widawsky
On Mon, Feb 02, 2015 at 11:37:26PM -0500, Ilia Mirkin wrote: > On Mon, Dec 8, 2014 at 9:50 PM, Ben Widawsky wrote: > > Thanks. All the requests look good, and I'll post it in v3. > > What happened to this patch? It was pretty close... should be easy to > add gallium support for it too once it's i

Re: [Mesa-dev] [PATCH] [v2] i965: implement ARB_pipeline_statistics_query

2015-02-02 Thread Ilia Mirkin
On Mon, Dec 8, 2014 at 9:50 PM, Ben Widawsky wrote: > Thanks. All the requests look good, and I'll post it in v3. What happened to this patch? It was pretty close... should be easy to add gallium support for it too once it's in... ___ mesa-dev mailing l

Re: [Mesa-dev] [PATCH] [v2] i965: implement ARB_pipeline_statistics_query

2014-12-08 Thread Ben Widawsky
On Tue, Dec 02, 2014 at 11:07:34PM -0800, Ian Romanick wrote: > Since there will be a v3 anyway, nits below... > > On 12/02/2014 06:33 PM, Ben Widawsky wrote: > > This patch implements ARB_pipeline_statistics_query. This addition to GL > > does > > not add a new API. Instead, it adds new tokens t

Re: [Mesa-dev] [PATCH] [v2] i965: implement ARB_pipeline_statistics_query

2014-12-02 Thread Ian Romanick
Since there will be a v3 anyway, nits below... On 12/02/2014 06:33 PM, Ben Widawsky wrote: > This patch implements ARB_pipeline_statistics_query. This addition to GL does > not add a new API. Instead, it adds new tokens to the existing query APIs. The > work to hook up the new tokens is trivial du

Re: [Mesa-dev] [PATCH] [v2] i965: implement ARB_pipeline_statistics_query

2014-12-02 Thread Ilia Mirkin
On Tue, Dec 2, 2014 at 11:20 PM, Ben Widawsky wrote: > On Tue, Dec 02, 2014 at 10:47:37PM -0500, Ilia Mirkin wrote: >> On Tue, Dec 2, 2014 at 9:33 PM, Ben Widawsky >> wrote: >> > This patch implements ARB_pipeline_statistics_query. This addition to GL >> > does >> > not add a new API. Instead, i

Re: [Mesa-dev] [PATCH] [v2] i965: implement ARB_pipeline_statistics_query

2014-12-02 Thread Ben Widawsky
On Tue, Dec 02, 2014 at 10:47:37PM -0500, Ilia Mirkin wrote: > On Tue, Dec 2, 2014 at 9:33 PM, Ben Widawsky > wrote: > > This patch implements ARB_pipeline_statistics_query. This addition to GL > > does > > not add a new API. Instead, it adds new tokens to the existing query APIs. > > The > > wo

Re: [Mesa-dev] [PATCH] [v2] i965: implement ARB_pipeline_statistics_query

2014-12-02 Thread Ilia Mirkin
On Tue, Dec 2, 2014 at 9:33 PM, Ben Widawsky wrote: > This patch implements ARB_pipeline_statistics_query. This addition to GL does > not add a new API. Instead, it adds new tokens to the existing query APIs. The > work to hook up the new tokens is trivial due to it's similarity to the > previous

[Mesa-dev] [PATCH] [v2] i965: implement ARB_pipeline_statistics_query

2014-12-02 Thread Ben Widawsky
This patch implements ARB_pipeline_statistics_query. This addition to GL does not add a new API. Instead, it adds new tokens to the existing query APIs. The work to hook up the new tokens is trivial due to it's similarity to the previous work done for the query APIs. I've implemented all the new to