[Mesa-dev] [PATCH] Use #if over #ifdef in the FEATURE_ES1 check to fix a build failure.

mfeatures.h will define FEATURE_ES1 to 0 if it's not defined yet. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=53664 --- src/mesa/main/es1_conversion.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/es1_conversion.c b/src/mesa/main/es1_conversion.c

Re: [Mesa-dev] [PATCH 1/3] st/mesa: do vertex and fragment color clamping in shaders

Marek Olšák [2012-02-21 21:36]: > Hi Tilman, > > Thanks for the info. I didn't consider outputs to be readable, sorry. > A quick fix would be to move the outputs to temps. There is a GLSL pass > for that and it can be enabled by reporting > PIPE_SHADER_CAP_OUTPUT_READ --

Re: [Mesa-dev] [PATCH 1/3] st/mesa: do vertex and fragment color clamping in shaders

Tilman Sauerbeck [2012-02-12 11:31]: > Marek Olšák [2012-01-23 13:32]: > > For ARB_color_buffer_float. Most hardware can't do it and st/mesa is > > the perfect place for a fallback. > > This breaks lighting in Heroes of Newerth on my rv730: > http://files.code-monke

Re: [Mesa-dev] [PATCH 1/3] st/mesa: do vertex and fragment color clamping in shaders

Marek Olšák [2012-01-23 13:32]: > For ARB_color_buffer_float. Most hardware can't do it and st/mesa is > the perfect place for a fallback. This breaks lighting in Heroes of Newerth on my rv730: http://files.code-monkey.de/frag_color_clamp_bad.png (after patch) http://files.code-monkey.de/frag_

Re: [Mesa-dev] [PATCH] r600g: don't change the order of writes in merge_inst_group

gt; So compare destinations and don't allow this. > > Signed-off-by: Vadim Girlin > --- > > cc: Tilman Sauerbeck > > This should fix the regression with "r600g: lazy load for AR register" for > r600/r700. Confirmed :) Thanks, Tilman -- A: Because it mes

Re: [Mesa-dev] [PATCH v2] r600g: lazy load for AR register

Vadim Girlin [2011-11-16 22:28]: > On Wed, 2011-11-16 at 18:57 +0100, Tilman Sauerbeck wrote: > > Vadim Girlin [2011-11-13 22:08]: > > > Emit MOVA* instruction only when AR is used. > > > > > > Signed-off-by: Vadim Girlin > > > --- > > >

Re: [Mesa-dev] [PATCH v2] r600g: lazy load for AR register

I have an apitrace file that reproduces the issue but unfortunately that file is 3.x GB. I've made the results of a piglit run comparing 88a140c (good) 8e366dc (bad) available at http://files.code-monkey.de/piglit.tar.bz2 . Regards, Tilman -- A: Because it messes up the order in which peopl

Re: [Mesa-dev] [PATCH] linker: Reject shaders that use too many varyings

> + float_components += var->type->vector_elements; > + } > + } > + } > + > + printf("varyings = %u, %u\n", varying_vectors, float_components); Did you intend to leave this printf there? Regards, Tilman -- A: Because it messes up the order in w

Re: [Mesa-dev] libxml2 (python) dependency

ated files are no longer tracked in source control. They are > generated at compile time because anything else is just nuts. :) I know What about generating them at 'make dist' time, too...? That way the Python dependency would only hit developers, but not people building from pr

Re: [Mesa-dev] [PATCH] st/mesa: In update_samplers(), clear all samplers at once.

Keith Whitwell [2011-03-21 18:43]: > On Mon, 2011-03-21 at 19:28 +0100, Tilman Sauerbeck wrote: > > Signed-off-by: Tilman Sauerbeck > > --- > > > > update_samplers() showed up in a profile of Heroes of Newerth; > > this patch pushes it down the profile by ~3%.

[Mesa-dev] [PATCH] st/mesa: In update_samplers(), clear all samplers at once.

Signed-off-by: Tilman Sauerbeck --- update_samplers() showed up in a profile of Heroes of Newerth; this patch pushes it down the profile by ~3%. Does this seem plausible? src/mesa/state_tracker/st_atom_sampler.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src

Re: [Mesa-dev] r600g: Fixed SIN/COS/SCS for the case where the operand is a literal.

of glean's fragProg1 (as included in piglit). > Could you test this again and see if your fix is still working? Yes, the tests still pass. Regards, Tilman -- A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A:

[Mesa-dev] [PATCH] r600g: Fixed SIN/COS/SCS for the case where the operand is a literal.

Signed-off-by: Tilman Sauerbeck --- src/gallium/drivers/r600/r600_shader.c | 17 +++-- 1 files changed, 15 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers/r600/r600_shader.c index bb5038c..35a4cea 100644 --- a/src/gallium

Re: [Mesa-dev] [PATCH 1/4] gallium: add fragment shader property for color writes to all buffers.

quot;, > "FS_COORD_PIXEL_CENTER" > + "FS_COLOR0_WRITE_ALL_CBUFS" > }; It looks like you forgot to add a comma to the second to last entry. Regards, Tilman -- A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-pos

Re: [Mesa-dev] [PATCH] r600g: Only compare active vertex elements

sual profile runs. > > Please review/apply. Looks good. I wanted to do this change some time ago, but couldn't get proof that it actually helped performance-wise. Anyway, according to perf it helps with OA. I'll apply the patch unless Dave or Jerome have objections. Regards, Tilman

Re: [Mesa-dev] [PATCH] r600g: Fix access to constants > 31.

Jerome Glisse [2010-11-21 11:07]: > On Sun, Nov 21, 2010 at 10:30 AM, Tilman Sauerbeck > wrote: > > Signed-off-by: Tilman Sauerbeck > > --- > > > > This is pretty ugly, but hopefully it will make a proper fix easier > > to implement :) > > > >

[Mesa-dev] [PATCH] r600g: Fix access to constants > 31.

Signed-off-by: Tilman Sauerbeck --- This is pretty ugly, but hopefully it will make a proper fix easier to implement :) src/gallium/drivers/r600/r600_asm.c| 30 +- src/gallium/drivers/r600/r600_asm.h|1 + src/gallium/drivers/r600/r600_shader.c |7

Re: [Mesa-dev] Path to optimize (moving from create/bind/delete paradgim to set only ?)

reate_sampler_state is called 10 times, ie we only create 10 sampler states * context.bind_fragment_sampler_states is called ~64000 times. Caching of pipe_sampler_states seems to work here. Regards, Tilman -- A: Because it messes up the order in which people normally read text. Q: Why is top

[Mesa-dev] [PATCH] r600g: Lower the minimum stride from 512 to 256 bytes to fix bug #31578.

piglit/fbo-readpixels still passes for me. Signed-off-by: Tilman Sauerbeck --- Please review. And someone please tell me where those 512 and 256 bytes are coming from :) src/gallium/drivers/r600/r600_texture.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src

[Mesa-dev] [PATCH] r600g: Added a missing call to r600_bc_add_literal().

Signed-off-by: Tilman Sauerbeck --- This patch fixes a "literal not added correctly" error for Heroes of Newerth in the main menu. I don't fully understand the code; please review. src/gallium/drivers/r600/r600_shader.c |5 + 1 files changed, 5 insertions(+), 0 del

[Mesa-dev] [PATCH] st/mesa: Reset the constant buffers before destroying the pipe context.

Signed-off-by: Tilman Sauerbeck --- v2: Also call into the pipe driver to make it release its reference. src/mesa/state_tracker/st_context.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/src/mesa/state_tracker/st_context.c b/src/mesa/state_tracker/st_context.c

Re: [Mesa-dev] [PATCH 6/6] st/mesa: Reset the constant buffers before destroying the pipe context.

Tilman Sauerbeck [2010-10-31 17:38]: > Signed-off-by: Tilman Sauerbeck > --- > src/mesa/state_tracker/st_context.c |4 > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/src/mesa/state_tracker/st_context.c > b/src/mesa/state_tracker/st_cont

[Mesa-dev] [PATCH 6/6] st/mesa: Reset the constant buffers before destroying the pipe context.

Signed-off-by: Tilman Sauerbeck --- src/mesa/state_tracker/st_context.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/src/mesa/state_tracker/st_context.c b/src/mesa/state_tracker/st_context.c index b5ea6d0..c0bfbea 100644 --- a/src/mesa/state_tracker/st_context.c

[Mesa-dev] [PATCH 5/6] st/mesa: Reset the index buffer before destroying the pipe context.

Signed-off-by: Tilman Sauerbeck --- src/mesa/state_tracker/st_context.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/mesa/state_tracker/st_context.c b/src/mesa/state_tracker/st_context.c index 75fd695..b5ea6d0 100644 --- a/src/mesa/state_tracker/st_context.c

[Mesa-dev] [PATCH 4/6] r600g: Destroy the winsys in r600_destroy_screen().

Signed-off-by: Tilman Sauerbeck --- src/gallium/drivers/r600/r600_pipe.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/gallium/drivers/r600/r600_pipe.c b/src/gallium/drivers/r600/r600_pipe.c index 952c7f6..55370f0 100644 --- a/src/gallium/drivers/r600

[Mesa-dev] [PATCH 3/6] r600g: Fixed two memory leaks in winsys.

Signed-off-by: Tilman Sauerbeck --- src/gallium/winsys/r600/drm/r600_hw_context.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/gallium/winsys/r600/drm/r600_hw_context.c b/src/gallium/winsys/r600/drm/r600_hw_context.c index 2521ff9..82d5dea 100644 --- a/src

[Mesa-dev] [PATCH 1/6] r600g: We don't support PIPE_CAP_PRIMITIVE_RESTART.

Signed-off-by: Tilman Sauerbeck --- src/gallium/drivers/r600/r600_pipe.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/gallium/drivers/r600/r600_pipe.c b/src/gallium/drivers/r600/r600_pipe.c index 3564539..d25de55 100644 --- a/src/gallium/drivers/r600/r600_pipe.c

[Mesa-dev] [PATCH 2/6] r600g: Delete custom_dsa_flush on shutdown.

Signed-off-by: Tilman Sauerbeck --- src/gallium/drivers/r600/r600_pipe.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/gallium/drivers/r600/r600_pipe.c b/src/gallium/drivers/r600/r600_pipe.c index d25de55..952c7f6 100644 --- a/src/gallium/drivers/r600/r600_pipe.c

[Mesa-dev] [PATCH 3/3] r600g: Made radeon_bo::map_count signed.

That way assert(map_count >= 0) can actually fail when we screwed up. Signed-off-by: Tilman Sauerbeck --- src/gallium/winsys/r600/drm/r600_priv.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/gallium/winsys/r600/drm/r600_priv.h b/src/gallium/winsys/r600/

[Mesa-dev] [PATCH 2/3] r600g: Fixed unmap condition in radeon_bo_pb_destroy().

Signed-off-by: Tilman Sauerbeck --- src/gallium/winsys/r600/drm/radeon_bo_pb.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/gallium/winsys/r600/drm/radeon_bo_pb.c b/src/gallium/winsys/r600/drm/radeon_bo_pb.c index f74b934..312552f 100644 --- a/src

[Mesa-dev] [PATCH 1/3] r600g: Made radeon_bo_pb_map_internal() actually call radeon_bo_map().

This ensures that we increase bo->map_count when radeon_bo_map_internal() returns successfully, which in turn makes sure we don't decrement bo->map_count below zero later. Signed-off-by: Tilman Sauerbeck --- src/gallium/winsys/r600/drm/radeon_bo_pb.c | 20 +++- 1 fi

[Mesa-dev] [PATCH] r600g: Removed unused 'ptr' argument from radeon_bo().

Signed-off-by: Tilman Sauerbeck --- src/gallium/winsys/r600/drm/r600_priv.h|2 +- src/gallium/winsys/r600/drm/radeon_bo.c|5 + src/gallium/winsys/r600/drm/radeon_bo_pb.c |5 ++--- 3 files changed, 4 insertions(+), 8 deletions(-) diff --git a/src/gallium/winsys/r600/drm

[Mesa-dev] [PATCH] r600g: Destroy the blitter.

This fix got lost in the state rework merge. Signed-off-by: Tilman Sauerbeck --- src/gallium/drivers/r600/r600_pipe.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/gallium/drivers/r600/r600_pipe.c b/src/gallium/drivers/r600/r600_pipe.c index bea7ef5..3564539

[Mesa-dev] [PATCH] r600g: In radeon_bo(), call LIST_INITHEAD early.

radeon_bo_destroy() will want to read the list field. Without this patch, we'd end up evaluating the list pointers before they have been properly set up when we destroyed the newly created bo if it cannot be mapped. Signed-off-by: Tilman Sauerbeck --- src/gallium/winsys/r600/drm/radeon

[Mesa-dev] [PATCH 3/3] r600g: Also clear bc data when we're destroying a shader.

Signed-off-by: Tilman Sauerbeck --- src/gallium/drivers/r600/r600_asm.c| 36 src/gallium/drivers/r600/r600_asm.h|1 + src/gallium/drivers/r600/r600_shader.c |2 + 3 files changed, 39 insertions(+), 0 deletions(-) diff --git a/src/gallium

[Mesa-dev] [PATCH 2/3] r600g: Added r600_pipe_shader_destroy().

Not yet complete. Signed-off-by: Tilman Sauerbeck --- src/gallium/drivers/r600/r600_pipe.h |1 + src/gallium/drivers/r600/r600_shader.c | 11 +++ src/gallium/drivers/r600/r600_state.c |6 -- 3 files changed, 16 insertions(+), 2 deletions(-) diff --git a/src/gallium

[Mesa-dev] [PATCH 1/3] r600g: Fixed r600_vertex_element leak.

Signed-off-by: Tilman Sauerbeck --- src/gallium/drivers/r600/evergreen_state.c | 13 + src/gallium/drivers/r600/r600_pipe.h |1 - src/gallium/drivers/r600/r600_state.c| 13 + src/gallium/drivers/r600/r600_state_common.c |1 - 4 files changed

[Mesa-dev] [PATCH] r600g: Tweaked calculation of CB_SHADER_MASK and CB_TARGET_MASK.

Signed-off-by: Tilman Sauerbeck --- Any reason why we shouldn't do it like this? src/gallium/drivers/r600/evergreen_state.c | 15 --- src/gallium/drivers/r600/r600_state.c | 18 +- 2 files changed, 9 insertions(+), 24 deletions(-) diff --git a/src/ga

[Mesa-dev] [PATCH] r600g: Cleaned up index buffer reference handling in the draw module.

This fixes a buffer leak. Signed-off-by: Tilman Sauerbeck --- This patch fixes the same problem in the new design, too. src/gallium/drivers/r600/r600_buffer.c |5 - src/gallium/drivers/r600/r600_draw.c |4 +++- src/gallium/drivers/r600/r600_state2.c |9 +++-- 3 files

Re: [Mesa-dev] [PATCH] r600g: Cleaned up index buffer reference handling in the draw module.

Nicolas Kaiser [2010-09-28 13:07]: > * Tilman Sauerbeck : > > This fixes a buffer leak. > > Is this one supposed to go in like the other one? Probably not. I think Jerome and Dave believe that there's a better way to fix the problem. Regards, Tilman -- A: Because it me

[Mesa-dev] [PATCH] r600g: Fixed two texture surface leaks in r600_blit_uncompress_depth().

Signed-off-by: Tilman Sauerbeck --- src/gallium/drivers/r600/r600_blit.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/gallium/drivers/r600/r600_blit.c b/src/gallium/drivers/r600/r600_blit.c index c30a7c1..7f411ae 100644 --- a/src/gallium/drivers/r600

[Mesa-dev] [PATCH] r600g: Cleaned up index buffer reference handling in the draw module.

This fixes a buffer leak. Signed-off-by: Tilman Sauerbeck --- src/gallium/drivers/r600/r600_buffer.c |5 - src/gallium/drivers/r600/r600_draw.c |4 +++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/r600/r600_buffer.c b/src/gallium/drivers

[Mesa-dev] TGSI RET only at end of function?

e end of a function? ... or maybe I'm misinterpreting the spec? Thanks, Tilman -- A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing on usenet and in e-mail? p

Re: [Mesa-dev] [PATCH] gallium/docs: Fixed a typo in the SCS opcode description.

keith whitwell [2010-09-19 18:37]: > Looks good, thanks Tilman. Thanks, I've pushed the patch. > On Sun, Sep 19, 2010 at 8:24 AM, Tilman Sauerbeck > wrote: > > Signed-off-by: Tilman Sauerbeck > > --- > >  src/gallium/docs/source/tgsi.rst |    2 +- > >

[Mesa-dev] [PATCH] python/tests: Fixed tri.py for API and TGSI syntax changes.

Signed-off-by: Tilman Sauerbeck --- The same fix needs to be applied to a bunch of other Python scripts, but tri.py seems to be a good starting point. src/gallium/tests/python/samples/tri.py |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/tests

[Mesa-dev] [PATCH] r600g: Honour destination operand's writemask in the SCS implementation.

Signed-off-by: Tilman Sauerbeck --- src/gallium/drivers/r600/r600_shader.c | 49 +-- 1 files changed, 27 insertions(+), 22 deletions(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers/r600/r600_shader.c index 4da6850..7e51db6 100644 --- a

[Mesa-dev] [PATCH] gallium/docs: Fixed a typo in the SCS opcode description.

Signed-off-by: Tilman Sauerbeck --- src/gallium/docs/source/tgsi.rst |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/gallium/docs/source/tgsi.rst b/src/gallium/docs/source/tgsi.rst index e588c5b..4c1f47a 100644 --- a/src/gallium/docs/source/tgsi.rst +++ b/src

[Mesa-dev] [PATCH] r600g: Added support for TGSI_SEMANTIC_FACE.

This makes the 'glsl1-gl_FrontFacing var (1)' piglit test pass. Signed-off-by: Tilman Sauerbeck --- Someone please test this on Evergreen. I only have r600 hardware. src/gallium/drivers/r600/eg_hw_states.c | 11 ++- src/gallium/drivers/r600/r600_hw_states.c | 11

Re: [Mesa-dev] [PATCH] glsl2: Fixed cloning of ir_call error instructions.

Ian Romanick [2010-09-18 11:18]: > Tilman Sauerbeck wrote: > > Those have the callee field set to the null pointer, so > > calling the public constructor will segfault. > > Do you have a test that triggers this? It would be good to have it in > piglt. I found the bug wh

[Mesa-dev] [PATCH] glsl2: Fixed cloning of ir_call error instructions.

Those have the callee field set to the null pointer, so calling the public constructor will segfault. Signed-off-by: Tilman Sauerbeck --- src/glsl/ir_clone.cpp |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/glsl/ir_clone.cpp b/src/glsl/ir_clone.cpp index aa84cf0

Re: [Mesa-dev] [PATCH] glsl2: Empty functions can be inlined.

Tilman Sauerbeck [2010-09-17 17:39]: > Signed-off-by: Tilman Sauerbeck > --- > src/glsl/ir_function_can_inline.cpp |3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) Ignore this one. See v2 instead please. Regards, Tilman -- A: Because it messes up the order in

[Mesa-dev] [PATCH v2] glsl2: Empty functions can be inlined.

Signed-off-by: Tilman Sauerbeck --- This is nicer. src/glsl/ir_function_can_inline.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/glsl/ir_function_can_inline.cpp b/src/glsl/ir_function_can_inline.cpp index 8bb8e0d..52af9f7 100644 --- a/src/glsl

[Mesa-dev] [PATCH] glsl2: Empty functions can be inlined.

Signed-off-by: Tilman Sauerbeck --- src/glsl/ir_function_can_inline.cpp |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/src/glsl/ir_function_can_inline.cpp b/src/glsl/ir_function_can_inline.cpp index 8bb8e0d..4d3eb98 100644 --- a/src/glsl/ir_function_can_inline.cpp

[Mesa-dev] [PATCH] r600g: Enable PIPE_SHADER_CAP_TGSI_CONT_SUPPORTED.

Signed-off-by: Tilman Sauerbeck --- src/gallium/drivers/r600/r600_screen.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/r600/r600_screen.c b/src/gallium/drivers/r600/r600_screen.c index d38c3d3..9860221 100644 --- a/src/gallium/drivers/r600

[Mesa-dev] [PATCH 2/2] r600g: Only set PA_SC_EDGERULE on rv770 and greater.

This is what xf86-video-ati and r600c do. Signed-off-by: Tilman Sauerbeck --- src/gallium/drivers/r600/r600_hw_states.c | 16 ++-- 1 files changed, 14 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/r600/r600_hw_states.c b/src/gallium/drivers/r600/r600_hw_states.c

[Mesa-dev] [PATCH 1/2] r600g: Added DB_SHADER_CONTROL defines.

Signed-off-by: Tilman Sauerbeck --- The changes to evergreend.h are just a guess. Please review. src/gallium/drivers/r600/eg_hw_states.c |9 ++--- src/gallium/drivers/r600/evergreend.h | 17 + src/gallium/drivers/r600/r600_hw_states.c |9 ++--- src

[Mesa-dev] [PATCH 2/2] r600g: Make number of tex indirections shader type specific again.

Commit a508d2dddcc67d0f92cc36b9ed6f36a9bbfc579d removed the type specific limit. Signed-off-by: Tilman Sauerbeck --- I have no idea whether this is actually correct or not. Please review ;) src/gallium/drivers/r600/r600_screen.c |6 +- 1 files changed, 5 insertions(+), 1 deletions

[Mesa-dev] [PATCH 1/2] r600g: Formatting fixes.

Signed-off-by: Tilman Sauerbeck --- src/gallium/drivers/r600/r600_screen.c | 53 +++ 1 files changed, 26 insertions(+), 27 deletions(-) diff --git a/src/gallium/drivers/r600/r600_screen.c b/src/gallium/drivers/r600/r600_screen.c index 19d1005..60e6d9a 100644 --- a

[Mesa-dev] [PATCH] r600g: Undo bo placement change.

This reverts a part of e795ca8f3175fa6fd97b6b2ef2775e3f8803012a that causes artefacts and a performance drop. Signed-off-by: Tilman Sauerbeck --- src/gallium/drivers/r600/r600_hw_states.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/gallium/drivers/r600

Re: [Mesa-dev] [PATCH 1/3] r600g: Fixed a bo leak in r600_blit_state_ps_shader().

Tilman Sauerbeck [2010-09-10 18:32]: > Subject: Re: [PATCH 1/3] r600g: Fixed a bo leak in > r600_blit_state_ps_shader(). Sigh, I fail at git format-patch. This isn't a sequence, it's just this one patch. So don't wait for 2/3 and 3/3. Sorry, Tilman -- A: Because it m

[Mesa-dev] [PATCH] r600g: Use clamped math for RCP and RSQ.

This is likely only correct for OpenGL and not other state trackers. Signed-off-by: Tilman Sauerbeck --- src/gallium/drivers/r600/r600_shader.c | 16 ++-- 1 files changed, 14 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers

[Mesa-dev] [PATCH 1/3] r600g: Fixed a bo leak in r600_blit_state_ps_shader().

We would leak the newly created bo if it cannot be mapped. Signed-off-by: Tilman Sauerbeck --- src/gallium/drivers/r600/r600_blit.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/gallium/drivers/r600/r600_blit.c b/src/gallium/drivers/r600/r600_blit.c index

[Mesa-dev] [PATCH] r600g: Fixed a bo reference leak in the draw module.

Signed-off-by: Tilman Sauerbeck --- src/gallium/drivers/r600/r600_draw.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/src/gallium/drivers/r600/r600_draw.c b/src/gallium/drivers/r600/r600_draw.c index 1834433..f24f30f 100644 --- a/src/gallium/drivers/r600

[Mesa-dev] [PATCH] r600g: Only increase a bo's map_count if radeon_bo_map() succeeded.

Signed-off-by: Tilman Sauerbeck --- src/gallium/winsys/r600/drm/radeon_bo.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/gallium/winsys/r600/drm/radeon_bo.c b/src/gallium/winsys/r600/drm/radeon_bo.c index a1306f6..f79135b 100644 --- a/src/gallium/winsys

[Mesa-dev] [PATCH] r600g: Fixed a bo leak in the error path of radeon_ctx_set_bo_new().

Signed-off-by: Tilman Sauerbeck --- src/gallium/winsys/r600/drm/radeon_ctx.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/src/gallium/winsys/r600/drm/radeon_ctx.c b/src/gallium/winsys/r600/drm/radeon_ctx.c index 5d9cdca..f89ab30 100644 --- a/src/gallium/winsys/r600

[Mesa-dev] [PATCH] r600g: Fixed a bo leak in r600_texture_from_handle().

We would leak bo if the argument check failed. Signed-off-by: Tilman Sauerbeck --- src/gallium/drivers/r600/r600_texture.c | 11 ++- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/r600/r600_texture.c b/src/gallium/drivers/r600/r600_texture.c index

[Mesa-dev] [PATCH] r600g: Don't leave stale references in query_list when we cannot create bo.

Signed-off-by: Tilman Sauerbeck --- src/gallium/drivers/r600/r600_query.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/src/gallium/drivers/r600/r600_query.c b/src/gallium/drivers/r600/r600_query.c index 530940e..0073072 100644 --- a/src/gallium/drivers/r600

[Mesa-dev] [PATCH] r600g: Implemented the y component write for the LOG opcode.

From: Tilman Sauerbeck This makes the 'vp1-LOG test' piglit test work. Signed-off-by: Tilman Sauerbeck --- src/gallium/drivers/r600/r600_shader.c | 95 ++-- 1 files changed, 90 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/r600/r600_s

[Mesa-dev] [PATCH] r600g: Added missing abs-ification to RSQ.

This makes the 'fp1-RSQ test 2' piglit test work. --- src/gallium/drivers/r600/r600_shader.c | 31 ++- 1 files changed, 30 insertions(+), 1 deletions(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers/r600/r600_shader.c index 7cf255b..94ddb

Re: [Mesa-dev] [PATCH 1/3] Replace reference to tgsi-instruction-set.txt.

Tilman Sauerbeck [2010-09-07 11:59]: > That file has been replaced by tgsi.rst. Sorry about the duplicate mails. I sent the first three patches to mesa...@fdo, and when I didn't receive mail from mailman I assumed it was because I should have used @lists.fdo. Regards, Tilman -- A: Be

[Mesa-dev] [PATCH 3/3] r600g: Added missing r600_bc_add_literal() calls to XPD implementation.

--- src/gallium/drivers/r600/r600_shader.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers/r600/r600_shader.c index f211ec2..7cf255b 100644 --- a/src/gallium/drivers/r600/r600_shader.c +++ b/src/gallium/d

[Mesa-dev] [PATCH 2/3] r600g: Added preliminary support for the LOG opcode.

--- src/gallium/drivers/r600/r600_shader.c | 122 +++- 1 files changed, 121 insertions(+), 1 deletions(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers/r600/r600_shader.c index 0ba26a2..f211ec2 100644 --- a/src/gallium/drivers/r600/r600_sh

[Mesa-dev] [PATCH 1/3] Replace reference to tgsi-instruction-set.txt.

That file has been replaced by tgsi.rst. --- src/gallium/include/pipe/p_shader_tokens.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/gallium/include/pipe/p_shader_tokens.h b/src/gallium/include/pipe/p_shader_tokens.h index c4bd17e..74488de 100644 --- a/src/gallium

[Mesa-dev] [PATCH 3/3] r600g: Added missing r600_bc_add_literal() calls to XPD implementation.

--- src/gallium/drivers/r600/r600_shader.c |8 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers/r600/r600_shader.c index f211ec2..7cf255b 100644 --- a/src/gallium/drivers/r600/r600_shader.c +++ b/src/gallium/d

[Mesa-dev] [PATCH 2/3] r600g: Added preliminary support for the LOG opcode.

--- src/gallium/drivers/r600/r600_shader.c | 122 +++- 1 files changed, 121 insertions(+), 1 deletions(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers/r600/r600_shader.c index 0ba26a2..f211ec2 100644 --- a/src/gallium/drivers/r600/r600_sh

[Mesa-dev] [PATCH] Replace reference to tgsi-instruction-set.txt.

That file has been replaced by tgsi.rst. --- src/gallium/include/pipe/p_shader_tokens.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/gallium/include/pipe/p_shader_tokens.h b/src/gallium/include/pipe/p_shader_tokens.h index c4bd17e..74488de 100644 --- a/src/gallium