Re: [Mesa-dev] [Intel-gfx] gitlab.fd.o financial situation and impact on services

ot > eyeball your build definitions anymore. > Did you mean Bazel [0] ? I'm not sure I follow your reflection, why is Meson vs Bazel related to this issue ? Nicolas [0] https://bazel.build/ > ym2c > > > On Fri, 28 Feb 2020 at 20:34, Eric Anholt wrote: > > On Fri

Re: [Mesa-dev] [Intel-gfx] gitlab.fd.o financial situation and impact on services

Le samedi 04 avril 2020 à 08:11 -0700, Rob Clark a écrit : > On Fri, Apr 3, 2020 at 7:12 AM Michel Dänzer wrote: > > On 2020-03-01 6:46 a.m., Marek Olšák wrote: > > > For Mesa, we could run CI only when Marge pushes, so that it's a strictly > > > pre-merge CI. > > > > Thanks for the suggestion! I

Re: [Mesa-dev] Plumbing explicit synchronization through the Linux ecosystem

the buffer. (Currently, it has to poll for writable, > because waiting for the exclusive fence only isn't enough with amdgpu) That is very interesting, thanks for sharing, could allow fixing some issues in userspace for backward compatibility. thanks, Nicolas __

Re: [Mesa-dev] Plumbing explicit synchronization through the Linux ecosystem

Le mardi 17 mars 2020 à 11:27 -0500, Jason Ekstrand a écrit : > On Tue, Mar 17, 2020 at 10:33 AM Nicolas Dufresne > wrote: > > Le lundi 16 mars 2020 à 23:15 +0200, Laurent Pinchart a écrit : > > > Hi Jason, > > > > > > On Mon, Mar 16, 2020 at 10:06:07AM

Re: [Mesa-dev] Plumbing explicit synchronization through the Linux ecosystem

Le lundi 16 mars 2020 à 23:15 +0200, Laurent Pinchart a écrit : > Hi Jason, > > On Mon, Mar 16, 2020 at 10:06:07AM -0500, Jason Ekstrand wrote: > > On Mon, Mar 16, 2020 at 5:20 AM Laurent Pinchart wrote: > > > On Wed, Mar 11, 2020 at 04:18:55PM -0400, Nicolas Dufresne wr

Re: [Mesa-dev] Plumbing explicit synchronization through the Linux ecosystem

(I know I'm going to be spammed by so many mailing list ...) Le mercredi 11 mars 2020 à 14:21 -0500, Jason Ekstrand a écrit : > On Wed, Mar 11, 2020 at 12:31 PM Jason Ekstrand wrote: > > All, > > > > Sorry for casting such a broad net with this one. I'm sure most people > > who reply will get at

Re: [Mesa-dev] [Intel-gfx] gitlab.fd.o financial situation and impact on services

CI results. We could also have option to trigger the ci (the opposite of ci.skip) from git command line. > - Disabling CI on WIP MRs That I'm also mitigated about. > - I'm sure there are more... regards, Nicolas ___ mesa-dev mail

Re: [Mesa-dev] [Intel-gfx] gitlab.fd.o financial situation and impact on services

Le dimanche 01 mars 2020 à 15:14 +0100, Michel Dänzer a écrit : > On 2020-02-29 8:46 p.m., Nicolas Dufresne wrote: > > Le samedi 29 février 2020 à 19:14 +0100, Timur Kristóf a écrit : > > > 1. I think we should completely disable running the CI on MRs which are > > >

Re: [Mesa-dev] [Intel-gfx] gitlab.fd.o financial situation and impact on services

Le samedi 29 février 2020 à 15:54 -0600, Jason Ekstrand a écrit : > On Sat, Feb 29, 2020 at 3:47 PM Timur Kristóf wrote: > > On Sat, 2020-02-29 at 14:46 -0500, Nicolas Dufresne wrote: > > > > 1. I think we should completely disable running the CI on MRs which > >

Re: [Mesa-dev] [Intel-gfx] gitlab.fd.o financial situation and impact on services

Le samedi 29 février 2020 à 19:14 +0100, Timur Kristóf a écrit : > On Fri, 2020-02-28 at 10:43 +, Daniel Stone wrote: > > On Fri, 28 Feb 2020 at 10:06, Erik Faye-Lund > > wrote: > > > On Fri, 2020-02-28 at 11:40 +0200, Lionel Landwerlin wrote: > > > > Yeah, changes on vulkan drivers or backend

[Mesa-dev] [PATCH,v3] configure.ac/meson.build: Fix -latomic test

nt64_t *, and results in the following link time error without -latomic: src/util/disk_cache.c:628: error: undefined reference to '__atomic_fetch_add_8' Fix the configure/meson test to replicate this pattern, which then correctly realizes the need for -latomic. Signed-off-by: Nicolas Boich

Re: [Mesa-dev] [PATCH, v2] CHROMIUM: configure.ac/meson.build: Fix -latomic test

On Fri, Mar 30, 2018 at 2:26 AM, Matt Turner wrote: > On Thu, Mar 29, 2018 at 1:31 AM, Nicolas Boichat > wrote: >> From: Nicolas Boichat >> >> When compiling with LLVM 6.0, the test fails to detect that >> -latomic is actually required, as the atomic call is inl

Re: [Mesa-dev] [PATCH, v2] CHROMIUM: configure.ac/meson.build: Fix -latomic test

And now I left the CHROMIUM tag, sorry ,-( On Thu, Mar 29, 2018 at 4:31 PM, Nicolas Boichat wrote: > From: Nicolas Boichat > > When compiling with LLVM 6.0, the test fails to detect that > -latomic is actually required, as the atomic call is inlined. > > In the cod

[Mesa-dev] [PATCH, v2] CHROMIUM: configure.ac/meson.build: Fix -latomic test

From: Nicolas Boichat When compiling with LLVM 6.0, the test fails to detect that -latomic is actually required, as the atomic call is inlined. In the code itself (src/util/disk_cache.c), we see this pattern: p_atomic_add(cache->size, - (uint64_t)size); where cache->size is an uint64_t

Re: [Mesa-dev] [PATCH] configure.ac: Fix -latomic test

Scrap this, I guess I should update meson.build, too. Will send v2 in a few minutes. On Thu, Mar 29, 2018 at 4:26 PM, Nicolas Boichat wrote: > From: Nicolas Boichat > > When compiling with LLVM 6.0, the test fails to detect that > -latomic is actually required, as the atomic cal

[Mesa-dev] [PATCH] configure.ac: Fix -latomic test

From: Nicolas Boichat When compiling with LLVM 6.0, the test fails to detect that -latomic is actually required, as the atomic call is inlined. In the code itself (src/util/disk_cache.c), we see this pattern: p_atomic_add(cache->size, - (uint64_t)size); where cache->size is an uint64_t

Re: [Mesa-dev] [PATCH] util/rand_xor: add missing include statements

On Thu, Jun 1, 2017 at 4:53 PM, Emil Velikov wrote: > Should be handled now. See the documentation for future stable nominations > [1]. Actually, I don't see the patch in 17.1.2, was it expected? ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH 3/4] configure.ac: remove unused Android specifics

ne gone we >> no longer need the host detection. >> >> Cc: Chad Versace >> Cc: Nicolas Boichat >> Signed-off-by: Emil Velikov >> --- >> configure.ac | 6 -- >> 1 file changed, 6 deletions(-) > > Since it's not used, then kill it.

Re: [Mesa-dev] [PATCH] util/rand_xor: add missing include statements

On Thu, Jun 1, 2017 at 3:27 PM, Eric Engestrom wrote: > On Thursday, 2017-06-01 12:13:18 +0200, Nicolas Dechesne wrote: >> Fixes for: >> >> src/util/rand_xor.c:60:13: error: implicit declaration of function 'open' >> [-Werror=implicit-function-declaratio

[Mesa-dev] [PATCH] util/rand_xor: add missing include statements

s function) int fd = open("/dev/urandom", O_RDONLY); ^~~~ Signed-off-by: Nicolas Dechesne --- src/util/rand_xor.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/util/rand_xor.c b/src/util/rand_xor.c index de05fa64b3..de04bbc284 100644

Re: [Mesa-dev] [PATCH] configure.ac: Also match -androideabi tuple

On Mon, May 8, 2017 at 9:19 PM, Emil Velikov wrote: > On 5 May 2017 at 23:40, Chad Versace wrote: >> On Fri 05 May 2017, Nicolas Boichat wrote: >>> From: Nicolas Boichat >>> >>> On ARM Android platforms, the host_os tuple should be linux-androideabi,

[Mesa-dev] [PATCH] egl/android: Set EGLSurface.Lost to EGL_TRUE/EGL_FALSE

Lost is an EGLBoolean, so we should assign it to EGL_TRUE/EGL_FALSE, not true/false. Fixes: e5eace58684 ("egl/android: Mark surface as lost when dequeueBuffer fails") Fixes: 0212db35040 ("egl/android: Cancel any outstanding ANativeBuffer in surface destructor") --- src/egl/drivers/dri2/platform

Re: [Mesa-dev] [PATCH 2/3] egl/android: Cancel any outstanding ANativeBuffer in surface destructor

rom SurfaceFlinger > (ANativeWindow::dequeueBuffer) but before EGL has released it > (ANativeWindow::enqueueBuffer). > > This patch is part of a series for fixing > android.hardware.camera2.cts.RobustnessTest#testAbandonRepeatingRequestSurface > on Chrome OS x86 devices. > > Cc: Tomasz

[Mesa-dev] [PATCH] configure.ac: Also match -androideabi tuple

From: Nicolas Boichat On ARM Android platforms, the host_os tuple should be linux-androideabi, so let's match both -android and -androideabi (or any other -android* tuple) to determine if we should do an Android build. --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Mesa-dev] [PATCH 02/19] freedreno: automake: correctly set MKDIR_GEN

On Mon, Jan 16, 2017 at 4:45 PM, Emil Velikov wrote: > From: Emil Velikov > > Analogous to previous commit. > > Fixes: 4610e5ef28e "freedreno/ir3: fix sin/cos" > Cc: "12.0 13.0" > Cc: Rob Clark > Cc: Nicolas Dechesne > Reported-by: Nicolas Deche

[Mesa-dev] [PATCH] radv: Return correct result in EnumeratePhysicalDevices

If pPhysicalDevices is too small for all physical devices, the driver must return VK_INCOMPLETE. Since only a single physical device is supported, this is only the case when pPhysicalDeviceCount == 0 && pPhysicalDevices != NULL. --- src/amd/vulkan/radv_device.c | 2 ++ 1 file changed, 2 insertions

Re: [Mesa-dev] [PATCH] anv: Return correct result in EnumeratePhysicalDevices

On Wed, Oct 12, 2016 at 10:32 AM, Emil Velikov wrote: > Hi Nicolas, > > On 6 October 2016 at 20:21, Nicolas Koch wrote: >> If pPhysicalDevices is too small for all physical devices, >> the driver must return VK_INCOMPLETE. >> Since only a single physical device is

Re: [Mesa-dev] [PATCH] anv: Return correct result in EnumeratePhysicalDevices

It's been a few days. Is anybody willing to push this? On Thu, Oct 6, 2016 at 11:25 PM, Anuj Phogat wrote: > On Thu, Oct 6, 2016 at 12:21 PM, Nicolas Koch wrote: >> If pPhysicalDevices is too small for all physical devices, >> the driver must return VK_INCOMPLETE. &g

[Mesa-dev] [PATCH] anv: Return correct result in EnumeratePhysicalDevices

If pPhysicalDevices is too small for all physical devices, the driver must return VK_INCOMPLETE. Since only a single physical device is supported, this is only the case when pPhysicalDeviceCount == 0 && pPhysicalDevices != NULL. --- src/intel/vulkan/anv_device.c | 2 ++ 1 file changed, 2 insertion

[Mesa-dev] [PATCH] anv: device: never allocate more memory than heap_size

Previously, the heap size of a physical device was kind of useless because it was not enforced. Now, we keep track of allocation sizes so that the sum of all allocations can never exceed the heap size advertised by anv_GetPhysicalDeviceMemoryProperties. --- src/intel/vulkan/anv_device.c | 42

[Mesa-dev] [PATCH] anv: Check for VK_WHOLE_SIZE in anv_CmdFillBuffer

Vulkan spec: Size is the number of bytes to fill, and must be either a multiple of 4, or VK_WHOLE_SIZE to fill the range from offset to the end of the buffer. If VK_WHOLE_SIZE is used and the remaining size of the buffer is not a multiple of 4, then the nearest smaller multiple is used. --- src/in

Re: [Mesa-dev] [PATCH] egl/dri2: dri2_initialize: Do not reference-count TestOnly display

On Tue, Aug 23, 2016 at 9:26 PM, Emil Velikov wrote: > On 22 August 2016 at 07:10, Nicolas Boichat wrote: >> Hi Emil, >> >> On Tue, Aug 16, 2016 at 1:17 AM, Emil Velikov >> wrote: >>> Hi Nicolas, >>> >>> On 4 August 2016 at 02:51, Nicol

Re: [Mesa-dev] [PATCH] egl/dri2: dri2_initialize: Do not reference-count TestOnly display

Hi Emil, On Tue, Aug 16, 2016 at 1:17 AM, Emil Velikov wrote: > Hi Nicolas, > > On 4 August 2016 at 02:51, Nicolas Boichat wrote: >> On Thu, Aug 4, 2016 at 9:38 AM, Michel Dänzer wrote: >>> On 04.08.2016 09:53, Nicolas Boichat wrote: >>>> On Thu, A

[Mesa-dev] [PATCH v2] egl/dri2: dri2_make_current: Release previous context's display

non-NULL. v2: Save the old display before destroying the context. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97214 Fixes: 9ee683f877 (egl/dri2: Add reference count for dri2_egl_display) Cc: "12.0" Reported-by: Alexandr Zelinsky Tested-by: Alexandr Zelinsky Signed-off-b

Re: [Mesa-dev] [PATCH] egl/dri2: dri2_make_current: Release previous context's display

On Thu, Aug 11, 2016 at 12:10 AM, Nicolas Boichat wrote: > On Wed, Aug 10, 2016 at 9:44 AM, Michel Dänzer wrote: >> On 10/08/16 03:00 PM, Nicolas Boichat wrote: >>> eglMakeCurrent can also be used to change the active display. In that >>> case, we need to decremen

Re: [Mesa-dev] [PATCH] egl/dri2: dri2_make_current: Release previous context's display

On Wed, Aug 10, 2016 at 9:44 AM, Michel Dänzer wrote: > On 10/08/16 03:00 PM, Nicolas Boichat wrote: >> eglMakeCurrent can also be used to change the active display. In that >> case, we need to decrement ref_count of the previous display (possibly >> destroying it), and inc

[Mesa-dev] [PATCH] egl/dri2: dri2_make_current: Release previous context's display

non-NULL. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=97214 Fixes: 9ee683f877 (egl/dri2: Add reference count for dri2_egl_display) Cc: "12.0" Reported-by: Alexandr Zelinsky Tested-by: Alexandr Zelinsky Signed-off-by: Nicolas Boichat --- src/egl/drivers/dri2/egl_dri2.c | 6

Re: [Mesa-dev] [PATCH 0/4] egl/*: Set disp->DriverData to NULL on error

On Thu, Aug 4, 2016 at 10:43 PM, Martin Peres wrote: > > > On 04/08/16 15:17, Nicolas Boichat wrote: >> >> On Thu, Aug 4, 2016 at 7:17 PM, Martin Peres >> wrote: >>> >>> >>> >>> On 04/08/16 13:08, Nicolas Boichat wrote: >>

Re: [Mesa-dev] [PATCH 0/4] egl/*: Set disp->DriverData to NULL on error

On Thu, Aug 4, 2016 at 7:17 PM, Martin Peres wrote: > > > On 04/08/16 13:08, Nicolas Boichat wrote: >> >> On Thu, Aug 4, 2016 at 5:52 PM, Martin Peres >> wrote: >>> >>> On 04/08/16 05:07, Nicolas Boichat wrote: >>>> >

Re: [Mesa-dev] [PATCH 0/4] egl/*: Set disp->DriverData to NULL on error

On Thu, Aug 4, 2016 at 5:52 PM, Martin Peres wrote: > On 04/08/16 05:07, Nicolas Boichat wrote: >> >> egl/x11 fixup has already be sent here: >> https://patchwork.freedesktop.org/patch/101934/ >> >> Compile-tested only (on android only). >> >> I was

Re: [Mesa-dev] [PATCH] egl/x11: avoid using freed memory if dri2 init fails

=4841==by 0x4F46F40: glfwInit (in /usr/lib64/libglfw.so.3.2) > ==4841==by 0x402E59: main > > Signed-off-by: Jan Ziak (http://atom-symbol.net) <0xe2.0x9a.0...@gmail.com> Fixes: 9ee683f877 (egl/dri2: Add reference count for dri2_egl_display) Cc: "12.0" Reviewe

[Mesa-dev] [PATCH 2/4] egl/surfaceless: Set disp->DriverData to NULL on error

Avoid use-after-free on error. Fixes: 9ee683f877 (egl/dri2: Add reference count for dri2_egl_display) Cc: "12.0" Signed-off-by: Nicolas Boichat --- src/egl/drivers/dri2/platform_surfaceless.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/egl/drivers/dri2/platform_surfaceles

[Mesa-dev] [PATCH 3/4] egl/drm: Set disp->DriverData to NULL on error

Avoid use-after-free on error. Fixes: 9ee683f877 (egl/dri2: Add reference count for dri2_egl_display) Cc: "12.0" Signed-off-by: Nicolas Boichat --- src/egl/drivers/dri2/platform_drm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/egl/drivers/dri2/platform_drm.c b/src/e

[Mesa-dev] [PATCH 1/4] egl/wayland: Set disp->DriverData to NULL on error

Avoid use-after-free, fix spec@egl_khr_fence_sync@conformance. Fixes: 9ee683f877 (egl/dri2: Add reference count for dri2_egl_display) Cc: "12.0" Reported-by: Michel Dänzer Signed-off-by: Nicolas Boichat --- src/egl/drivers/dri2/platform_wayland.c | 2 ++ 1 file changed, 2 insertion

[Mesa-dev] [PATCH 4/4] egl/android: Set dpy->DriverData to NULL on error

Avoid use-after-free on error. Fixes: 9ee683f877 (egl/dri2: Add reference count for dri2_egl_display) Cc: "12.0" Signed-off-by: Nicolas Boichat --- src/egl/drivers/dri2/platform_android.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/egl/drivers/dri2/platform_android.c

[Mesa-dev] [PATCH 0/4] egl/*: Set disp->DriverData to NULL on error

eas to untangle this are welcome. In the mean time, this patch series should fix crashes and a piglit test. Nicolas Boichat (4): egl/wayland: Set disp->DriverData to NULL on error egl/surfaceless: Set disp->DriverData to NULL on error egl/drm: Set disp->DriverData to NULL on error egl/a

Re: [Mesa-dev] [PATCH] egl/dri2: dri2_initialize: Do not reference-count TestOnly display

On Thu, Aug 4, 2016 at 9:38 AM, Michel Dänzer wrote: > On 04.08.2016 09:53, Nicolas Boichat wrote: >> On Thu, Aug 4, 2016 at 12:22 AM, Martin Peres >> wrote: >>> On 03/08/16 16:54, Nicolas Boichat wrote: >>>> >>>> In the case where dri2_initia

Re: [Mesa-dev] [PATCH] egl/dri2: dri2_initialize: Do not reference-count TestOnly display

On Thu, Aug 4, 2016 at 12:22 AM, Martin Peres wrote: > > > On 03/08/16 16:54, Nicolas Boichat wrote: >> >> In the case where dri2_initialize is called with a TestOnly display, >> the display is not actually initialized, so dri2_egl_display always >> fails, and we

[Mesa-dev] [PATCH] egl/dri2: dri2_initialize: Do not reference-count TestOnly display

@egl_khr_fence_sync@conformance. Fixes: 9ee683f877 (egl/dri2: Add reference count for dri2_egl_display) Cc: "12.0" Reported-by: Michel Dänzer Signed-off-by: Nicolas Boichat --- Compile-tested only, please give it a spin, thanks! src/egl/drivers/dri2/egl_d

Re: [Mesa-dev] [PATCH] egl/dri2: Add reference count for dri2_egl_display

On Thu, Jul 21, 2016 at 10:51 PM, Emil Velikov wrote: > On 21 July 2016 at 01:44, Nicolas Boichat wrote: >> On Wed, Jul 20, 2016 at 11:52 PM, Emil Velikov >> wrote: >>> On 20 July 2016 at 15:42, Emil Velikov wrote: >>>> On 20 July 2

[Mesa-dev] [PATCH v2] egl/dri2: Add reference count for dri2_egl_display

eglTerminate was called with a current context), however, this seems to meet the EGL spec quite well, and does not permanently leak any context/display even for incorrectly written apps. Signed-off-by: Nicolas Boichat Reviewed-by: Eric Engestrom --- src/egl/drivers/dri2/egl

Re: [Mesa-dev] [PATCH] egl/dri2: Add reference count for dri2_egl_display

On Wed, Jul 20, 2016 at 11:52 PM, Emil Velikov wrote: > On 20 July 2016 at 15:42, Emil Velikov wrote: >> On 20 July 2016 at 09:26, Nicolas Boichat wrote: >>> android.opengl.cts.WrapperTest#testGetIntegerv1 CTS test calls >>> eglTerminate, followed by eglRelea

[Mesa-dev] [PATCH] egl/dri2: Add reference count for dri2_egl_display

we still need the display vtbl (and possibly an active dri dpy connection). Therefore, we add some reference counter to dri2_egl_display, to make sure the structure is kept allocated as long as it is required. Signed-off-by: Nicolas Boichat --- Replaces https://patchwork.freedesktop.org/patch/9887

Re: [Mesa-dev] [PATCH] egl/dri2: dri2_make_current: Make sure display is initialized before using it

On Mon, Jul 18, 2016 at 4:37 PM, Emil Velikov wrote: > On 18 July 2016 at 04:19, Nicolas Boichat wrote: >> On Fri, Jul 15, 2016 at 9:03 PM, Emil Velikov >> wrote: >>> On 15 July 2016 at 09:28, Nicolas Boichat wrote: >>>> android.opengl.cts.Wrapper

Re: [Mesa-dev] [PATCH] egl/dri2: dri2_make_current: Make sure display is initialized before using it

On Fri, Jul 15, 2016 at 9:03 PM, Emil Velikov wrote: > On 15 July 2016 at 09:28, Nicolas Boichat wrote: >> android.opengl.cts.WrapperTest#testGetIntegerv1 CTS test calls >> eglTerminate, followed by eglReleaseThread. In that case, the >> display will not be initialized

[Mesa-dev] [PATCH] egl/dri2: dri2_make_current: Make sure display is initialized before using it

urf/rsurf are not all NULL. 2. Does not call glFlush/unBindContext is there is no display. 3. However, it still goes through the normal path as drv->API.DestroyContext decrements the reference count on the context, and frees the structure. Cc: "11.2 12.0" Signed-off-by:

[Mesa-dev] [PATCH v3] egl/dri2: dri2_make_current: Set EGL error if bindContext fails

From: Nicolas Boichat Without this, if a configuration is, say, available only on GLES2/3, but not on GLES1, and is rejected by the dri module's bindContext call, eglMakeCurrent fails with error "EGL_SUCCESS". In this patch, we set error to EGL_BAD_MATCH, which is wha

Re: [Mesa-dev] [PATCH v2] egl/dri2: dri2_make_current: Set EGL error if bindContext fails

Please ignore this patch, I'll resend along with some slightly improved/annotated EGL error handling. On Thu, Jul 14, 2016 at 12:22 PM, Nicolas Boichat wrote: > From: Nicolas Boichat > > Without this, if a configuration is, say, available only on GLES2/3, but > not on GLES1, a

[Mesa-dev] [PATCH v2] egl/dri2: dri2_make_current: Set EGL error if bindContext fails

From: Nicolas Boichat Without this, if a configuration is, say, available only on GLES2/3, but not on GLES1, and is rejected by the dri module's bindContext call, eglMakeCurrent fails with error "EGL_SUCCESS". In this patch, we set error to EGL_BAD_MATCH, which is wha

Re: [Mesa-dev] [PATCH] egl/dri2: dri2_make_current: Set EGL error if bindContext fails

Hi, On Wed, Jul 13, 2016 at 11:21 PM, Emil Velikov wrote: > On 7 June 2016 at 11:14, Nicolas Boichat wrote: >> Without this, if a configuration is, say, available only on GLES2/3, but >> not on GLES1, eglMakeCurrent fails with error "EGL_SUCCESS". >> &g

Re: [Mesa-dev] [PATCH] egl/dri2: dri2_make_current: Set EGL error if bindContext fails

Gentle ping, any concern about the patch below? On Tue, Jun 7, 2016 at 6:14 PM, Nicolas Boichat wrote: > Without this, if a configuration is, say, available only on GLES2/3, but > not on GLES1, eglMakeCurrent fails with error "EGL_SUCCESS". > > In this patch, we set error t

[Mesa-dev] [PATCH] egl/android: Remove unused variables

From: Tomasz Figa There are some unused variables left after previous clean-ups triggering compiler warnings. Let's remove them. Signed-off-by: Tomasz Figa --- src/egl/drivers/dri2/platform_android.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/egl/drivers/dri2/platform_android.c

[Mesa-dev] [PATCH] gallium/dri: Add shared glapi to LIBADD on Android

.so", RTLD_LAZY | RTLD_GLOBAL); dlopen("dri/_dri.so", RTLD_NOW | RTLD_GLOBAL); However, bionic does not respect the RTLD_GLOBAL flag, and the dri library cannot find symbols in libglapi.so, so we need to link to libglapi.so explicitly. Android.mk already does this. Signed-off-by: Tomas

[Mesa-dev] [PATCH] egl/dri2: dri2_make_current: Set EGL error if bindContext fails

Without this, if a configuration is, say, available only on GLES2/3, but not on GLES1, eglMakeCurrent fails with error "EGL_SUCCESS". In this patch, we set error to EGL_BAD_MATCH, which is what CTS/dEQP dEQP-EGL.functional.surfaceless_context expect. Signed-off-by: Nicolas Boichat --

Re: [Mesa-dev] [PATCH 1/2] configure.ac: Add support for Android builds

on of mesa. Tomasz is working on rebasing to the latest mesa master (it looks like someone implemented similar changes to ours to add support for PRIME FD). Let us know if you hit any issue, and looking forward to your patches, thanks a lot! Best, Nicolas ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] docs/egl: Android platform can also be build using autotools

We added support for Android build using autotools (configure), update the documentation to reflect that. Signed-off-by: Nicolas Boichat --- docs/egl.html | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/docs/egl.html b/docs/egl.html index bc21c6c..fb94f8c 100644

[Mesa-dev] [PATCH] automake: egl: Android: Add libEGL dependencies

platform_android.c needs to link with cutils, hardware, and sync libraries, as well as drm_gralloc libs. Also add appropriate tests in configure.ac. Signed-off-by: Nicolas Boichat --- configure.ac| 6 ++ src/egl/Makefile.am | 3 +++ 2 files changed, 9 insertions(+) diff --git a

Re: [Mesa-dev] [PATCH 1/2] configure.ac: Add support for Android builds

On Mon, May 23, 2016 at 8:20 PM, Emil Velikov wrote: > On 23 May 2016 at 12:17, Nicolas Boichat wrote: >> On Mon, May 23, 2016 at 5:49 PM, Emil Velikov >> wrote: >>> [...] >>>>> Do you guys have X related libraries on the host_os ? Or you >>&g

Re: [Mesa-dev] [PATCH 1/2] configure.ac: Add support for Android builds

On Mon, May 23, 2016 at 5:49 PM, Emil Velikov wrote: > [...] >>> Do you guys have X related libraries on the host_os ? Or you >>> explicitly disable those mesa features that depend on it ? >> >> AFAIK, no X libraries, neither on Chrome OS or Android side. >> > Just realised that Android requires a

Re: [Mesa-dev] [PATCH 2/2] mesa: dri: Add shared glapi to LIBADD on Android

On Thu, Apr 28, 2016 at 10:41 PM, Emil Velikov wrote: > On 28 April 2016 at 11:41, Nicolas Boichat wrote: >> /system/vendor/lib/dri/*_dri.so actually depend on libglapi: without >> this, loading the so file fails with: >> cannot locate symbol "__emutls_v._glapi_tls_Con

Re: [Mesa-dev] [PATCH 1/2] configure.ac: Add support for Android builds

at 10:36 PM, Emil Velikov wrote: > Hi Nicolas, > > On 28 April 2016 at 11:41, Nicolas Boichat wrote: >> Add support for EGL android platform. >> >> Also, detect when --host finishes with -android. In that case, we >> do not set _GNU_SOURCE, and define autoconf s

[Mesa-dev] [PATCH 2/2] mesa: dri: Add shared glapi to LIBADD on Android

D_LAZY | RTLD_GLOBAL); dlopen("dri/_dri.so", RTLD_NOW | RTLD_GLOBAL); However, bionic does not respect the RTLD_GLOBAL flag, and the dri library cannot find symbols in libglapi.so, so we need to link to libglapi.so explicitly. Android.mk already does this. Signed-off-by: Nicolas Boic

[Mesa-dev] [PATCH 1/2] configure.ac: Add support for Android builds

Add support for EGL android platform. Also, detect when --host finishes with -android. In that case, we do not set _GNU_SOURCE, and define autoconf symbol HAVE_ANDROID, so that Android-specific workarounds can be applied. Signed-off-by: Nicolas Boichat --- configure.ac| 10

Re: [Mesa-dev] [PATCH v2 0/2] Fix Gallium RGB565 image support

Le lundi 18 avril 2016 à 11:40 +0900, Michel Dänzer a écrit : > On 17.04.2016 09:49, nico...@ndufresne.ca wrote: > > > > From: Nicolas Dufresne > > > > Sorry for the long delay breaking down this patch. I have now > > rebased > > on top recent mesa tree

[Mesa-dev] [PATCH v2 1/2] gallium/dri2: Factor out DRI2 to PIPE_FORMAT conversion

From: Nicolas Dufresne This code is already duplicated twice and will be useful again. This will also help when adding formats. Signed-off-by: Nicolas Dufresne --- src/gallium/state_trackers/dri/dri2.c | 61 --- 1 file changed, 27 insertions(+), 34 deletions

[Mesa-dev] [PATCH v2 2/2] gallium/dri2: Fix RGB565 EGLImage creation

From: Nicolas Dufresne When creating egl images we do a bytes to pixel conversion by deviding by 4 regardless of the pixel format. This does not work for RGB565. In this patch, we avoid useless conversion and use proper API when the conversion cannot be avoided. Signed-off-by: Nicolas Dufresne

[Mesa-dev] [PATCH v2 0/2] Fix Gallium RGB565 image support

From: Nicolas Dufresne Sorry for the long delay breaking down this patch. I have now rebased on top recent mesa tree. First patch creates a new function to convert DRI2 format into PIPE format (to avoid more copy paste). The second fixes the wrong pitch to stride calculation fixing RGB565

Re: [Mesa-dev] [android-x86-devel] Re: gralloc_drm_pipe

r, blitters), which are less restrictive then display. Nicolas signature.asc Description: This is a digitally signed message part ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Is that possible implement OpenGL/DirectX on top of Vulkan

ANGLE is considering implementing OpenGL ES 3.x on top of Vulkan. On Sat, Feb 20, 2016 at 2:07 AM, 罗勇刚(Yonggang Luo) wrote: > > > -- > 此致 > 礼 > 罗勇刚 > Yours > sincerely, > Yonggang Luo > > _

Re: [Mesa-dev] [PATCH] gallium/dri2: Fix RGB565 EGLImage creation

Le vendredi 08 janvier 2016 à 18:55 +0900, Michel Dänzer a écrit : > The addition of this function and refactoring of existing code to use > it > should be split out into a separate patch. > > Other than that, looks good to me. Great, will do. Nicolas signature.asc Descrip

Re: [Mesa-dev] [PATCH] gallium/dri2: Avoid uneeded stride to pitch conversion

Le mardi 05 janvier 2016 à 17:19 +0100, Axel Davy a écrit : > Hi Nicolas, > > I believe this patch doesn't fully solve the problem and could > introduce some bugs. > > For example you change dri2_create_image_from_name pitch argument to > stride, > whereas t

Re: [Mesa-dev] [PATCH] gallium/dri2: Avoid uneeded stride to pitch conversion

Le me know if this patch needs an update. cheers, Nicolas Le jeudi 24 décembre 2015 à 15:15 -0500, Nicolas Dufresne a écrit : > In order to convert from stride to pitch, few functions were diving > by 4 > the stride. This is not valid for RGB565 and this conversion was not > need

[Mesa-dev] [PATCH] gallium/dri2: Avoid uneeded stride to pitch conversion

In order to convert from stride to pitch, few functions were diving by 4 the stride. This is not valid for RGB565 and this conversion was not needed anyway in this context. Signed-off-by: Nicolas Dufresne --- src/gallium/state_trackers/dri/dri2.c | 33 - 1 file

Re: [Mesa-dev] r600g winsys backend rework

y) must take into > account that a CS ioctl may be in progress. Besides that, there are > several possible race conditions in r600g, so instead of rewriting > r600g and trying to do what winsys/radeon is doing, I decided to > simply use winsys/radeon. FWIW, looks good at my place (RS780)

[Mesa-dev] [PATCH] mga: enable GL_ARB_vertex_array_object extension

:MISSING Signed-off-by: Nicolas Kaiser --- src/mesa/drivers/dri/mga/mga_xmesa.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/mesa/drivers/dri/mga/mga_xmesa.c b/src/mesa/drivers/dri/mga/mga_xmesa.c index eb7df97..6ec99db 100644 --- a/src/mesa

Re: [Mesa-dev] [PATCH 10/10] intel: Request DRI2 buffers for separate stencil and hiz

ally and unexpectedtly, we should just die unexpectedly Best regards, Nicolas Kaiser ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] cell: unbalanced parenthesis

Signed-off-by: Nicolas Kaiser --- src/gallium/drivers/cell/spu/spu_vertex_shader.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/gallium/drivers/cell/spu/spu_vertex_shader.c b/src/gallium/drivers/cell/spu/spu_vertex_shader.c index 3e9804b..d6febd3 100644 --- a

[Mesa-dev] [PATCH] main: remove duplicated includes

Remove duplicated includes of guarded headers. Signed-off-by: Nicolas Kaiser --- src/mesa/main/pack.c |1 - src/mesa/main/texstore.c |1 - 2 files changed, 0 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/pack.c b/src/mesa/main/pack.c index 4bb0a90..ad8ab9d 100644 --- a

Re: [Mesa-dev] [PATCH] r200: enable EXT_gpu_program_parameters

html.py summary/compare.vao results/vao.results results/vao.enabled.results vao.results vao.enabled.results All 0/0 2/2 general 0/0 2/2 vao-01 skippass vao-02 skip pass Best regards, Nicolas Kaiser _

Re: [Mesa-dev] [PATCH] r200: enable EXT_gpu_program_parameters

t, I guess I'll prepare to file a couple of bugs for problems I found. Best regards, Nicolas Kaiser ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] r200: enable EXT_gpu_program_parameters

\nErrors:\n\n\nOutput:\nRequires OpenGL 1.5\n (2) According to the spec this extension is tainted by patent claims, quote "SGI will not grant the ARB royalty-free use of this IP for use in OpenGL" The other three extensions look good to me. Thanks again

Re: [Mesa-dev] [PATCH] r200: enable EXT_gpu_program_parameters

ensions, GL_FALSE ); > } > if(rmesa->radeon.radeonScreen->drmSupportsVertexProgram) > - driInitSingleExtension( ctx, ARB_vp_extension ); > + driInitExtensions( ctx, ARB_vp_extension, GL_FALSE ); Ah, I missed this one. That's why it didn't

Re: [Mesa-dev] [PATCH] r200: enable EXT_gpu_program_parameters

* Nicolas Kaiser : > * Marek Olšák : > > r200 does support ARB_vertex_program. The backend is in r200_vertprog.c. I > > think it has vertex shader 1.1 in D3D. > > > > The patch is wrong though. The extension should be listed in the > > ARB_vp_extension array, not

Re: [Mesa-dev] [PATCH] r200: enable EXT_gpu_program_parameters

2 GL_VERSION = 1.3 Mesa 7.11-devel (git-4ee40c3) Best regards, Nicolas Kaiser ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] r200: enable EXT_gpu_program_parameters

Signed-off-by: Nicolas Kaiser --- According to Marek Olšák, this extension is quite popular in the GL community.[1] Tests look good: ./src/tests/prog_parameter GL_RENDERER = Mesa DRI R200 (R200 514D) TCL DRI2 GL_VERSION = 1.3 Mesa 7.11-devel (git-4ee40c3) GL_EXT_gpu_program_parameters

[Mesa-dev] [PATCH] fix typos in wayland spec

Signed-off-by: Nicolas Kaiser --- docs/WL_bind_wayland_display.spec |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/WL_bind_wayland_display.spec b/docs/WL_bind_wayland_display.spec index 0ff49d6..b4e6703 100644 --- a/docs/WL_bind_wayland_display.spec +++ b

[Mesa-dev] [PATCH] fix typos in MESA specs

Signed-off-by: Nicolas Kaiser --- docs/MESA_agp_offset.spec |2 +- docs/MESA_drm_image.spec |4 ++-- docs/MESA_multithread_makecurrent.spec |2 +- docs/MESA_pack_invert.spec |2 +- docs/MESA_release_buffers.spec |8 docs

[Mesa-dev] [PATCH] gl.h, gl2.h, gallium: use stdbool.h for GLboolean and boolean

This patch adds support for the compiler built-in Boolean type to GLboolean and the "boolean" type in gallium by bringing them in line with the "bool" type in stdbool.h. Signed-off-by: Nicolas Kaiser --- include/GL/gl.h |7 --

[Mesa-dev] [PATCH] nv50: fix typo in copyright notice

Fix typo in copyright notice. Signed-off-by: Nicolas Kaiser --- src/gallium/drivers/nv50/nv50_program.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/gallium/drivers/nv50/nv50_program.c b/src/gallium/drivers/nv50/nv50_program.c index db68176..9f5e58e 100644

[Mesa-dev] [PATCH] gallium/nv50: always true conditional

Untested: Am I guessing right it was rather meant this way? --- src/gallium/drivers/nv50/nv50_pc_optimize.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/gallium/drivers/nv50/nv50_pc_optimize.c b/src/gallium/drivers/nv50/nv50_pc_optimize.c index 921ed15..27eb381 10

  1   2   >