Reviewed-by: Edward O'Callaghan
On 2016-04-30 01:48, Fabio Pedretti wrote:
---
docs/GL3.txt | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/docs/GL3.txt b/docs/GL3.txt
index bb2bb6e..5a6be41 100644
--- a/docs/GL3.txt
+++ b/docs/GL3.txt
@@ -148,17 +148,17 @@ GL
On 2016-03-31 21:57, Timothy Arceri wrote:
---
src/compiler/glsl/lower_packed_varyings.cpp | 25
+
1 file changed, 25 insertions(+)
diff --git a/src/compiler/glsl/lower_packed_varyings.cpp
b/src/compiler/glsl/lower_packed_varyings.cpp
index ad766bb..6e7a289 100644
---
Acked-by: Edward O'Callaghan
On 2016-03-31 21:57, Timothy Arceri wrote:
These outputs have a separate location domain from per-vertex outputs
and need to be handled separately. For now just skip validation so we
don't invalidate valid shaders.
---
src/compiler/glsl/link_varyings.cpp | 16 +
Acked-by: Edward O'Callaghan
On 2016-03-31 21:58, Timothy Arceri wrote:
---
docs/GL3.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/docs/GL3.txt b/docs/GL3.txt
index f6248da..ede8cf5 100644
--- a/docs/GL3.txt
+++ b/docs/GL3.txt
@@ -193,11 +193,11 @@ GL 4.4, GLSL 4.
Reviewed-by: Edward O'Callaghan
On 2016-03-31 21:57, Timothy Arceri wrote:
---
src/compiler/glsl/ast_type.cpp | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/compiler/glsl/ast_type.cpp
b/src/compiler/glsl/ast_type.cpp
index 30c9eff..de3fdcc 100644
--- a/src/compiler/glsl/ast_type.cpp
On 2016-04-20 11:46, Nicolai Hähnle wrote:
On 19.04.2016 17:50, Bas Nieuwenhuizen wrote:
Signed-off-by: Bas Nieuwenhuizen
---
src/gallium/drivers/radeonsi/si_compute.c | 5 -
src/gallium/drivers/radeonsi/si_state_shaders.c | 5 -
2 files changed, 8 insertions(+), 2 deletions(-
On 2016-04-20 09:29, Bas Nieuwenhuizen wrote:
I retract patch 1 and 2. Large scratch buffers are nice, but the
hardware only supports a 32-bit offset into it.
- Bas
On Wed, Apr 20, 2016 at 12:50 AM, Bas Nieuwenhuizen
wrote:
Use the CE suballocator instead of the normal one as the usage
is mos
On 2016-04-16 20:20, Marek Olšák wrote:
On Sat, Apr 16, 2016 at 8:04 AM, Michel Dänzer
wrote:
On 16.04.2016 14:51, Michel Dänzer wrote:
On 16.04.2016 11:39, Tom Stellard wrote:
The ds_bpermute instruction allows threads to transfer data directly
to or from the vgprs of other threads. These i
Patches 1 & 2 are,
Reviewed-by: Edward O'Callaghan
i`ll have to spend some time looking at the others tomorrow..
On 2016-04-16 22:50, Marek Olšák wrote:
From: Marek Olšák
and remove number assignments which are consecutive
---
src/gallium/include/pipe/p_defines.h | 378
+++
This series is,
Reviewed-by: Edward O'Callaghan
On 2016-04-16 22:50, Marek Olšák wrote:
From: Marek Olšák
---
src/gallium/drivers/radeon/r600_query.h | 43
++---
1 file changed, 23 insertions(+), 20 deletions(-)
diff --git a/src/gallium/drivers/radeon/r600_que
Hi Jakob,
Unfortunately ARB_clear_texture is not as straight forward and taking
that from nouveau.
You will notice I sent essentially a identical series last year to the
ml as a rfc. You
can find that work sitting around on my github here:
https://github.com/victoredwardocallaghan/mesa-GLwor
Patches - 2-4, 7-8, 12-14 & 17 - are all:
Reviewed-by: Edward O'Callaghan
The series was:
Tested-by: Edward O'Callaghan
On 2016-04-14 05:29, Bas Nieuwenhuizen wrote:
Signed-off-by: Bas Nieuwenhuizen
Reviewed-by: Marek Olšák
Reviewed-by: Nicolai Hähnle
---
src/gallium/drivers/radeonsi/
This series is,
Reviewed-by: Edward O'Callaghan
On 2016-04-14 02:43, Jakob Sinclair wrote:
Trivial change. Removing unnecessary semi-colons from the code.
I don't have push access so someone reviewing this can push it.
Signed-off-by: Jakob Sinclair
---
src/compiler/glsl/ast_function.cpp
On 2016-04-11 22:27, Roland Scheidegger wrote:
Am 10.04.2016 um 09:41 schrieb Edward O'Callaghan:
All the piglits pass for these two as-is. However, some of the piglits
require SSBO support to run, although I can't see why anything would
actually fail but I thought I would make note of it just i
This series is,
Reviewed-by: Edward O'Callaghan
On 2016-04-13 11:06, Thomas Hindoe Paaboel Andersen wrote:
Increase r to four channels as rgba is written to it
---
src/gallium/auxiliary/tgsi/tgsi_exec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/auxiliary/
Reviewed-by: Edward O'Callaghan
On 2016-04-13 08:10, Mark Janes wrote:
Fixes intermittent Vulkan CTS failures within the test groups:
dEQP-VK.api.object_management.multithreaded_per_thread_device
dEQP-VK.api.object_management.multithreaded_per_thread_resources
dEQP-VK.api.object_management.mult
Reviewed-by: Edward O'Callaghan
On 2016-04-13 07:42, Nicolai Hähnle wrote:
From: Nicolai Hähnle
This is the last necessary bit for OpenGL 4.2 support. All
driver-specific
functionality has already been implemented as part of extensions.
---
docs/relnotes/11.3.0.html | 7 --
Reviewed-by: Edward O'Callaghan
Thanks for working on this,
Edward.
On 2016-04-12 05:02, Marek Olšák wrote:
Hi,
This disables buffer moves between VRAM and GTT by setting both of
them as preferred heaps for APUs and IGPs.
Allocations go to VRAM if there is free space. If not, they go to GTT.
I didn't see anything obviously wrong so,
Reviewed-by: Edward O'Callaghan
But I have some general questions about guard band, not sure if this is
the right place but I'll just ask any way:
From my somewhat naive understanding guard band can lead to small gaps
between polygons. In this impleme
Acked-by: Edward O'Callaghan
On 2016-04-09 09:12, Marek Olšák wrote:
From: Marek Olšák
---
src/gallium/drivers/r600/r600d.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/r600/r600d.h
b/src/gallium/drivers/r600/r600d.h
index 3d223ed..ef99573 100644
This series is,
Reviewed-by: Edward O'Callaghan
This definitely makes for a good cleanup, I was wondering about all the
manual stuff myself..
On 2016-04-09 09:12, Marek Olšák wrote:
From: Marek Olšák
---
src/gallium/drivers/radeon/r600_pipe_common.h | 5 -
src/gallium/drivers/radeons
Reviewed-by: Edward O'Callaghan
On 2016-04-08 18:58, Marek Olšák wrote:
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_blit.c | 3 ---
src/gallium/drivers/radeonsi/si_pipe.h | 4
src/gallium/drivers/radeonsi/si_state.c | 32
+++-
src/g
On 2016-04-08 19:00, Marek Olšák wrote:
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_state.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_state.c
b/src/gallium/drivers/radeonsi/si_state.c
index 8087d23..3894e1d 100644
Reviewed-by: Edward O'Callaghan
On 2016-04-08 19:00, Marek Olšák wrote:
From: Marek Olšák
---
src/gallium/drivers/r600/r600_state_common.c | 5 ++---
src/gallium/drivers/radeon/r600_pipe_common.h | 6 ++
src/gallium/drivers/radeon/r600_streamout.c | 6 --
src/gallium/drivers/radeo
Reviewed-by: Edward O'Callaghan
+1 for defensive programming.
On 2016-04-07 06:00, Brian Paul wrote:
These small mallocs will probably never fail, but static analysis tools
may complain about the missing checks.
---
src/gallium/drivers/svga/svga_pipe_blend.c| 3 +++
src/gallium/driver
Nice cleanup. This series is,
Reviewed-by: Edward O'Callaghan
On 2016-04-07 07:40, Dave Airlie wrote:
This probably should have been cleaned up before merging, but we
were a bit lax with it. This is a bunch of cleanups and changes,
that make adding ARB_compute_support less of a task.
Dave.
I had a hacked up version of this last week which was very similar.
This is much cleaner, hence this series is,
Reviewed-by: Edward O'Callaghan
On 2016-04-04 21:41, Bas Nieuwenhuizen wrote:
This series implements ARb_robust_buffer_access_behavior for the
radeonsi
driver.
There are some tests
Patches 1-5, 8 & 10 are,
Reviewed-by: Edward O'Callaghan
On 2016-04-04 12:15, Dave Airlie wrote:
Okay I've taken Tobias' last work in progress, cleaned it up a bit,
move the rename out into a separate patch, reordered things slightly.
I've dropped the separate passes, I think nearly all hw op
This series is,
Tested-By: Edward O'Callaghan
I didn`t pick up anything major wrong with it, but with others
minor suggestions this series is also,
Reviewed-By: Edward O'Callaghan
Kind Regards,
On 2016-04-03 00:10, Bas Nieuwenhuizen wrote:
This series implements OpenGL compute shader for r
This series is,
Acked-by: Edward O'Callaghan
On 2016-04-03 21:16, Timothy Arceri wrote:
This is the final clean-up of the buffer block structures. With this
series we just create two arrays to begin with and drop the combined
array.
Note to avoid code churn and regressions I intend to squash
On 2016-04-03 14:55, Ilia Mirkin wrote:
On Sat, Apr 2, 2016 at 10:54 PM, Edward O'Callaghan
wrote:
This series implements ARB_framebuffer_no_attachments for radeonsi &
r600g. It is a rebase of the last previous patch series with the
respective Rb's added.
I have given back my R9 hw today and s
Reviewed-by: Edward O'Callaghan
On 2016-03-31 18:03, Dave Airlie wrote:
From: Dave Airlie
This refactors out the code and fixes it up to be used
for images later. It uses the code in the current RAT binding
for compute.
Signed-off-by: Dave Airlie
---
src/gallium/drivers/r600/evergreen_stat
Reviewed-by: Edward O'Callaghan
On 2016-03-31 18:03, Dave Airlie wrote:
From: Dave Airlie
This moves the code to create CB info out into
a separate function so it can be reused in images
code to create RATs.
Signed-off-by: Dave Airlie
---
src/gallium/drivers/r600/evergreen_state.c | 257
+
Reviewed-by: Edward O'Callaghan
On 2016-03-31 18:03, Dave Airlie wrote:
From: Dave Airlie
This takes the code required to initialise a buffer resource
out of the texture buffer code, into it's own function.
This is going to be used for the image support later.
Signed-off-by: Dave Airlie
--
Reviewed-by: Edward O'Callaghan
On 2016-03-31 18:03, Dave Airlie wrote:
From: Dave Airlie
This refactors out the code to setup a texture resource
so we can reuse it later from the images code.
Signed-off-by: Dave Airlie
---
src/gallium/drivers/r600/evergreen_state.c | 274
Determinism is always better regardless of how you get there. A
null pointer deference `on purpose` is a really poor idea in C.
I am somewhat surprised you are asking if its really better to
rely on undefined behavior vs. an assert.
I thought about using a if branch and just returning but I think
Reviewed-by: Edward O'Callaghan
On 2016-03-27 14:51, Timothy Arceri wrote:
The only place this was used was in a gallium debug function that
had to be manually enabled.
---
src/compiler/glsl/ir_uniform.h | 5
src/compiler/glsl/link_uniform_initializers.cpp | 4 ---
src/
On 2016-03-25 22:20, Ilia Mirkin wrote:
On Mar 25, 2016 4:43 AM, wrote:
On 2016-03-25 14:02, Ilia Mirkin wrote:
On Thu, Mar 24, 2016 at 8:11 PM, Edward O'Callaghan
wrote:
Using PIPE_FORMAT_NONE to indicate what MSAA modes are supported
with a framebuffer using no attachment.
Signed-off-b
On 2016-03-25 14:29, Ilia Mirkin wrote:
Please leave this and the next patch out of your series. I'm going to
need to retest everything carefully once the core support is in (and I
get a bit of time).
Done. Be sure to remove my Rb if you made changes and i`ll review it
again.
Thanks,
-i
On 2016-03-25 14:20, Ilia Mirkin wrote:
Instead of introducing buggy code in patch 6/17 and then fixing it up
here, you need to fold this with patch 6 so that it's all done at the
same time.
Yea, can do. Cheers,
On Thu, Mar 24, 2016 at 8:11 PM, Edward O'Callaghan
wrote:
Upon context creati
On 2016-03-25 14:02, Ilia Mirkin wrote:
On Thu, Mar 24, 2016 at 8:11 PM, Edward O'Callaghan
wrote:
Using PIPE_FORMAT_NONE to indicate what MSAA modes are supported
with a framebuffer using no attachment.
Signed-off-by: Edward O'Callaghan
---
src/mesa/state_tracker/st_atom_framebuffer.c | 51
Reviewed-by: Edward O'Callaghan
On 2016-03-23 04:27, Marek Olšák wrote:
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_state.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/gallium/drivers/radeonsi/si_state.c
b/src/gallium/drivers/radeonsi/si_state.c
index
Ah you are correct, this is no longer needed in the push branch. We can
drop this one from the series as its a nop, please ignore thanks for
spotting it.
On 2016-03-22 02:43, Marek Olšák wrote:
Does this fix anything even? The blitter always binds something, thus
this should have no effect.
M
Hi Nicolai,
Thanks for taking over this work and going the whole nine yards with it!
This series is, Reviewed-by: Edward O'Callaghan
Thanks again,
Edward.
On 2016-03-22 10:21, Nicolai Hähnle wrote:
Hi,
since shader images have laid most of the foundation, here are shader
buffers
now. Thi
Too quick, very nice cleanup, thanks.
Reviewed-by: Edward O'Callaghan
On 2016-03-22 12:58, Bas Nieuwenhuizen wrote:
This removes any dependency on driver validation of the number of
framebuffer samples.
Signed-off-by: Bas Nieuwenhuizen
---
src/mesa/drivers/dri/i965/brw_util.h
Reviewed-by: Edward O'Callaghan
On 2016-03-22 11:29, Dave Airlie wrote:
From: Dave Airlie
These don't get used and haven't been in git history from what I can
see, so drop them.
Signed-off-by: Dave Airlie
---
src/gallium/auxiliary/draw/draw_gs.c | 6 --
src/gallium/auxiliary/draw
Reviewed-by: Edward O'Callaghan
On 2016-03-22 07:41, Nicolai Hähnle wrote:
From: Nicolai Hähnle
Results are undefined but may not crash. Without this change,
out-of-bounds
indexing can lead to VM faults and GPU hangs.
Constant buffers, samplers, and possibly others will eventually need
si
On 2016-03-21 21:06, Marek Olšák wrote:
On Sat, Mar 19, 2016 at 5:09 PM, Ilia Mirkin
wrote:
On Sat, Mar 19, 2016 at 12:02 PM, Bas Nieuwenhuizen
wrote:
On Sat, Mar 19, 2016 at 4:25 PM, Ilia Mirkin
wrote:
On Sat, Mar 19, 2016 at 11:14 AM, Bas Nieuwenhuizen
wrote:
That would limit us to supp
On 2016-03-19 21:08, Kai Wasserbäch wrote:
Edward O'Callaghan wrote on 19.03.2016 07:41:
Signed-off-by: Edward O'Callaghan
---
docs/GL3.txt | 2 +-
docs/relnotes/11.3.0.html | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/docs/GL3.txt b/docs/GL3.txt
index 3058
Hi Nicolai,
This series is,
Reviewed-by: Edward O'Callaghan
Thanks,
On 2016-03-19 14:37, Nicolai Hähnle wrote:
Hi,
these patches apply on top of my ARB_shader_image_load_store series.
Together,
they fix a few remaining fails with piglit's
arb_shader_image_load_store-host-mem-barrier.
You c
Reviewed-by: Edward O'Callaghan
On 2016-03-14 03:46, Marek Olšák wrote:
From: Marek Olšák
---
configure.ac | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure.ac b/configure.ac
index 49be147..d768db6 100644
--- a/configure.ac
+++ b/configure.ac
@@ -70,7 +70,7 @@ AC_
Reviewed-by: Edward O`Callaghan
I had the same issue also.
On 2016-02-16 17:31, Ilia Mirkin wrote:
From ARB_sample_shading:
"gl_NumSamples is the total number of samples in the framebuffer,
or one if rendering to a non-multisample framebuffer"
So make sure to always pass in at least
Disregard, apparently this breaks out-of-tree builds. There perhaps is
maybe no good solution here so i`ll refrain from this can of worms for
now.
On 2016-02-18 15:46, Edward O'Callaghan wrote:
Just use the relative path in the Makefile.source over
symbol links that are not necessarily portabl
Thanks kindly.
Reviewed-by: Edward O'Callaghan
On 2016-02-14 09:39, Serge Martin wrote:
---
src/gallium/state_trackers/clover/core/kernel.cpp | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/gallium/state_trackers/clover/core/kernel.cpp
b/src/gallium/state_tracker
This series is,
Reviewed-by: Edward O'Callaghan
On 2016-02-06 11:56, Brian Paul wrote:
New functions for examining instructions, declarations, etc.
---
src/gallium/auxiliary/tgsi/tgsi_scan.c | 739
+
1 file changed, 375 insertions(+), 364 deletions(-)
diff -
Reviewed-by: Edward O'Callaghan
On 2016-02-04 13:28, Michel Dänzer wrote:
From: Michel Dänzer
Otherwise it's not possible to diagnose problems caused by optimization
passes.
Signed-off-by: Michel Dänzer
---
src/gallium/drivers/radeonsi/si_shader.c | 20 ++--
1 file changed,
Can't see any serious issues here and a non-verified `working' instance
of
GPUPerfStudio is sure better than a crashing one!
This series is,
Reviewed-by: Edward O'Callaghan
On 2016-02-04 00:52, Nicolai Hähnle wrote:
Hi,
this bunch of patches meets GPUPerfStudio half-way in supporting the
This series is,
Reviewed-by: Edward O'Callaghan
On 2016-01-31 02:50, Marek Olšák wrote:
From: Marek Olšák
no difference between those
---
src/mesa/state_tracker/st_atom_shader.c | 6 +-
src/mesa/state_tracker/st_cb_program.c | 18 ++-
src/mesa/state_tracker/st_context.h | 6 +-
sr
Reviewed-by: Edward O'Callaghan
On 2016-01-31 16:58, Ilia Mirkin wrote:
In case we have a draw buffer without attachments, we should be looking
at the default number of samples.
Signed-off-by: Ilia Mirkin
---
Still doesn't work properly on nvc0, but at least the right number of
min samples g
This series is,
Reviewed-by: Edward O'Callaghan
Good job working out where this issue was.
On 2016-01-26 18:40, Michel Dänzer wrote:
From: Michel Dänzer
Failing to do this was resulting in the kernel driver unnecessarily
leaving open the possibility of CPU access to tiled BOs.
Bugzilla: ht
This whole series is now,
Reviewed-by: Edward O'Callaghan
On 2016-01-25 05:59, Ilia Mirkin wrote:
I believe I've addressed the various feedback people had. There's the
outstanding point of how to expose the atomic buffer bindings, but
this is a larger issue and largely tangential to the actual
Reviewed-by: Edward O'Callaghan
On 2016-01-25 03:40, Nicolai Hähnle wrote:
From: Nicolai Hähnle
This fixes a VM fault and possible lockup in high memory pressure
situations.
Cc: "11.0 11.1"
---
src/gallium/drivers/radeonsi/si_descriptors.c | 33
+++
1 file chang
This series is,
Reviewed-by: Edward O'Callaghan
On 2016-01-23 01:18, Marek Olšák wrote:
From: Marek Olšák
v2: After more discussion with hw teams, the kernel already contains
the
optimal settings allowing us to use all CUs.
---
src/gallium/drivers/radeonsi/si_state.c | 4 ++--
1 file
This series is,
Reviewed-by: Edward O'Callaghan
On 2016-01-23 10:59, Nicolai Hähnle wrote:
Hi,
this series was prompted by a rendering bug reported for Dolphin. The
bug is
fixed in the first two patches, and the remainder is assorted cleanups
that
I noticed while working on the fix. Please
To the best of my understanding, this series is now:
Reviewed-by: Edward O'Callaghan
On 2016-01-22 06:37, Nicolai Hähnle wrote:
Hi everybody,
here's an updated version of the series.
I decided to keep BUFFER_SAMPLER_VIEW_RGBA_ONLY as is, following
Fredrik's
point that it affects not only t
Reviewed-by: Edward O'Callaghan
On 2016-01-22 04:35, Axel Davy wrote:
Add a debug option to select the LLVM SI Machine Scheduler.
R600_DEBUG=sisched
Signed-off-by: Axel Davy
---
The corresponding llvm patch is on llvm master,
and should land soon for 3.8 branch
src/gallium/drivers/radeon/r60
This series is,
Reviewed-by: Edward O'Callaghan
On 2016-01-20 12:39, Marek Olšák wrote:
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_shader.c | 33
+---
1 file changed, 30 insertions(+), 3 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_shad
Reviewed-by: Edward O'Callaghan
On 2016-01-18 16:51, Ilia Mirkin wrote:
---
src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 22 ++
1 file changed, 18 insertions(+), 4 deletions(-)
diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
b/src/mesa/state_tracker/st_glsl_to_tgsi
Reviewed-by: Edward O'Callaghan
On 2016-01-17 19:46, Ilia Mirkin wrote:
Spotted by Coverity.
Signed-off-by: Ilia Mirkin
---
src/gallium/auxiliary/tgsi/tgsi_build.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/auxiliary/tgsi/tgsi_build.c
b/src/gallium/auxiliary/tgsi/tgsi_bu
This series is,
Reviewed-by: Edward O'Callaghan
On 2016-01-15 14:23, Michel Dänzer wrote:
From: Michel Dänzer
Say "LLVM" instead of "Compiler" for clarity.
Signed-off-by: Michel Dänzer
---
src/gallium/drivers/radeonsi/si_shader.c | 11 +--
1 file changed, 9 insertions(+), 2 deleti
This series is,
Reviewed-by: Edward O'Callaghan
On 2016-01-11 14:13, Timothy Arceri wrote:
---
src/glsl/glsl_parser.yy | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/glsl/glsl_parser.yy b/src/glsl/glsl_parser.yy
index 6b634f2..b2b94f4 100644
--- a/src/glsl/glsl_pars
This series is:
Reviewed-by: Edward O'Callaghan
On 2016-01-08 12:12, Marek Olšák wrote:
From: Marek Olšák
These aren't part of ARB_fragment_program.
---
src/mesa/state_tracker/st_mesa_to_tgsi.c | 51
1 file changed, 51 deletions(-)
diff --git a/src/mesa/s
This series is:
Reviewed-by: Edward O'Callaghan
On 2016-01-08 12:30, Marek Olšák wrote:
From: Marek Olšák
It will become a system value, not an input.
---
src/gallium/drivers/radeonsi/si_state_shaders.c | 45
-
1 file changed, 22 insertions(+), 23 deletions(-)
dif
This series is:
Reviewed-by: Edward O'Callaghan
On 2016-01-08 12:29, Marek Olšák wrote:
Hi,
This series adds the possibility for drivers to get gl_FragCoord and
gl_FrontFacing as system values. When FACE is a system value, it also
changes its type to integer from floating-point.
Each variabl
This series is:
Reviewed-by: Edward O'Callaghan
On 2016-01-08 15:25, Timothy Arceri wrote:
---
src/glsl/link_uniforms.cpp | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/src/glsl/link_uniforms.cpp b/src/glsl/link_uniforms.cpp
index 47bb771..33b2d4c 100644
--- a/sr
This series is,
Reviewed-by: Edward O'Callaghan
On 2016-01-06 12:46, Marek Olšák wrote:
From: Marek Olšák
This will be used by radeonsi.
---
src/gallium/auxiliary/tgsi/tgsi_scan.c | 2 ++
src/gallium/auxiliary/tgsi/tgsi_scan.h | 1 +
2 files changed, 3 insertions(+)
diff --git a/src/galliu
On 2016-01-06 10:30, Brian Paul wrote:
Series looks OK to me. Reviewed-by: Brian Paul
Do you need someone to commit/push for you?
I do yes, thank you kindly.
Edward.
-Brian
On 01/05/2016 03:07 AM, Edward O'Callaghan wrote:
Fix silly issue with MSVC case fall-though support to need
a ex
Reviewed-by: Edward O'Callaghan
On 2016-01-05 05:27, Rob Clark wrote:
From: Rob Clark
nir.h is a bit inconsistent about 'typedef struct {} nir_foo' vs
'typedef struct nir_foo {} nir_foo'. But missing struct name tags is
inconvenient when you need a fwd declaration without pulling in all
of n
In this series patches 2-8 are:
Reviewed-by: Edward O'Callaghan
with some commentary on patch 1.
Kind Regards,
On 2016-01-03 15:37, Ilia Mirkin wrote:
This provides enough support in TGSI to support shader buffers. I do
away with the defunct TGSI_FILE_RESOURCE (renaming it into
TGSI_FILE_IMA
There is quite a bit of rename churn happening here at the same time as
the bring up of ureg support for image declarations.
Would it be possible to split the rename churn out from the actual
behavioral changes please?
On 2016-01-03 15:37, Ilia Mirkin wrote:
Signed-off-by: Ilia Mirkin
---
sr
In this series patches 1-4 are:
Reviewed-by: Edward O'Callaghan
No idea what is happening in patch 5 to say anything either way.
On 2016-01-03 07:38, Ilia Mirkin wrote:
The nvc0 patch applies on top of some unpublished patches, see
https://github.com/imirkin/mesa/commits/tmp4
for the full t
This series is:
Reviewed-by: Edward O'Callaghan
On 2016-01-03 11:37, Ilia Mirkin wrote:
Signed-off-by: Ilia Mirkin
---
src/gallium/docs/source/tgsi.rst | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/src/gallium/docs/source/tgsi.rst
b/src/gallium/docs/source/t
omg I don't know why folks insist on using gnuc nested functions they
are insane.
Thanks for working though this one!
Reviewed-by: Edward O'Callaghan
On 2016-01-03 04:20, Samuel Pitoiset wrote:
Nested functions are supported as an extension in GNU C, but Clang
don't support them.
This fixes
Well can't disagree with anything in this series and it certainly makes
`si_shader.c' a tiny bit easier to understand for me.
Hopefully not too much fallout with the debug callback patch series as
they will need to be rebased on top of this :|
Thus this series is,
Reviewed-by: Edward O'Callagh
Fantastic thanks!
This series is,
Reviewed-by: Edward O'Callaghan
On 2015-12-31 13:30, Nicolai Hähnle wrote:
From: Nicolai Hähnle
---
src/gallium/drivers/radeon/r600_pipe_common.c | 12
src/gallium/drivers/radeon/r600_pipe_common.h | 2 ++
2 files changed, 14 insertions(+)
d
This series is,
Reviewed-by: Edward O'Callaghan
On 2015-12-29 21:02, Timothy Arceri wrote:
From: Emil Velikov
Reviewed-by: Timothy Arceri
---
src/glsl/ast_to_hir.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
index
On 2015-12-29 16:00, Timothy Arceri wrote:
This series adds support for the component layout qualifier by
enhancing
the varying packing pass at the GLSL IR level. The advantage to this
approach is that its fairly simple and will work for all drivers, the
disadvantage it that it relies on optimis
On 2015-12-29 16:00, Timothy Arceri wrote:
Tessellation shaders treat varyings as shared memory and invocations
can access each others varyings therefore we can't use the existing
method to lower them.
This adds a check for these stages as following patches will
allow explicit locations to be lo
On 2015-12-29 16:00, Timothy Arceri wrote:
For tessellation shaders we cannot just copy everything to the packed
varyings like we do in other stages as tessellation uses shared memory
for
varyings, therefore it is only safe to copy array elements that the
shader
actually uses.
This class sear
Should I be expecting to see myself on here?
On 2015-12-28 20:50, Giuseppe Bilotta wrote:
This adds a first tentative .mailmap file, to canonicize contributor
name/emails in shortlogs and other statistical endeavours.
Signed-off-by: Giuseppe Bilotta
---
Hopefully the last time I need to submit
Reviewed-by: Edward O'Callaghan
Congrats on getting this working, also thanks!
On 2015-12-25 12:34, Kenneth Graunke wrote:
This morning, I woke up and somehow "knew" what was causing my HS GPU
hangs
on Gen7/7.5. It turns out I was (completely) wrong, but through some
miraculous series of il
On 2015-12-22 21:20, Kenneth Graunke wrote:
If there's no evaluation shader, tessellation is disabled. The upload
functions would just bail. Instead, don't bother calling them.
This will simplify the optional-TCS case a bit, as brw_upload_tcs can
assume that we're doing tessellation.
Signed-o
Thanks for the most comprehensive cleanup Roland and fixing that
minor regression we discussed. Happy holiday's.
Reviewed-by: Edward O'Callaghan
On 2015-12-22 14:00, srol...@vmware.com wrote:
From: Roland Scheidegger
Previously the code would just redirect requests for attributes which
don'
On 2015-12-20 09:39, Rob Clark wrote:
From: Rob Clark
We are going to start using nir_builder.h from some gallium code, which
is currently only C90. Which results in:
In file included from nir/nir_emulate.c:26:0:
../../../src/glsl/nir/nir_builder.h: In function ‘nir_build_alu’:
../..
On 2015-12-15 04:06, Nicolai Hähnle wrote:
From: Nicolai Hähnle
The incorrectly computed register count caused lockups.
---
src/gallium/drivers/radeonsi/si_perfcounter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/radeonsi/si_perfcounter.c
b/src/gall
On 2015-12-13 16:25, Timothy Arceri wrote:
This makes the code easier to follow, should be more efficient
and will makes it easier to add matching via explicit locations
in the following patch.
This patch also replaces the hash table with the newer
resizable hash table this should be more suitab
On 2015-12-10 09:54, Marek Olšák wrote:
From: Marek Olšák
---
src/gallium/drivers/radeonsi/si_debug.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/src/gallium/drivers/radeonsi/si_debug.c
b/src/gallium/drivers/radeonsi/si_debug.c
index cce665e..034acf5 100644
On 2015-12-10 22:15, Marek Olšák wrote:
On Thu, Dec 10, 2015 at 4:01 AM, Michel Dänzer
wrote:
On 10.12.2015 06:58, Marek Olšák wrote:
From: Marek Olšák
Both caused a crash due to a division by zero in that function.
This is an alternative fix.
Cc: 11.0 11.1
---
src/gallium/drivers/radeons
On 2015-12-10 01:47, Marek Olšák wrote:
From: Marek Olšák
I guess the crash was because of divison by zero.
Cc: 11.0 11.1
---
src/gallium/auxiliary/util/u_prim.h | 17 +
src/gallium/drivers/radeonsi/si_state_draw.c | 3 ++-
2 files changed, 15 insertions(+), 5 delet
Roland,
I could not due to ml size limit or something, it just bounces hence the
pull request.
Cheers,
Edward.
On 2015-12-10 02:38, Roland Scheidegger wrote:
Am 09.12.2015 um 05:16 schrieb Edward O'Callaghan:
This fixes my initial attempt so that piglit now passes 14/14. Thanks
to a couple
1 - 100 of 106 matches
Mail list logo