Port changes from radeon_vcn_enc_1_2.c to radeon_vcn_enc_2_0.c
Set cu_qp_delta_enable_flag on when rate control is enabled, and set it
off when rate control is disabled (e.g. constant qp).
Signed-off-by: Boyuan Zhang
---
src/gallium/drivers/radeon/radeon_vcn_enc_2_0.c | 8 +++-
1 file chang
Patch is
Reviewed-by: Boyuan Zhang mailto:boyuan.zh...@amd.com>>
Regards,
Boyuan
From: Liu, Leo
Sent: December 3, 2019 9:08 PM
To: Marek Olšák ; Sahu, Satyajit ;
Zhang, Boyuan
Cc: ML Mesa-dev ; Sharma, Deepak
Subject: Re: [Mesa-dev] [PATCH] radeonsi: Add support for midstream b
Patch is
Reviewed-by: Boyuan Zhang
-Original Message-
From: mesa-dev On Behalf Of Liu, Leo
Sent: September 4, 2019 1:40 PM
To: mesa-dev@lists.freedesktop.org
Subject: [Mesa-dev] [PATCH] radeon/vcn: add RENOIR VCN decode support
It has same VCN2.x block as Navi1x
Signed-off-by: Leo Liu
Sent: May 28, 2019 3:27 AM
To: Zhang, Boyuan ; mesa-dev@lists.freedesktop.org
Cc: mesa-sta...@lists.freedesktop.org
Subject: Re: [Mesa-dev] [PATCH] radeon/uvd: fix poc for hevc encode
It would be better to have those checks in the state tracker than in the
backend code.
Christian.
Am 27.05.19 um
for HEVC encoding should be 64 due to hardware requirement.
This will fix conformance_window_flag in SPS.
v2 (Zhang, Boyuan):
- add marcos to define width alignment for hevc and h264
Signed-off-by: Lei Zhou
---
src/gallium/drivers/radeon/radeon_vcn_enc.c | 4 ++--
src/gallium/drivers
Hi Lei,
You are right. The width alignment for HEVC encoding should be 64. This is
actually a hardware requirement that we missed here. Thanks for catching it.
Just a small suggestion, can we use macros to define width alignment for hevc
and h264 instead of the number 64 and 16? So that we can
This patch is
Reviewed-by: Boyuan Zhang
-Original Message-
From: mesa-dev On Behalf Of Liu, Leo
Sent: February 8, 2019 10:11 AM
To: mesa-dev@lists.freedesktop.org
Cc: 19 . 0
Subject: [Mesa-dev] [PATCH 2/2] st/va/vp9: set max reference as default of VP9
reference number
If there is no
This patch is
Reviewed-by: Boyuan Zhang
-Original Message-
From: mesa-dev On Behalf Of Liu, Leo
Sent: February 8, 2019 10:11 AM
To: mesa-dev@lists.freedesktop.org
Cc: 19 . 0
Subject: [Mesa-dev] [PATCH 1/2] st/va: fix the incorrect max profiles report
Add "PIPE_VIDEO_PROFILE_MAX" to en
König
Sent: September 26, 2018 4:05 AM
To: Zhang, Boyuan ; mesa-dev@lists.freedesktop.org
Subject: Re: [PATCH] vl: reorder H264 profiles
Am 26.09.2018 um 00:11 schrieb boyuan.zh...@amd.com:
> From: Boyuan Zhang
>
> Fix the wrong h264 profiles order. Previously, the constrained
> baseli
Update patch 05/12 with a fix.
From: Boyuan Zhang
Implement encoding of sps, pps, vps, aud, and slice headers for HEVC
based on HEVC specs.
Signed-off-by: Boyuan Zhang
Acked-by: Christian König
---
src/gallium/drivers/radeon/radeon_vcn_enc_1_2.c | 348 +++-
1 file changed
The whole series are the updated version. Changes are made mainly based on the
comments from previous code review, plus fixing a few typos.
-Original Message-
From: Zhang, Boyuan
Sent: February-02-18 11:11 AM
To: mesa-dev@lists.freedesktop.org
Cc: Zhang, Boyuan
Subject: [PATCH 01/12] vl
Thanks a lot for pointing out, I add meson changes too.
Regards,
Boyuan
From: Boyuan Zhang
Subject: [PATCH 06/12] st/va: move H264 enc functions into separate file
Signed-off-by: Boyuan Zhang
---
src/gallium/state_trackers/va/Makefile.sources | 1 +
src/gallium/state_trackers/va/meson
https://lists.freedesktop.org/archives/mesa-dev/2018-January/183484.html
Regards,
Boyuan
-Original Message-
From: Emil Velikov [mailto:emil.l.veli...@gmail.com]
Sent: January-24-18 8:38 AM
To: Zhang, Boyuan; ML mesa-stable
Cc: ML mesa-dev
Subject: Re: [Mesa-dev] [PATCH 1/2] radeon/vcn: add
> Am 09.12.2017 um 00:33 schrieb boyuan.zh...@amd.com:
>> From: Boyuan Zhang
>>
>> Remove is_idr flag, and use idr_pic_flag provided by vaapi directly
>>
>> Signed-off-by: Boyuan Zhang
>
> Reviewed-by: Christian König for this one and
> patch #3.
>
> But where is patch #1 in this series?
Patch
Am 04.12.2017 um 21:12 schrieb Zhang, Boyuan:
>>> Am 30.11.2017 um 22:18 schrieb Leo Liu:
>>>>
>>>> On 11/30/2017 04:12 PM, boyuan.zh...@amd.com wrote:
>>>>> From: Boyuan Zhang
>>>>>
>>>>> Vaapi encode interface provide
> Am 30.11.2017 um 22:18 schrieb Leo Liu:
>>
>>
>> On 11/30/2017 04:12 PM, boyuan.zh...@amd.com wrote:
>>> From: Boyuan Zhang
>>>
>>> Vaapi encode interface provides idr frame flags, where omx interface
>>> doesn't.
>>> Therefore, change to use picture type to determine idr frame, which
>>> will
If there is no objection, the patches will be pushed by the end of the week.
Thanks,
Boyuan
-Original Message-
From: Zhang, Boyuan
Sent: November-08-17 1:08 PM
To: mesa-dev@lists.freedesktop.org
Cc: alexdeuc...@gmail.com; dy...@pnwbakers.com; mar...@gmail.com;
ckoenig.leichtzumer
Zhang, Boyuan wrote:
>>
>> On 14/11/17 10:53, Andy Furniss wrote:
>>>> Zhang, Boyuan wrote:
>>>>>
>>>>>
>>>>> -Original Message-
>>>>> From: Zhang, Boyuan
>>>>> Sent: November-13-17 11:41
On 14/11/17 10:53, Andy Furniss wrote:
>> Zhang, Boyuan wrote:
>>>
>>>
>>> -Original Message-
>>> From: Zhang, Boyuan
>>> Sent: November-13-17 11:41 AM
>>> To: Andy Furniss; Koenig, Christian; Mark Thompson;
>>> me
-Original Message-
From: Zhang, Boyuan
Sent: November-13-17 11:41 AM
To: Andy Furniss; Koenig, Christian; Mark Thompson;
mesa-dev@lists.freedesktop.org
Subject: RE: [Mesa-dev] [PATCH 10/18] radeon/vcn: add encode header
implementations
Zhang, Boyuan wrote:
>>>>> d
Zhang, Boyuan wrote:
>>>>> diff --git a/src/gallium/drivers/radeon/radeon_vcn_enc_1_2.c
>>>>> b/src/gallium/drivers/radeon/radeon_vcn_enc_1_2.c
>>>>> index 5170c67..c6dc420 100644
>>>>> --- a/src/gallium/drivers/radeon/radeon_vcn_enc_1_2
-Original Message-
From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of
Christian König
Sent: November-09-17 12:19 PM
To: Mark Thompson; mesa-dev@lists.freedesktop.org
Subject: Re: [Mesa-dev] [PATCH 10/18] radeon/vcn: add encode header
implementations
Am 09.11.20
From: Boyuan Zhang
Implement encoding of sps, pps, and silce headers using the newly added h.264
header coding descriptors functions based on h.264 specs.
Signed-off-by: Boyuan Zhang
---
src/gallium/drivers/radeon/radeon_vcn_enc.h | 1 +
src/gallium/drivers/radeon/radeon_vcn_enc_1_2.c |
Oops, thanks for pointing out. Fixed in new patch sets.
Regards,
Boyuan
-Original Message-
From: Marek Olšák [mailto:mar...@gmail.com]
Sent: November-08-17 11:53 AM
To: Zhang, Boyuan
Cc: mesa-dev@lists.freedesktop.org
Subject: Re: [Mesa-dev] [PATCH 03/18] radeon/common: add vcn enc ip
Thanks for pointing out, fixed in new patch sets.
Regards,
Boyuan
-Original Message-
From: Dylan Baker [mailto:dy...@pnwbakers.com]
Sent: November-07-17 5:59 PM
To: Zhang, Boyuan; mesa-dev@lists.freedesktop.org
Subject: Re: [Mesa-dev] [PATCH 07/18] radeon/vcn: add common encode part
- Added simple descriptions for all patches.
- Fixed all typos.
- Agreed and changed all types in radeon_vcn_enc.h to uintX_t/intX_t
Thanks,
Boyuan
-Original Message-
From: Alex Deucher [mailto:alexdeuc...@gmail.com]
Sent: November-07-17 5:42 PM
To: Zhang, Boyuan
Cc: mesa-dev
Oops, I thought I did it in previous email. Sorry about that. Patches are
Reviewed-and-tested-by: Boyuan Zhang
Regards,
Boyuan
From: Julien Isorce [mailto:julien.iso...@gmail.com]
Sent: August-10-17 11:37 AM
To: Christian König
Cc: Zhang, Boyuan; Liu, Leo; Andy Furniss; Koenig, Christian;
mesa
The code looks good to me. I also did a few local vaapi-enc tests and confirmed
that patch works fine.
Regards,
Boyuan
-Original Message-
From: Liu, Leo
Sent: July-26-17 12:01 PM
To: Andy Furniss; Koenig, Christian; Julien Isorce;
mesa-dev@lists.freedesktop.org; Zhang, Boyuan
Subject
information for reproduction? e.g. the clips and commands that can
reproduce the issue. Does this issue only happen after enabling dual instance
patch?
Regards,
Boyuan
-Original Message-
From: Andy Furniss [mailto:adf.li...@gmail.com]
Sent: October-03-16 7:35 AM
To: Zhang, B
h for real life cases, right?
Regards,
Boyuan
-Original Message-
From: Andy Furniss [mailto:adf.li...@gmail.com]
Sent: September-25-16 6:46 AM
To: Liu, Leo; Christian König; Zhang, Boyuan; mesa-dev@lists.freedesktop.org
Subject: Re: [Mesa-dev] [PATCH] st/va: enable vbr rate control for
Hi Andy,
I verified the bug. You are correct. The u and v are inversed. I checked your
patch, and confirmed it fixes the issue. Patch is Reviewed-by: Boyuan Zhang
Thanks a lot for the help!
Regards,
Boyuan
From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of
bugzilla-d
To: Koenig, Christian; Julien Isorce; mesa-dev@lists.freedesktop.org
Cc: mesa-sta...@lists.freedesktop.org; Zhang, Boyuan; Julien Isorce
Subject: Re: [PATCH] st/va: also honors interlaced preference when providing a
video format
On 09/08/2016 03:50 AM, Christian König wrote:
> Am 08.09.2016 um
Hi Eric,
Thanks for catching it. The patch is Reviewed-by: Boyuan Zhang
Regards,
Boyuan
-Original Message-
From: Eric Engestrom [mailto:eric.engest...@imgtec.com]
Sent: August-22-16 12:17 PM
To: Zhang, Boyuan
Cc: mesa-dev@lists.freedesktop.org; Koenig, Christian; Eric Engestrom
Patch is Reviewed-by: Boyuan Zhang
Regards,
Boyuan
-Original Message-
From: Eric Engestrom [mailto:e...@engestrom.ch]
Sent: August-21-16 5:12 PM
To: mesa-dev@lists.freedesktop.org
Cc: Zhang, Boyuan; Koenig, Christian; Eric Engestrom
Subject: [PATCH mesa] st/va: add missing mutex_unlock
To: mesa-dev@lists.freedesktop.org
Cc: Zhang, Boyuan
Subject: [PATCH 0/2] st/va: minor clean-ups
Hey,
just noticed a duplicate call to context->decoder->end_frame() while looking
through the recent changes. This is just a trivial clean-up and no functional
change is intended. And while
Patch is Reviewed-by: Boyuan Zhang
Regards,
Boyuan
-Original Message-
From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of Kai
Wasserbäch
Sent: August-20-16 12:15 PM
To: mesa-dev@lists.freedesktop.org
Subject: [Mesa-dev] [PATCH 2/2] st/va: Remove unused variable c
Patch is Reviewed-by: Boyuan Zhang
Regards,
Boyuan
-Original Message-
From: Kai Wasserbäch [mailto:k...@dev.carbon-project.org]
Sent: August-20-16 12:15 PM
To: mesa-dev@lists.freedesktop.org
Cc: Zhang, Boyuan
Subject: [PATCH 1/2] st/va: Remove else case in vlVaEndPicture() made
essed with the performance improvement in future.
Please let me know whether this patch set is good enough for pushing to
upstream?
Regards,
Boyuan
-Original Message-
From: Andy Furniss [mailto:adf.li...@gmail.com]
Sent: July-21-16 8:57 AM
To: Zhang, Boyuan; 'Christian K
...@lists.freedesktop.org] On Behalf Of
Zhang, Boyuan
Sent: July-21-16 10:52 AM
To: 'Christian König'; mesa-dev@lists.freedesktop.org
Subject: Re: [Mesa-dev] [PATCH 05/12] st/va: add encode entrypoint
>> @@ -150,7 +167,18 @@ vlVaCreateConfig(VADriverContextP ctx, VAProfile
>> profile, VAEntrypoin
I'm totally fine with it. Thanks for the suggestion.
Regards,
Boyuan
-Original Message-
From: Christian König [mailto:deathsim...@vodafone.de]
Sent: July-21-16 4:46 AM
To: Zhang, Boyuan; mesa-dev@lists.freedesktop.org
Cc: adf.li...@gmail.com
Subject: Re: [PATCH 05/12] st/va: add encode entrypoi
4:49 AM
To: Zhang, Boyuan; mesa-dev@lists.freedesktop.org
Cc: adf.li...@gmail.com
Subject: Re: [PATCH 09/12] st/va: add functions for VAAPI encode
Am 20.07.2016 um 06:21 schrieb Zhang, Boyuan:
>> - context->decoder->begin_frame(context->decoder, context->target,
>>
working. I will update with you
once we make progress.
Regards,
Boyuan
-Original Message-
From: Andy Furniss [mailto:adf.li...@gmail.com]
Sent: July-20-16 5:31 AM
To: Zhang, Boyuan; 'Christian König'; mesa-dev@lists.freedesktop.org
Subject: Re: [PATCH 06/11] vl/util: add c
est shown, gstreamer will not work at all if we don't
expose slice encoding. Do you have any suggestions how we should do for this
situation?
Regards,
Boyuan
From: Christian König [mailto:deathsim...@vodafone.de]
Sent: July-20-16 4:48 AM
To: Zhang, Boyuan; mesa-dev@lists.freedesktop.org
Cc
, and won't be included in this bring-up
patch set.
Regards,
Boyuan
From: Andy Furniss
Sent: July 19, 2016 2:39:44 PM
To: Zhang, Boyuan; 'Christian König'; mesa-dev@lists.freedesktop.org
Subject: Re: [PATCH 06/11] vl/util: add copy func f
hy I delay both calls to end_frame where we get all necessary values.
Regards,
Boyuan
________
From: Christian König
Sent: July 19, 2016 4:55:43 AM
To: Zhang, Boyuan; mesa-dev@lists.freedesktop.org
Cc: adf.li...@gmail.com
Subject: Re: [PATCH 09/12] st/va: add functions
n't enable slice level encode,
it will fail the call and report h264 encode is not supported. If we enable
both, it will still use picture level encode. That's why I put both here.
Regards,
Boyuan
From: Christian König
Sent: July 19, 2016 4:52 AM
To: Zh
ock/unlock. Please take a look at the new patch
set, and feel free to give any suggestions/comments. Thanks!
Regards,
Boyuan
-Original Message-
From: Christian König [mailto:deathsim...@vodafone.de]
Sent: July-18-16 10:15 AM
To: Zhang, Boyuan; mesa-dev@lists.freedesktop.org
Cc: adf
: July-15-16 1:32 PM
To: Zhang, Boyuan; Christian König; mesa-dev@lists.freedesktop.org
Subject: Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode
Zhang, Boyuan wrote:
> Hi Andy,
>
> Thanks for the testing. I will look into the memory issue. For the cbr
> test, what was
-16 9:42 AM
To: Christian König; Zhang, Boyuan; mesa-dev@lists.freedesktop.org
Subject: Re: [Mesa-dev] [PATCH 01/12] vl: add parameters for VAAPI encode
Christian König wrote:
> Am 05.07.2016 um 13:17 schrieb Christian König:
>> Am 01.07.2016 um 18:18 schrieb Andy Furniss:
>>> Chr
Fixed both subject and coding style in newly submitted patch set.
Regards,
Boyuan
-Original Message-
From: Christian König [mailto:deathsim...@vodafone.de]
Sent: July-14-16 3:56 AM
To: Zhang, Boyuan; mesa-dev@lists.freedesktop.org
Subject: Re: [PATCH 06/11] st/va: add copy function for
Thanks for the suggestion Emil. I modified each un-submitted patch based on the
article you provided. Please see the newly submitted patch set.
Regards,
Boyuan
-Original Message-
From: Emil Velikov [mailto:emil.l.veli...@gmail.com]
Sent: July-14-16 1:07 PM
To: Zhang, Boyuan
Cc
}
}
break;
-Original Message-
From: Christian König [mailto:deathsim...@vodafone.de]
Sent: July-14-16 4:07 AM
To: Zhang, Boyuan; mesa-dev@lists.freedesktop.org
Subject: Re: [PATCH 02/11] vl: add entry point
Am 14.07.2016 um 00:51 schrieb Boyuan Zhang:
> Add entry p
As discussed, we will improve this in a separate patch later.
Regards,
Boyuan
From: Christian König
Sent: July 1, 2016 9:03:13 AM
To: Zhang, Boyuan; mesa-dev@lists.freedesktop.org
Subject: Re: [PATCH 08/12] st/va: add functions for VAAPI encode
Am 30.06.2016
atch set.
For IYUV case, it's already converted to yv12 (by swapping u and v field)
before the colorspace conversion call, so IYUV case should also work.
Regards,
Boyuan
From: Christian König
Sent: July 1, 2016 8:51 AM
To: Zhang, Boyuan; mesa-dev@l
or
not. Since VCE needs this information, so I think we still need to add this
flag.
Regards,
Boyuan
From: Christian König
Sent: July 1, 2016 8:21 AM
To: Zhang, Boyuan; mesa-dev@lists.freedesktop.org
Subject: Re: [PATCH 01/12] vl: add parameters for VAAPI encode
alues in version
specific calls. Please see the new patch set I just sent.
-Original Message-
From: Christian König [mailto:deathsim...@vodafone.de]
Sent: June-22-16 11:55 AM
To: Zhang, Boyuan; mesa-dev@lists.freedesktop.org
Subject: Re: [PATCH 3/3] radeon/vce: use vce structures for v
Agree, please see the new patch set I just sent.
-Original Message-
From: Christian König [mailto:deathsim...@vodafone.de]
Sent: June-22-16 3:29 AM
To: Zhang, Boyuan; mesa-dev@lists.freedesktop.org
Subject: Re: [PATCH 2/3] vl: add parameters for VAAPI encode
Am 21.06.2016 um 16:50
une-22-16 3:34 AM
To: Zhang, Boyuan; mesa-dev@lists.freedesktop.org
Subject: Re: [PATCH 3/3] radeon/vce: use vce structures for vce_52 firmware
Am 21.06.2016 um 16:50 schrieb Boyuan Zhang:
> Signed-off-by: Boyuan Zhang
> ---
> src/gallium/drivers/radeon/radeon_vce.c| 171 +++
&
gone with this patch. At the same time, add an environmental
variable to allow user to decide whether to use this patch.
Regards,
Boyuan
-Original Message-
From: Liu, Leo
Sent: November-05-15 10:15 PM
To: Emil Velikov; Zhang, Boyuan
Cc: ML mesa-dev
Subject: RE: [Mesa-dev] [PATCH] st/va
59 matches
Mail list logo