On Mon, Nov 7, 2016 at 12:32 PM, Nicolai Hähnle wrote:
> Looks good to me as well, and pushed! Thanks for the respin and sorry it
> took so long.
You are very welcome. No apology necessary.
Thank you for your due diligence and prior feedback.
--
Steven Toth - Kernel Lab
be cc 13.0 ? It's buggy with 13.0 and it will be a nice fix
I'm the new guy, so I don't get to make that call, but given the
nature of the fix (for some applications multiple multiple surfaces) -
I'd certainly recommend it.
--
Steven Toth - Kernel Labs
http://www.kernellabs.com
>> A humble ping on this and the two others.
>>
>> - Steve
>>
>
> Series looks OK to me.
>
> Reviewed-by: Brian Paul
>
> Need me to push these for you?
>
> -Brian
>
That would be a helpful, yes please.
I think they fell through the cracks af
On Mon, Oct 24, 2016 at 10:10 AM, Steven Toth wrote:
> In the event that multiple threads attempt to install a graph
> concurrently, protect the shared list.
>
> Signed-off-by: Steven Toth
A humble ping on this and the two others.
- Steve
--
Steven Toth - Kern
On Mon, Oct 24, 2016 at 10:10 AM, Steven Toth wrote:
> We're missing the closedir() to the matching opendir().
>
> Signed-off-by: Steven Toth
A humble ping on this and the two others.
- Steve
--
Steven Toth - Kernel Labs
http://www.kernellabs.com
> ---
> src/g
On Mon, Oct 24, 2016 at 10:10 AM, Steven Toth wrote:
> Instead of trying to maintain a reference counted list of valid HUD
> objects, and freeing them accordingly, creating race conditions
> between unanticipated multiple threads, simply accept they're
> allocated once and nev
In the event that multiple threads attempt to install a graph
concurrently, protect the shared list.
Signed-off-by: Steven Toth
---
src/gallium/auxiliary/hud/hud_cpufreq.c | 12 ++--
src/gallium/auxiliary/hud/hud_diskstat.c | 13 +++--
src/gallium/auxiliary/hud
We're missing the closedir() to the matching opendir().
Signed-off-by: Steven Toth
---
src/gallium/auxiliary/hud/hud_cpufreq.c | 1 +
src/gallium/auxiliary/hud/hud_diskstat.c | 5 -
src/gallium/auxiliary/hud/hud_nic.c | 1 +
3 files changed, 6 insertions(+), 1 deletion(-)
diff
ce between multiple threads, so accept
they're always available for use.
Signed-off-by: Steven Toth
---
src/gallium/auxiliary/hud/hud_cpufreq.c | 13 -
src/gallium/auxiliary/hud/hud_diskstat.c | 13 -
src/gallium/auxiliary/hud/hud_nic.c | 13 ---
>> + if (!pdir) {
>> + close(dir);
>
>
> Shouldn't this be closedir(dir)?
Whoops, Thank you for catching this.
I'll re-issue the patch-set momentarily with this adjustment.
--
Steven Toth - Kernel Labs
http://www.kernellabs.com
_
ce between multiple threads, so accept
they're always available for use.
Signed-off-by: Steven Toth
---
src/gallium/auxiliary/hud/hud_cpufreq.c | 13 -
src/gallium/auxiliary/hud/hud_diskstat.c | 13 -
src/gallium/auxiliary/hud/hud_nic.c | 13 ---
We're missing the closedir() to the matching opendir().
Signed-off-by: Steven Toth
---
src/gallium/auxiliary/hud/hud_cpufreq.c | 1 +
src/gallium/auxiliary/hud/hud_diskstat.c | 5 -
src/gallium/auxiliary/hud/hud_nic.c | 1 +
3 files changed, 6 insertions(+), 1 deletion(-)
diff
In the event that multiple threads attempt to install a graph
concurrently, protect the shared list.
Signed-off-by: Steven Toth
---
src/gallium/auxiliary/hud/hud_cpufreq.c | 12 ++--
src/gallium/auxiliary/hud/hud_diskstat.c | 13 +++--
src/gallium/auxiliary/hud
order, a use case not witnessed
with glxgears.
These patches:
1. mutex protect the internal object lists.
2. reference count object access for destruction purposes.
Patchset tested with glxgears/demo and unigine.
Signed-off-by: Steven Toth
---
src/gallium/auxiliary/hud/hud_cpufreq.c | 33
humb is that functions associated to a
Yep. Done.
> Thanks for looking into this!
Thank you for the review. I should have a patch available shortly.
--
Steven Toth - Kernel Labs
http://www.kernellabs.com
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
'd when no more callers require them.
Patchset was regression tested again with Unigine,
glxgears and glxdemo.
Tested-By: Christoph Haag
Signed-off-by: Steven Toth
---
src/gallium/auxiliary/hud/hud_cpufreq.c | 8 ++--
src/gallium/auxiliary/hud/hud_diskstat.c | 10 +++-
bugzilla account tomorrow (monday) and repo/remedy this issue.
Thanks for raising it.
--
Steven Toth - Kernel Labs
http://www.kernellabs.com
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
No longer required.
Signed-off-by: Steven Toth
---
src/gallium/auxiliary/hud/hud_cpufreq.c | 9 -
src/gallium/auxiliary/hud/hud_diskstat.c | 8
src/gallium/auxiliary/hud/hud_nic.c | 16
src/gallium/auxiliary/hud/hud_sensors_temp.c | 19
LAGS="-lsensors"
>> +else
>> +LIBSENSORS_LDFLAGS=""
>> +fi
>> +AC_SUBST(LIBSENSORS_LDFLAGS)
> You want the LIBS variable, LDFLAGS is something else.
Ahh. hmm, OK. I'll look into this.
>
>
>> endif
>>
>>
>
> Reviewed-by: Brian Paul
>
> and pushed to master. Thanks.
Thank you Brian.
--
Steven Toth - Kernel Labs
http://www.kernellabs.com
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Detect all of the CPUs in the system. Expose metrics
for min, max and current frequency in Hz.
Signed-off-by: Steven Toth
---
src/gallium/auxiliary/Makefile.sources | 1 +
src/gallium/auxiliary/hud/hud_context.c | 13 ++
src/gallium/auxiliary/hud/hud_cpufreq.c | 266
Implement support for power based sensors, reporting units in
milli-watts and watts.
Also, minor cleanup - change the related if block to a switch.
Tested with two different power sensors, including the nouveau
'power1' sensors on a GTX950 card.
Signed-off-by: Steven Toth
---
s
change is opt out by default.
Signed-off-by: Steven Toth
---
configure.ac | 42 +++
src/gallium/auxiliary/Makefile.am| 2 +
src/gallium/auxiliary/Makefile.sources | 3 +
src/gallium/auxiliary/hud/hud_context.c | 73 +
src/gallium
> I found just a few more nit-picks below. With those fixed (if appropriate),
> Reviewed-by: Brian Paul
>
> I'll push the patch for you then.
All reasonable requests, thank you.
I'll take care of these later this afternoon.
--
Steven Toth - Kernel Labs
htt
face RX/TX transfer statistics as a percentage
of the overall NIC speed.
3. lmsensor power, voltage and temperature sensors.
The lmsensor changes makes a dependency on libsensors so support
for the change is opt out by default.
Signed-off-by: Steven Toth
---
co
On Tue, Sep 27, 2016 at 8:03 PM, Brian Paul wrote:
> On 09/27/2016 05:17 PM, Steven Toth wrote:
>>
>> On Fri, Sep 23, 2016 at 12:19 PM, Brian Paul wrote:
>>>
>>> Hi Steven,
>>>
>>> I did a more thorough review per your request...
>>
>&
else if (sscanf(name, "sensors_temp_cu-%s", arg_name) == 1) {
> hud_sensors_temp_graph_install(pane, arg_name, ...
>
> as you did in other places?
Ahh, I did indeed misunderstand your comment.
You are correct, an obvious oversight on my part. I've take
c - which is all it cares
about.
I'm happy to implement whatever the project recommends, so are you
suggesting instead:
#define SOMEPREFIX "sensors_temp_cu-"
then
hud_sensors_temp_graph_install(pane, &name[sizeof(SOMEPREFIX - 1)]
Or, have I misunderstood y
V5: Feedback based on peer review
convert sprintf to snprintf
convert char * to const char *
int arg converted to bool
Func changes to take a filename vs a larger struct.
omit the space between '*' and the param name.
Signed-off-by: Steven Toth
---
src/gallium/auxiliary/hud/hud_
changes makes a dependency on libsensors so support
for the change is opt out by default.
Signed-off-by: Steven Toth
---
configure.ac | 42 +++
src/gallium/auxiliary/Makefile.am| 2 +
src/gallium/auxiliary/Makefile.sources | 3 +
src/gallium
RX/TX transfer statistics as a percentage
>> of the overall NIC speed.
>> 3. lmsensor power, voltage and temperature sensors.
>>
>> The lmsensor changes makes a dependency on libsensors so support
>> so the change is opt out by default.
>>
>> Signed-off-by: Ste
> V3: Flatten the entire patchset ready for the ML
Compile tested on Windows via AppVeyor
Patches tested in various ./configure disable/enable modes on Ubuntu
16.04, 4.5.7 kernel on 32bit.
Many thanks to everyone who provided feedback.
--
Steven Toth - Kernel Labs
http://www.kernellabs.
support
so the change is opt out by default.
Signed-off-by: Steven Toth
---
configure.ac | 42 +++
src/gallium/auxiliary/Makefile.am| 2 +
src/gallium/auxiliary/Makefile.sources | 3 +
src/gallium/auxiliary/hud/hud_context.c | 73
>> It looks like the winflexbison URL changed some time ago. But this
>> didn't cause any build failures because the ZIP was being recovered from
>> the cache.
>>
>> I'll look into it.
>>
>> Jose
>
>
> It looks the archive was moved into a old_versions subdir.
>
> The attached patch should fix it.
ds enabled. So, not sure why others aren't
seeing this. Feel free to point out any dumb mistake I've made.
FYI.
--
Steven Toth - Kernel Labs
http://www.kernellabs.com
+1.646.355.8490
___
mesa-dev mailing list
mesa-dev@lists.f
hanks again.
>>
> You're welcome and please don't let my 'lack of interest' deter you.
> There's plenty of people who are glad to see/use your work.
Deterred, not at all. I thank you for your feedback.
Yes, it will be good to finally share the code with ot
> On 12 September 2016 at 19:33, Steven Toth wrote:
>> Three new features:
>> 1. Disk/block I/O device read/write stats MB/ps.
>> 2. Network Interface RX/TX transfer statistics as a percentage
>>of the overall NIC speed.
>> 3. lmsensor power, voltage and tempe
> well it won't for your GPU, it is currently Fermi (GF100+) only.
>
> I guess I will add support for it later then
>
ok.
I'm not too familiar with the nvidia architectures. Should a GTX 950
card on a 4.6+ kernel expose those newer features?
--
Steven T
; Well in the end I could also try to extend your patch and give you my
> changes on top of yours.
Thanks for the feedback.
I'm running 4.5.7. I'll run up a 4.6 kernel today and report back.
If the power sensor appears then I'll add a new patch.
--
Steven Toth - Kernel Labs
h
(emerg = +135.0°C, hyst = +5.0°C)
In fact, I don't seem to have any dev boxes that expose power. That's a odd.
If you want to recommend a specific nvidia card/model that you know
for certain exposes these features then I'll see what I can do.
--
Steven Toth - Kernel Labs
h
> Can you enclose all the unix-specific parts in #ifdef PIPE_OS_UNIX to allow
> this to build for Windows?
>
> -Brian
Brian, thank you for your feedback.
Whoops! Yes, I'll take care of this.
--
Steven Toth - Kernel Labs
http://www.kernellabs.co
es recommended. That being
said, I'm not sure I fully understand what you mean. Can you please be
more specific?
If the nouveau driver is exposing a specific set of sensors that you'd
like me to test, I'd be happy to do this and report back or adapt
the patchset according
opt out by default.
Signed-off-by: Steven Toth
---
configure.ac | 20 ++
src/gallium/auxiliary/Makefile.am| 4 +
src/gallium/auxiliary/Makefile.sources | 3 +
src/gallium/auxiliary/hud/hud_context.c | 67
src/gallium/auxiliary/hud
43 matches
Mail list logo
