On 06/10/2016 05:20 PM, Ilia Mirkin wrote:
It's pretty easy for me to fix up before I apply it too, but if I "git
am" your email, it'll be attributed to the one you sent it from,
unless that From line is there as line 1 of the email body. Just let
me know if you want me to fix it up. Despite the
On 06/10/2016 12:09 PM, Eric Engestrom wrote:
On Thu, Jun 09, 2016 at 05:13:20PM +0200, Stephan Bergmann wrote:
Since you didn't send this patch from your primary email account,
you might want to add this line here, otherwise the author will be
"stephan.bergmann.second...@googlemail.c
...when Function::domTree is created as DominatorTree in Function::convertToSSA
(src/gallium/drivers/nouveau/codegen/nv50_ir_ssa.cpp) but destroyed only as base
Graph in ~Function (src/gallium/drivers/nouveau/codegen/nv50_ir_bb.cpp).
---
src/gallium/drivers/nouveau/codegen/nv50_ir_graph.h | 2 +-
On 06/09/2016 05:01 PM, Ilia Mirkin wrote:
Is this all because Graph doesn't have a virtual destructor? We don't
construct/destruct those too often, I'd much rather just make it
virtual rather than moving DominatorTree.
Yes, that of course also works. Corresponding patch coming.
__
...when Function::domTree is created as DominatorTree in Function::convertToSSA
(src/gallium/drivers/nouveau/codegen/nv50_ir_ssa.cpp) but destroyed only as base
Graph in ~Function (src/gallium/drivers/nouveau/codegen/nv50_ir_bb.cpp).
---
src/gallium/drivers/nouveau/codegen/nv50_ir.h | 37
see attached 0001-Avoid-ASan-new-delete-type-mismatch.patch
>From 653d9da624c56fab05ed568133f30640b9e75b4f Mon Sep 17 00:00:00 2001
From: Stephan Bergmann
Date: Thu, 9 Jun 2016 15:21:46 +0200
Subject: [PATCH] Avoid ASan new-delete-type-mismatch
...when Function::domTree is created
