Re: [PATCH] drm/fourcc: add LINEAR modifiers with an exact pitch alignment

2025-01-22 Thread Simona Vetter
On Tue, Jan 21, 2025 at 02:21:57PM -0500, Marek Olšák wrote: > On Mon, Jan 20, 2025 at 1:41 PM Simona Vetter > wrote: > > > On Mon, Jan 20, 2025 at 08:58:20AM +0100, Thomas Zimmermann wrote: > > > Hi > > > > > > > > > Am 18.01.25 um 03:37

Re: [PATCH] drm/fourcc: add LINEAR modifiers with an exact pitch alignment

2025-01-20 Thread Simona Vetter
re could be shared code that dtrt by just looking at the modifier list. -Sima > Best regards > Thomas > > > > > Marek > > > > On Fri, Jan 17, 2025 at 9:18 AM Simona Vetter > > wrote: > > > > On Wed, Jan 15, 2025 at 12:20:07PM +, Dan

Re: [PATCH] drm/fourcc: add LINEAR modifiers with an exact pitch alignment

2025-01-17 Thread Simona Vetter
y can happen. > I think I've just talked myself into the position that passing > allocator constraints together with modifiers is the only way to > actually solve this problem, at least without creating the sort of > technical debt that meant we spent years fixing up implicit/explic

Re: [PATCH] drm/fourcc: add LINEAR modifiers with an exact pitch alignment

2025-01-15 Thread Simona Vetter
reedom regarding placement. Drivers can expose > > whatever they want within that definition, even exposing only 1 linear > > modifier is OK. Then, you can look at modifiers of other drivers if you > > want to find commonalities. > > > > > > DRM_FORMAT_MOD_L

Re: [PATCH] drm/fourcc: add LINEAR modifiers with an exact pitch alignment

2024-12-20 Thread Simona Vetter
gt; modifiers and replace them with something that works. I think Daniel's forward compatibility plan is more solid than trying to deprecate LINEAR itself, that seems like too much an uphill battle to me. -Sima -- Simona Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH] drm/fourcc: add LINEAR modifiers with an exact pitch alignment

2024-12-20 Thread Simona Vetter
rucial part, because adding modifiers without an actual use-case that they fix is just asking for more future trouble I think. -Sima > > > -- > Earthling Michel Dänzer \GNOME / Xwayland / Mesa developer > https://redhat.com \ Libre software enthusiast -- Simona Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [PATCH] drm/fourcc: add LINEAR modifiers with an exact pitch alignment

2024-12-19 Thread Simona Vetter
On Thu, Dec 19, 2024 at 09:02:27AM +, Daniel Stone wrote: > On Wed, 18 Dec 2024 at 10:32, Brian Starkey wrote: > > On Wed, Dec 18, 2024 at 11:24:58AM +0000, Simona Vetter wrote: > > > For that reason I think linear modifiers with explicit pitch/size > > > align

Re: [PATCH] drm/fourcc: add LINEAR modifiers with an exact pitch alignment

2024-12-18 Thread Simona Vetter
quirements are generally implied. Mostly by stuff like tile size, but there's others where the hw requirement flat out is that the buffer must have a power-of-two stride (and maybe we should document these when they pop up, but the only one I know of are the legacy i915 modifiers, which are

Re: [PATCH] drm/fourcc: add LINEAR modifiers with an exact pitch alignment

2024-12-18 Thread Simona Vetter
On Mon, Dec 16, 2024 at 04:58:20PM -0500, Marek Olšák wrote: > On Mon, Dec 16, 2024 at 9:53 AM Simona Vetter > wrote: > > > On Mon, Dec 16, 2024 at 11:46:13AM +0100, Lucas Stach wrote: > > > Am Montag, dem 16.12.2024 um 10:27 +0100 schrieb Michel Dänzer: > > > &

Re: [PATCH] drm/fourcc: add LINEAR modifiers with an exact pitch alignment

2024-12-16 Thread Simona Vetter
ottom (yeah some hw overscans and gets pissed if there's not memory there). So I think it's best to go overboard here with verbosity. There's also really funny stuff like power-of-two alignment and things like that, but I guess we'll get there if that's ever needed. That's also why I think we don't need to add all possible linear modifiers from the start, unless there's maybe too much confusion with stuff like "exactly 64b aligned pitch" and "at least 64b aligned pitch, but you can add lots of padding if you feel like". -""ma > > Regards, > Lucas -- Simona Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch