Re: [Mesa-dev] [PATCH] Mesa prog_optimize.c: solve glsl2 regression

2010-08-17 Thread Segovia, Benjamin
BTW, the patch is a real fix not a workaround. This is what has to be done. Ben From: mesa-dev-bounces+benjamin.segovia=intel@lists.freedesktop.org [mesa-dev-bounces+benjamin.segovia=intel@lists.freedesktop.org] On Behalf Of Segovia, Benjamin

Re: [Mesa-dev] [PATCH] Mesa prog_optimize.c: solve glsl2 regression

2010-08-17 Thread Segovia, Benjamin
Yes, absolutely. The code was just wrong. Ben From: Ian Romanick [...@freedesktop.org] Sent: Tuesday, August 17, 2010 1:09 PM To: Segovia, Benjamin Cc: mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [PATCH] Mesa prog_optimize.c: solve glsl2

Re: [Mesa-dev] Merge of glsl2 branch to master

2010-08-16 Thread Segovia, Benjamin
-dev-bounces+benjamin.segovia=intel@lists.freedesktop.org] On Behalf Of Segovia, Benjamin [benjamin.sego...@intel.com] Sent: Monday, August 16, 2010 8:37 PM To: Ian Romanick; mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] Merge of glsl2 branch to master I am looking at the regression for

Re: [Mesa-dev] Merge of glsl2 branch to master

2010-08-16 Thread Segovia, Benjamin
I am looking at the regression for this test Ben From: Ian Romanick [...@freedesktop.org] Sent: Monday, August 16, 2010 8:17 PM To: mesa-dev@lists.freedesktop.org; Segovia, Benjamin Subject: Re: [Mesa-dev] Merge of glsl2 branch to master -BEGIN PGP

Re: [Mesa-dev] [PATCH] Mesa prog_optimize.c: better optimization for Mesa programs

2010-08-13 Thread Segovia, Benjamin
Just looked at your modifications. I will try to be more GL/mesa style compliant for the variable types. Thanks for your help Ben From: Brian Paul [bri...@vmware.com] Sent: Friday, August 13, 2010 4:01 PM To: Segovia, Benjamin Cc: mesa-dev

Re: [Mesa-dev] [PATCH] Mesa prog_optimize.c: better optimization for Mesa programs

2010-08-11 Thread Segovia, Benjamin
:34 PM To: Segovia, Benjamin Cc: mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [PATCH] Mesa prog_optimize.c: better optimization for Mesa programs On Wed, Aug 11, 2010 at 7:12 PM, Brian Paul wrote: > I'm just reviewing the patch again and doing some testing. I'll > pr

Re: [Mesa-dev] [PATCH] Mesa prog_optimize.c: better optimization for Mesa programs

2010-08-11 Thread Segovia, Benjamin
Hello all, is there actually any issue with the patch for the commit? Cheers, Ben From: Segovia, Benjamin Sent: Tuesday, July 27, 2010 7:11 PM To: Segovia, Benjamin; mesa-dev@lists.freedesktop.org Subject: RE: [PATCH] Mesa prog_optimize.c: better

Re: [Mesa-dev] [PATCH] Mesa prog_optimize.c: better optimization for Mesa programs

2010-07-27 Thread Segovia, Benjamin
I made a new patch.It was simpler since there were a lot of small modifications. Overall the code is simpler now with the proper use of masked operations. Thanks for your help. From: Segovia, Benjamin Sent: Tuesday, July 27, 2010 7:10 PM To: mesa-dev

Re: [Mesa-dev] [PATCH] extra masking / swizzling tests

2010-07-27 Thread Segovia, Benjamin
I did not find a piglit mailing list. Therefore, I posted here. Just tell me if there is a better way to do that. Cheers, Ben From: Segovia, Benjamin Sent: Tuesday, July 27, 2010 6:19 PM To: mesa-dev@lists.freedesktop.org Cc: Segovia, Benjamin Subject

Re: [Mesa-dev] [PATCH] Better GPU program optimization in Mesa front end

2010-07-26 Thread Segovia, Benjamin
: Segovia, Benjamin Cc: Eric Anholt; mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [PATCH] Better GPU program optimization in Mesa front end mov dst.xz src.yyww The second and y and w can be anything. Cheers Jakob. On 26 jul 2010, at 17.14, Segovia, Benjamin wrote: > So basically, >

Re: [Mesa-dev] [PATCH] Better GPU program optimization in Mesa front end

2010-07-26 Thread Segovia, Benjamin
So basically, "mov dst.xz src.yw" is impossible with mesa code? Ben From: mesa-dev-bounces+benjamin.segovia=intel@lists.freedesktop.org [mesa-dev-bounces+benjamin.segovia=intel@lists.freedesktop.org] On Behalf Of Segovia

Re: [Mesa-dev] [PATCH] Better GPU program optimization in Mesa front end

2010-07-26 Thread Segovia, Benjamin
n. - For bit_scan, bit_cound, what would you prefer? Cheers, Ben From: Eric Anholt [e...@anholt.net] Sent: Monday, July 26, 2010 6:03 PM To: Segovia, Benjamin; mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [PATCH] Better GPU program optimizati

Re: [Mesa-dev] [PATCH] i965: Improve (i.e. remove) some grf-to-mrf unnecessary moves

2010-07-26 Thread Segovia, Benjamin
vblank_mode=0. Are you sure? The performance become a disaster with it (i just tried). I am looking at intel_gpu_top from intel-gpu-tools. They sound great :) From: Eric Anholt [e...@anholt.net] Sent: Monday, July 26, 2010 5:43 PM To: Segovia, Benjamin

[Mesa-dev] i965: merging the two compilation paths for fragment programs?

2010-07-26 Thread Segovia, Benjamin
Hello all, i965 has today an issue with fp compilation. There are two passes: one for branch-free programs and one for the others. For "branch porograms", the code is generated by a _direct_ translation of the mesa gpu program. Even if with some optimizations in prog_optimize.c and the new upc

Re: [Mesa-dev] [PATCH] i965: Improve (i.e. remove) some grf-to-mrf unnecessary moves

2010-07-26 Thread Segovia, Benjamin
Thanks for the cleanup. I rushed the code yesterday and it was not quite perfect. From: Eric Anholt [e...@anholt.net] Sent: Monday, July 26, 2010 2:12 PM To: Segovia, Benjamin; mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] [PATCH] i965: Improve

Re: [Mesa-dev] [PATCH] i965: Improve (i.e. remove) some grf-to-mrf unnecessary moves

2010-07-25 Thread Segovia, Benjamin
From: Segovia, Benjamin Sent: Sunday, July 25, 2010 10:30 PM To: mesa-dev@lists.freedesktop.org Cc: Segovia, Benjamin Subject: [PATCH] i965: Improve (i.e. remove) some grf-to-mrf unnecessary moves - Several routines directly analyze the grf-to-mrf moves from the Gen

Re: [Mesa-dev] Optimizations in mesa shader compiler

2010-07-19 Thread Segovia, Benjamin
concern is about Sandybride. If you are modifying a lot of code, it may better for you to centralize the modifications in the i965 backend. Cheers, Ben From: Eric Anholt [e...@anholt.net] Sent: Monday, July 19, 2010 2:46 PM To: Segovia, Benjamin

[Mesa-dev] C extensions in Mesa

2010-07-16 Thread Segovia, Benjamin
Hello all, I did not find specific information about that. What is allowed in Mesa code base regarding C? Can I use C99 extensions (like variable not in the top of the scope, c++ comments) or gcc specific extensions (__vectors, labels as values...)? Cheers, Ben _

Re: [Mesa-dev] Optimizations in mesa shader compiler

2010-07-14 Thread Segovia, Benjamin
higher in the sw stack. Thanks for your help. I am studying the r300 code Ben From: Tom Stellard [tstel...@gmail.com] Sent: Wednesday, July 14, 2010 10:33 PM To: Segovia, Benjamin Cc: mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] Optimizations in

Re: [Mesa-dev] Optimizations in mesa shader compiler

2010-07-14 Thread Segovia, Benjamin
Ben From: Alex Deucher [alexdeuc...@gmail.com] Sent: Wednesday, July 14, 2010 4:20 PM To: Segovia, Benjamin Cc: Brian Paul; mesa-dev@lists.freedesktop.org Subject: Re: [Mesa-dev] Optimizations in mesa shader compiler On Wed, Jul 14, 2010 at 6:14 PM, Segovia, Benjamin wrote: > Hmmm, (p

Re: [Mesa-dev] Optimizations in mesa shader compiler

2010-07-14 Thread Segovia, Benjamin
heers, Ben From: mesa-dev-bounces+benjamin.segovia=intel@lists.freedesktop.org [mesa-dev-bounces+benjamin.segovia=intel@lists.freedesktop.org] On Behalf Of Segovia, Benjamin [benjamin.sego...@intel.com] Sent: Wednesday, July 14, 2010 3:15 PM To: Bri

Re: [Mesa-dev] Optimizations in mesa shader compiler

2010-07-14 Thread Segovia, Benjamin
e is built, it seems that the constant tracking for the AST construction is somehow too late to make it easy. I am looking to all that stuff anyway Cheers, Ben From: Brian Paul [bri...@vmware.com] Sent: Wednesday, July 14, 2010 12:54 PM To: Segovia, B

Re: [Mesa-dev] Optimizations in mesa shader compiler

2010-07-14 Thread Segovia, Benjamin
glsl2, optimizing the final GPU code optimization pass would be still usefull (except if glsl2 properly optimizes everything before) Ben From: Brian Paul [bri...@vmware.com] Sent: Wednesday, July 14, 2010 7:54 AM To: Segovia, Benjamin Cc: mesa-dev

Re: [Mesa-dev] Optimizations in mesa shader compiler

2010-07-13 Thread Segovia, Benjamin
includes the constant computations in the shader. Ben From: mesa-dev-bounces+benjamin.segovia=intel@lists.freedesktop.org [mesa-dev-bounces+benjamin.segovia=intel@lists.freedesktop.org] On Behalf Of Segovia, Benjamin [benjamin.sego...@intel.com

[Mesa-dev] Optimizations in mesa shader compiler

2010-07-13 Thread Segovia, Benjamin
Hello all, I just looked at the (intermediate) code produced by the shader compiler. In the last version, I did not find anything on constant propagation and constant computations. In the Intel current driver, the final gen code produces an ugly sequence of computations of constant values (know