On Fri, Aug 9, 2019 at 2:49 PM Alyssa Rosenzweig
wrote:
>
> I'm not one to care, but fwiw, spacing is inconsistent..?
Context? I guess you mean the 'madv.retained = 0;' line.
>
> > + if (!ret && !madv.retained) {
>
> What's the logic here? (What does a 0/!0 return code mean h
kernels once the
driver version bump lands, but probably not worth it given the other
driver features also being added.
Signed-off-by: Rob Herring
---
src/gallium/drivers/panfrost/pan_bo_cache.c | 21 +
src/gallium/drivers/panfrost/pan_drm.c | 4 ++--
2 files changed, 23
Sync the panfrost_drm.h UAPI header with the latest from the kernel.
This adds madvise ioctl and GPU feature params.
Signed-off-by: Rob Herring
---
include/drm-uapi/panfrost_drm.h | 61 +
1 file changed, 61 insertions(+)
diff --git a/include/drm-uapi
On Wed, Aug 7, 2019 at 2:37 AM Tomeu Vizoso wrote:
>
> Unless a BO has the EXECUTABLE flag, mark it as NOEXEC.
>
> v2: - Rework version detection (Alyssa).
>
> Signed-off-by: Tomeu Vizoso
> ---
> include/drm-uapi/panfrost_drm.h | 27 +++
Next time, I think this shou
On Fri, Aug 9, 2019 at 3:31 AM Tomeu Vizoso wrote:
>
> On Thu, 8 Aug 2019 at 16:19, Rob Herring wrote:
> >
> > On Wed, Aug 7, 2019 at 11:23 PM Tomeu Vizoso
> > wrote:
> > >
> > > On Thu, 8 Aug 2019 at 00:47, Rob Herring wrote:
> > > &g
On Wed, Aug 7, 2019 at 5:47 PM Alyssa Rosenzweig
wrote:
>
> > This is using the
> > untranslated flags, but I think it should be the 'translated_flags' as
> > those are the ones changing the allocation.
>
> It's a little more complex than that. There some hypothetical
> untranslated flags that I w
On Wed, Aug 7, 2019 at 11:23 PM Tomeu Vizoso wrote:
>
> On Thu, 8 Aug 2019 at 00:47, Rob Herring wrote:
> >
> > On Wed, Aug 7, 2019 at 2:37 AM Tomeu Vizoso
> > wrote:
> > >
> > > Instead of all shaders being stored in a single BO, have each shader in
&
On Wed, Aug 7, 2019 at 2:37 AM Tomeu Vizoso wrote:
>
> Signed-off-by: Tomeu Vizoso
> Reviewed-by: Alyssa Rosenzweig
> ---
> src/gallium/drivers/panfrost/pan_drm.c | 10 +-
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/src/gallium/drivers/panfrost/pan_drm.c
> b/src/
On Wed, Aug 7, 2019 at 2:37 AM Tomeu Vizoso wrote:
>
> Instead of all shaders being stored in a single BO, have each shader in
> its own.
>
> This removes the need for a 16MB allocation per context, and allows us
> to place transient blend shaders in BOs marked as executable (before
> they were al
ussion. Feel free to propose alternives to this solution.
>
> [1]https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/gpu/drm/drm_gem.c?h=v5.2-rc7#n318
> [2]https://cgit.freedesktop.org/drm/drm-misc/commit/drivers/gpu/drm/panfrost?id=583bbf46133c726bae277e8f4e32bfba2a52
On Wed, Jul 3, 2019 at 8:13 AM Steven Price wrote:
>
> On 03/07/2019 14:56, Boris Brezillon wrote:
> > On Wed, 3 Jul 2019 07:45:32 -0600
> > Rob Herring wrote:
> >
> >> On Wed, Jul 3, 2019 at 7:34 AM Boris Brezillon
> >> wrote:
> >>>
> &
On Fri, Mar 8, 2019 at 3:59 PM Alyssa Rosenzweig wrote:
>
> > +/**
> > + * struct drm_panfrost_wait_bo - ioctl argument for waiting for
> > + * completion of the last DRM_PANFROST_SUBMIT_CL on a BO.
>
> Nit: Should be plain DRM_PANFROST_SUBMIT, there is no CL for us.
>
> > + __s64 timeout_ns;
On Fri, Mar 8, 2019 at 3:27 AM Tomeu Vizoso wrote:
>
> Also use the raw GPU ID value to decide whether to use SFD or MFD.
>
> Signed-off-by: Tomeu Vizoso
> ---
> src/gallium/drivers/panfrost/pan_context.c | 66 ++
> src/gallium/drivers/panfrost/pan_context.h | 10
> src/
On Mon, Mar 4, 2019 at 6:43 PM Alyssa Rosenzweig wrote:
>
> Wooo!!!
>
> Seeing this patch in my inbox has been some of the best news all day!
>
> Without further ado, my (solicited?) comments:
>
> > +/* Copyright 2018, Linaro, Ltd., Rob Herring */
>
> Pleas
On Mon, Mar 4, 2019 at 1:38 PM Alyssa Rosenzweig wrote:
>
> > unsigned transient_count =
> > ctx->transient_pools[ctx->cmdstream_i].entry_index*ctx->transient_pools[0].entry_size
> > + ctx->transient_pools[ctx->cmdstream_i].entry_offset;
> > - printf("Uploaded transient %d bytes\n",
t a/include/drm-uapi/panfrost_drm.h b/include/drm-uapi/panfrost_drm.h
> new file mode 100644
> index ..d4d271e37206
> --- /dev/null
> +++ b/include/drm-uapi/panfrost_drm.h
> @@ -0,0 +1,128 @@
> +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
>
On Mon, Mar 4, 2019 at 1:35 PM Alyssa Rosenzweig wrote:
>
> > /* If set, we'll require the use of single render-target framebuffer
> > * descriptors (SFBD), for older hardware -- specifically, > If
>
> This require_sfbd field should also be set at the same time. In
> particular, we'll want a (
On Sun, Feb 3, 2019 at 9:33 PM Alyssa Rosenzweig wrote:
>
> > You should just land it and start doing in-tree development!
>
> I don't have push access, you know :P
I can push it if you don't want to go the MR route. That goes for
subsequent changes too.
Rob
_
On Fri, Jan 25, 2019 at 9:00 PM Qiang Yu wrote:
>
> Thanks Rob, I'm OK with this kmsro approach.
>
> But I have to point out that this will break XServer AIGLX:
> 1. modesetting DDX will report the display drm driver name like meson
> as DRI2 driver name
> 2. libglx.so used by xserver will look
On Thu, Jan 24, 2019 at 7:21 PM Eric Anholt wrote:
>
> Rob Herring writes:
>
> > Enable using etnaviv for KMS renderonly. This still needs KMS driver
> > name mapping to kmsro to be used automatically.
> >
> > Signed-off-by: Rob Herring
>
> >
If we can't find a driver matching by name, then use the kmsro driver.
This removes the need for needing a driver descriptor for every possible
KMS driver.
Signed-off-by: Rob Herring
---
src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c | 13 -
1 file changed, 8 insertions(
Enable using etnaviv for KMS renderonly. This still needs KMS driver
name mapping to kmsro to be used automatically.
Signed-off-by: Rob Herring
---
meson.build | 4 +--
src/gallium/meson.build | 12 +++
src/gallium/winsys/kmsro/drm
ranch is here[1].
Rob
[1] https://github.com/robherring/mesa winsys-renderonly
Eric Anholt (1):
pl111: Rename the pl111 driver to "kmsro".
Rob Herring (3):
pipe-loader: Fallback to kmsro driver when no matching driver name
found
kmsro: Add etnaviv renderonly support
Switch im
The kmsro winsys is equivalent to the imx winsys, so we can switch
to it and remove the imx one.
Signed-off-by: Rob Herring
---
Android.mk| 5 +-
Makefile.am | 2 +-
configure.ac | 14
layer used to attach a
GPU.
Acked-by: Emil Velikov
Signed-off-by: Rob Herring
---
.travis.yml | 2 +-
Android.mk | 4 ++--
Makefile.am | 2 +-
co
On Thu, Jan 24, 2019 at 9:14 AM Emil Velikov wrote:
>
> Hi all,
>
> Fwiw I'm ok with the idea, as pointed out in 2/2 as-is this is a
> partial solution.
> Never the less is some solution for the problem we have.
>
> With that said the series is:
> Acked-by: Emil Velikov
>
> On Wed, 23 Jan 2019 at
On Thu, Oct 25, 2018 at 11:39 AM Eric Anholt wrote:
>
> The vc4 driver can do prime sharing to many different KMS-only devices,
> such as the various tinydrm drivers for SPI-attached displays. Rename the
> driver away from "pl111" to represent what it will actually support:
> various sorts of KMS
On Mon, Sep 3, 2018 at 4:27 PM Eric Anholt wrote:
>
> Mauro Rossi writes:
>
> > Fixes the following building error, happening when building both intel and
> > broadcom:
>
> I wish someone maintaining android Mesa would work on making the meson
> build work for them instead of just continuing to
flag.
> >
> > Test: build and boot tested db820c to UI.
> >
> > Change-Id: I3dcc8034b48785e45cd3fa50e4d9cf2c684694a0
> > Cc: Rob Herring
> > Cc: Alistair Strachan
> > Cc: Marissa Wall
> > Cc: Sumit Semwal
> > Cc: Emil Velikov
>
On Thu, Aug 2, 2018 at 12:47 AM Mauro Rossi wrote:
>
> Hi,
>
> Il giorno gio 2 ago 2018 alle ore 02:06 John Stultz
> ha scritto:
>>
>> Just as a heads up, with mesa3d master (plus my other build fixups I
>> just sent out), I'm seeing a new build failure when building under
>> AOSP/master:
>>
>>
Since https://android-review.googlesource.com/c/718518 added
> timespec_get() to bionic, mesa3d doesn't build due to redefinition
> of timespec_get().
>
> Avoid redefinition by defining HAVE_TIMESPEC_GET flag.
>
> Test: build and boot tested db820c to UI.
>
> Cc: Rob Herring
> Cc: Alis
E%21/
>
> Since https://android-review.googlesource.com/c/718518 added
> timespec_get() to bionic, mesa3d doesn't build due to redefinition
> of timespec_get().
>
> Avoid redefinition by defining HAVE_TIMESPEC_GET flag.
>
> Test: build and boot tested db820c to UI.
>
&
On Wed, Jul 25, 2018 at 1:52 PM John Stultz wrote:
>
> On Wed, Jul 25, 2018 at 5:42 AM, Emil Velikov
> wrote:
> > On 25 July 2018 at 00:21, John Stultz wrote:
> >> From: Yong Yao
> >>
> >> This is a forward port of a patch from the AOSP/master branch:
> >> https://android.googlesource.com/plat
On Tue, Jul 24, 2018 at 5:21 PM John Stultz wrote:
>
> From: Yong Yao
>
> This is a forward port of a patch from the AOSP/master branch:
> https://android.googlesource.com/platform/external/mesa3d/+/b1e5fad1db4c1d51c7ae3a033b100a8429ae5415%5E%21/
>
> Which allows boards to provide their own custo
On Thu, Jul 19, 2018 at 9:52 AM Robert Foss wrote:
>
> Hey Rob,
>
> On 2018-07-19 09:26, Tomasz Figa wrote:
> > On Thu, Jul 19, 2018 at 12:08 AM Robert Foss
> > wrote:
> >>
> >> Hey Rob,
> >>
> >> On 2018-07-18 15:30, Rob Herr
On Tue, Jul 17, 2018 at 4:33 AM Robert Foss wrote:
>
> This series implements kms_swrast support for the Android
> platform. And since having to debug a null pointer dereference,
> simplify that process for the next guy.
So is this working for you now?
> As it stands now, any kernel must have th
On Wed, Jun 13, 2018 at 12:19 PM, Amit Pundir wrote:
> On 13 June 2018 at 20:45, Rob Herring wrote:
>>
>> +Amit and John
>>
>> On Sat, Jun 9, 2018 at 11:27 AM, Robert Foss
>> wrote:
>> > This patch both adds support for probing & filtering D
+Amit and John
On Sat, Jun 9, 2018 at 11:27 AM, Robert Foss wrote:
> This patch both adds support for probing & filtering DRM nodes
> and switches away from using the GRALLOC_MODULE_PERFORM_GET_DRM_FD
> gralloc call.
>
> Currently the filtering is based just on the driver name,
> and the desired
On Fri, May 25, 2018 at 9:25 AM, Tomasz Figa wrote:
> On Fri, May 25, 2018 at 10:59 PM Rob Herring wrote:
>
>> On Fri, May 25, 2018 at 4:15 AM, Robert Foss
> wrote:
>> >
>> >
>> > On 2018-05-25 10:38, Tomasz Figa wrote:
>> >>
>>
On Fri, May 25, 2018 at 4:15 AM, Robert Foss wrote:
>
>
> On 2018-05-25 10:38, Tomasz Figa wrote:
>>
>> On Fri, May 25, 2018 at 5:33 PM Robert Foss
>> wrote:
>>
>>> Hey,
>>
>>
>>> On 2018-05-25 02:17, Rob Herring wrote:
>
>>
>> Changes since v1:
>> - Added fix for build issue
>> - Do not rely on libdrm for probing
>> - Distinguish between errors and when no drm devices are found
>>
>> Changes since RFC:
>> - Rebased work on the libdrm patch [2].
>> - Inc
On Tue, May 1, 2018 at 3:13 AM, Robert Foss wrote:
> Hey Rob,
>
>
> On 2018-05-01 04:20, Rob Herring wrote:
>>
>> On Fri, Apr 27, 2018 at 6:57 AM, Robert Foss
>> wrote:
>>>
>>> From: Rob Herring
>>>
>>> Maintaining both flin
On Fri, Apr 27, 2018 at 6:57 AM, Robert Foss wrote:
> From: Rob Herring
>
> Maintaining both flink names and prime fd support which are provided by
> 2 different gralloc implementations is problematic because we have a
> dependency on a specific gralloc implementation header.
On Thu, Apr 26, 2018 at 11:56 AM, Emil Velikov wrote:
> On 26 April 2018 at 03:30, Chih-Wei Huang wrote:
>> 2018-04-25 19:55 GMT+08:00 Robert Foss :
>>> Hey Emil & Chih-Wei,
>>>
>>> On 04/24/2018 01:59 PM, Emil Velikov wrote:
On 24 April 2018 at 12:28, Emil Velikov wrote:
> On
On Sun, Apr 15, 2018 at 5:45 PM, Stefan Schake wrote:
> We can't use any of the existing implementations in u_debug_stack.
> Android technically has libunwind, but it's been modified to the point
> where it no longer compiles with the Mesa usage. The library is also
> not meant to be referenced by
On Fri, Apr 20, 2018 at 6:29 AM, Robert Foss wrote:
> Hey Rob,
>
> This looks good to me.
> Do you mind if I carry this patch my series to get it all pushed upstream at
> once?
No, not at all.
Rob
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.or
On Wed, Apr 18, 2018 at 11:03 AM, Robert Foss wrote:
> This patch both adds support for probing & filtering DRM nodes
> and switches away from using the GRALLOC_MODULE_PERFORM_GET_DRM_FD
> gralloc call.
>
> Currently the filtering is based just on the driver name,
> and the desired name is supplie
GRALLOC_MODULE_PERFORM_GET_DRM_FD remains for
now, but the definition is added locally to remove the header
dependency.
Signed-off-by: Rob Herring
---
With this plus Robert's probing patch, we remove any gralloc
implementation dependency (other than it has to be a pre 1.0
implementation...).
liary/Android.mk | 3 +-
> .../auxiliary/util/u_debug_stack_android.cpp | 111
> +
> src/gallium/targets/dri/Android.mk | 1 +
> 3 files changed, 114 insertions(+), 1 deletion(-)
> create mode 100644 src/gallium/auxiliary/u
On Wed, Mar 28, 2018 at 12:24 PM, Mark Janes wrote:
> Rob Herring writes:
>
>> On Wed, Mar 28, 2018 at 10:18 AM, Rob Clark wrote:
>>> On Wed, Mar 28, 2018 at 10:43 AM, Rob Herring wrote:
>>>> On Sun, Mar 25, 2018 at 1:10 PM, Rob Clark wrote:
>>>>
On Wed, Mar 28, 2018 at 10:18 AM, Rob Clark wrote:
> On Wed, Mar 28, 2018 at 10:43 AM, Rob Herring wrote:
>> On Sun, Mar 25, 2018 at 1:10 PM, Rob Clark wrote:
>>> I threatened to do this a long time ago.. I probably *should* have done
>>> it a long time ago
On Sun, Mar 25, 2018 at 1:10 PM, Rob Clark wrote:
> I threatened to do this a long time ago.. I probably *should* have done
> it a long time ago when there where many fewer intrinsics. But the
> system of macro/#include magic for dealing with intrinsics is a bit
> annoying, and python has the nic
On Wed, Feb 21, 2018 at 1:22 PM, Emil Velikov wrote:
> On 21 February 2018 at 18:50, Rob Herring wrote:
>> On Wed, Feb 21, 2018 at 10:01 AM, Emil Velikov
>> wrote:
>>> Hi all,
>>>
>>> Pardon for dropping in late. I think you've got nearly everyt
On Wed, Feb 21, 2018 at 10:01 AM, Emil Velikov wrote:
> Hi all,
>
> Pardon for dropping in late. I think you've got nearly everything
> settled down, just sharing a couple of ideas.
>
> On 21 February 2018 at 04:19, Tomasz Figa wrote:
>> On Wed, Feb 21, 2018 a
masz Figa wrote:
>>>>
>>>> On Fri, Feb 16, 2018 at 11:33 PM, Robert Foss
>>>> wrote:
>>>>>
>>>>> Hey Tomasz,
>>>>>
>>>>>
>>>>> On 02/16/2018 05:10 AM, Tomaszzz Figa wrote:
>>>>
On Fri, Feb 9, 2018 at 3:58 AM, Tomasz Figa wrote:
> On Fri, Feb 2, 2018 at 11:51 PM, Tomasz Figa wrote:
>> On Fri, Feb 2, 2018 at 11:00 PM, Rob Herring wrote:
>>> On Fri, Feb 2, 2018 at 2:01 AM, Tomasz Figa wrote:
>>>> Hi Rob,
>>>>
>>
ranslation will still have to happen somewhere.
The cros implementation has both formats. We should perhaps figure out
why both are needed (plus I haven't actually tested this change).
So the rest of the series looks good to me, but I'd hold off on this one.
t; has been chosen and variables have had comments added to them.
>
> Signed-off-by: Robert Foss
> ---
> Changes since v1:
> Suggested by Rob Herring:
> - Fixed copyright statement
> - Moved FDs to be first in handle
> - Initialize native_handle_t using native_handle_cr
>>>>>>> } gralloc_funcs_t;
>>>
>>>
>>> These ones? >
>>> Yeah, if we could retrieve such function pointer struct using perform
>>> or any equivalent (like the implementation-specific methods in
>>> gralloc1, but not sur
On Thu, Jan 25, 2018 at 10:21 AM, Robert Foss wrote:
> Hey Tomasz,
>
> On 01/24/2018 11:04 AM, Tomasz Figa wrote:
>>
>> Hi Robert,
>>
>> On Wed, Jan 17, 2018 at 2:36 AM, Robert Foss
>> wrote:
>>>
>>> This series moves {gbm,drm,cros}_gralloc_handle_t struct to libdrm,
>>> since at least 4 implemen
On Wed, Jan 24, 2018 at 4:04 AM, Tomasz Figa wrote:
> Hi Robert,
>
> On Wed, Jan 17, 2018 at 2:36 AM, Robert Foss
> wrote:
>> This series moves {gbm,drm,cros}_gralloc_handle_t struct to libdrm,
>> since at least 4 implementations exist, and share a lot of contents.
>> The idea is to keep the com
On Mon, Jan 15, 2018 at 6:31 AM, Tapani Pälli wrote:
> This can/should be modified depending on needs. AFAIK by default,
> this is the only path that can be read/written to by anyone.
>
> Signed-off-by: Tapani Pälli
> ---
> Android.common.mk | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git
On Wed, Jan 17, 2018 at 12:27 PM, Tapani Pälli wrote:
> Let's expose this only when we have formats. There are some
> known issues when this is exposed without formats (on Android).
This is fixed now at least for master.
Rob
___
mesa-dev mailing list
m
On Tue, Jan 16, 2018 at 11:36 AM, Robert Foss wrote:
> Supply accessor functions for most of the common gralloc_handle_t
> variables.
>
> Signed-off-by: Robert Foss
> ---
> android/gralloc_handle.h | 57
>
> 1 file changed, 57 insertions(+)
>
> d
On Tue, Jan 16, 2018 at 11:36 AM, Robert Foss wrote:
> This struct is used in mesa and drm_hwcomposer.
> Versions of if have been implemented in several grallocs:
> drm_gralloc, gbm_gralloc, minigbm and intel-minigbm.
>
> Other than the 1:1 move of the struct a new generic name
> has been chosen a
On Tue, Jan 16, 2018 at 11:36 AM, Robert Foss wrote:
> This struct is used in mesa and drm_hwcomposer.
> Versions of if have been implemented in several grallocs:
> drm_gralloc, gbm_gralloc, minigbm and intel-minigbm.
>
> Other than the 1:1 move of the struct a new generic name
> has been chosen a
On Mon, Jan 15, 2018 at 7:09 AM, Robert Foss wrote:
> Hey,
>
> On 01/13/2018 12:49 AM, Gurchetan Singh wrote:
>>
>> We can define accessor functions too (not ptrs), then the struct is
>> opaque
>> and you can do your own accessor implementation if aligning is not
>> possible
>> or desi
v_color_range, is_updated etc.]
>>>>
>>>>
>>>> https://chromium.googlesource.com/chromiumos/platform/minigbm/+/master/cros_gralloc/cros_gralloc_handle.h
>>>> [use_flags, pixel_stride]
>>>>
>>>> In our case, removing our minigbm
On Mon, Jan 8, 2018 at 7:25 PM, Ilia Mirkin wrote:
> On Mon, Jan 8, 2018 at 4:18 PM, Rob Herring wrote:
>> Many of the functions declared in tgsi_build.h return structs (not struct
>> pointers). Therefore the full struct definitions are needed to avoid
>> warnings or
/tgsi_build.h:47:1: error:
'tgsi_build_header' has C-linkage specified, but returns incomplete type
'struct tgsi_header' which could be incompatible with C
[-Werror,-Wreturn-type-c-linkage]
This error shows up on Android builds using clang and -Werror.
Cc: Ilia Mirkin
Signed
On Thu, Jan 4, 2018 at 8:16 AM, Eric Engestrom
wrote:
> On Wednesday, 2018-01-03 10:28:37 -0600, Rob Herring wrote:
>> Commit 2f421651aca9 ("egl: let each platform decided how to handle
>> LIBGL_ALWAYS_SOFTWARE") broke the build due to copy-n-paste of misnamed
>>
g 'disp', rename the function parameter 'dpy' to
'disp' to align with the other EGL platforms' implementations.
Fixes: 2f421651aca9 ("egl: let each platform decided how to handle
LIBGL_ALWAYS_SOFTWARE")
Cc: Eric Engestrom
Signed-off-b
e fact the having at least initial backwards compatability would
>> be nice. Anonymous unions can of course be used later on to provide
>> backwards compatability if so desired.
>>
>>
>> Get/Set functions
>> -
>> During the previous discussion[1
tions.h. Use "$<"
instead of "$^" because we only need the first dependency (the script),
not all dependencies.
Signed-off-by: Rob Herring
---
src/util/Android.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/util/Android.
On Sun, Dec 17, 2017 at 4:02 PM, Maya Rashish wrote:
> Remove EOL NetBSD < 1.x (this didn't work, since we don't
> include sys/param.h).
> Remove EOL FreeBSD < 4.4
>
> Functionally changes OpenBSD which now uses getprogname instead of
> fallback.
> ---
> src/util/xmlconfig.c | 17 +++-
On Mon, Dec 18, 2017 at 8:45 PM, Yu, Qiang wrote:
> I met this problem when upgrade mesa 17.2 to 17.3, and build without
> a make clean. A clean build won't have this problem.
I think I'm seeing a similar problem on CI builds with current master,
but with intel_screen.c:
external/mesa3d/src/mesa
On Wed, Dec 13, 2017 at 11:58 AM, Robert Foss wrote:
> Hey Rob&Emil,
>
> I've chatted to both of you about this patch, and it seemed acceptable
> to both of you.
>
> Can I have a s-o-b for either of you?
I've applied it and pushed to master.
Rob
___
me
Commit bb1e6ff161c9 ("spirv: Add a prepass to set types on vtn_values")
added generation of vtn_gather_types.c, but forgot to add it to the
Android build files.
Fixes: bb1e6ff161c9 ("spirv: Add a prepass to set types on vtn_values")
Cc: Jason Ekstrand
Signed-off-by: R
On Wed, Dec 13, 2017 at 11:30 AM, Robert Foss wrote:
> Mark magic member of alloc_handle_t as const.
> Also bump the version of alloc_handle_t.
>
> Sign-off-by: Robert Foss
> ---
> android/alloc_handle.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/android/alloc_h
On Wed, Dec 13, 2017 at 11:30 AM, Robert Foss wrote:
> This struct is used in mesa and drm_hwcomposer.
> Versions of if have been implemented in several grallocs:
> drm_gralloc, gbm_gralloc, minigbm and intel-minigbm.
>
> Other than the 1:1 move of the struct a new generic name
> has been chosen a
On Thu, Dec 7, 2017 at 10:12 AM, Jason Ekstrand wrote:
> This autogenerated pass will automatically find and set the type field
> on all vtn_values. This way we always have the type and can use it for
> validation and other checks.
> ---
> src/compiler/Makefile.nir.am | 4 +
> src/
On Tue, Dec 5, 2017 at 11:01 AM, Robert Foss wrote:
> On Tue, 2017-12-05 at 18:22 +0900, Tomasz Figa wrote:
>> On Sat, Dec 2, 2017 at 4:43 AM, Rob Herring wrote:
>> > On Fri, Dec 1, 2017 at 8:44 AM, Tomasz Figa
>> > wrote:
>> > > On Fri, Dec 1, 2017
On Tue, Dec 5, 2017 at 5:56 AM, Emil Velikov wrote:
> On 5 December 2017 at 02:21, Rob Herring wrote:
>> Commit 94ca8e04adf6 ("spirv: Add vtn_fail and vtn_assert helpers") broke
>> Android builds which have -Werror enabled with the following errors:
>>
>&g
RETURNS_NONNULL, so add it too.
Fixes: 94ca8e04adf6 ("spirv: Add vtn_fail and vtn_assert helpers")
Cc: Jason Ekstrand
Signed-off-by: Rob Herring
---
Android.common.mk | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Android.common.mk b/Android.common.mk
index f080d996a7d9..
Looks like Jason is the actual culprit here. Unfortunately, the build
can't keep up with every commit. Looks to me like these should be
fixed.
I wonder how long until I give up and just set Android back to -Wno-error...
Rob
-- Forwarded message --
From:
Date: Mon, Dec 4, 2017
On Fri, Dec 1, 2017 at 8:44 AM, Tomasz Figa wrote:
> On Fri, Dec 1, 2017 at 11:20 PM, Rob Herring wrote:
>> On Fri, Dec 1, 2017 at 7:30 AM, Robert Foss
>> wrote:
>>> On Thu, 2017-11-30 at 11:14 -0600, Rob Herring wrote:
>>>> On Thu, Nov 30, 2017 at
On Fri, Dec 1, 2017 at 7:30 AM, Robert Foss wrote:
> On Thu, 2017-11-30 at 11:14 -0600, Rob Herring wrote:
>> On Thu, Nov 30, 2017 at 12:11 AM, Tapani Pälli > m> wrote:
>> >
>> >
>> > On 11/30/2017 06:13 AM, Tomasz Figa wrote:
>> > &g
On Thu, Nov 30, 2017 at 12:11 AM, Tapani Pälli wrote:
>
>
> On 11/30/2017 06:13 AM, Tomasz Figa wrote:
>>
>> On Thu, Nov 30, 2017 at 3:43 AM, Robert Foss
>> wrote:
>>>
>>> Hey,
>>>
>>> On Tue, 2017-11-28 at 11:49 +, Emil Velikov wrote:
On 28 November 2017 at 10:45, Tapani Pälli
>>>
On Wed, Nov 29, 2017 at 11:01 AM, Emil Velikov wrote:
> On 27 November 2017 at 19:36, Rob Herring wrote:
>> AOSP master has changed the build default to -Werror making all the
>> warnings errors. Override that with -Wno-error.
>>
> For both Mesa and libdrm patches
>
On Tue, Nov 28, 2017 at 8:42 AM, Tomasz Figa wrote:
> On Tue, Nov 28, 2017 at 11:27 PM, Rob Herring wrote:
>> On Tue, Nov 28, 2017 at 5:49 AM, Emil Velikov
>> wrote:
>>> On 28 November 2017 at 10:45, Tapani Pälli wrote:
>>>> Hi;
>>>>
>
On Tue, Nov 28, 2017 at 5:49 AM, Emil Velikov wrote:
> On 28 November 2017 at 10:45, Tapani Pälli wrote:
>> Hi;
>>
>>
>> On 11/27/2017 04:14 PM, Robert Foss wrote:
[...]
>>> + /* HACK: See droid_create_image_from_prime_fd() and b/32077885. */
>>> + { HAL_PIXEL_FORMAT_IMPLEMENTATION_DEFINED,
On Mon, Nov 27, 2017 at 8:14 AM, Robert Foss wrote:
> From: Tomasz Figa
>
> There is no API available to properly query the IMPLEMENTATION_DEFINED
> format. As a workaround we rely here on gralloc allocating either
> an arbitrary YCbCr 4:2:0 or RGBX_, with the latter being recognized
> by loc
AOSP master has changed the build default to -Werror making all the
warnings errors. Override that with -Wno-error.
Signed-off-by: Rob Herring
---
Android.common.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/Android.common.mk b/Android.common.mk
index 5671c1c1a595..fcd9a874d538 100644
i2.h | 32 --
> src/egl/drivers/dri2/platform_android.c | 10 +++---
> src/egl/drivers/dri2/platform_drm.c | 60
> ++-------
> src/egl/drivers/dri2/platform_wayland.c | 41 +++---
> 4 files changed, 73 insertions
ally
> declare timespec_get(), just like all the other C11 thread functions (and as
> the unused xtime_get() was, prior to
> f1a364878431c8c5f4fd38b40b9766449e49f552)?
>
> Revised patch attached.
That should fix Android builds.
Acked-by: Rob Herring
Rob
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev
Sorry, wrong list...
On Tue, Oct 31, 2017 at 9:58 AM, Rob Herring wrote:
> EGL, gralloc, and HWC must all have a common definition of fd's and int's
> in native_handle_t to share the fd and width, height, format, etc. of a
> dmabuf.
>
> Move the definition into HWC so
ew file mode 100644
index ..e2f35dda539b
--- /dev/null
+++ b/gralloc_drm_handle.h
@@ -0,0 +1,87 @@
+/*
+ * Copyright (C) 2010-2011 Chia-I Wu
+ * Copyright (C) 2010-2011 LunarG Inc.
+ * Copyright (C) 2016-2017 Linaro, Ltd., Rob Herring
+ *
+ * Permission is hereby granted, free
n Intel drivers will not be loaded with Android N and earlier,
>> thus causing SurfaceFlinger SIGABRT
>>
>> Fixes: c3f75d483c ("Android: move libraries to /vendor")
>>
>> Cc: 17.3
>> ---
>> src/gallium/targets/dri/Android.mk | 4 ++--
>> 1
ld be pretty invasive.
Signed-off-by: Rob Herring
---
src/egl/Android.mk | 4
1 file changed, 4 insertions(+)
diff --git a/src/egl/Android.mk b/src/egl/Android.mk
index 2de842ca4172..11818694f4f8 100644
--- a/src/egl/Android.mk
+++ b/src/egl/Android.mk
@@ -60,6 +60,10 @@ LOCAL_SHARED_LIBR
On Mon, Oct 16, 2017 at 1:54 PM, Chad Versace wrote:
> (This is v4 submission of the series, but contains v9 of the key patch).
>
> This series adds Android support to Anvil. And Android requires
> VK_ANDROID_native_buffer.
>
>
> I tested the series on 64-bit ARC++ on a Skylake Chromebook with a 3
1 - 100 of 603 matches
Mail list logo
