hi,
On Thu, Aug 16, 2018, 4:48 PM Lepton Wu wrote:
>
> Does https://patchwork.freedesktop.org/patch/238931/ already fix this?
> What's the advantage to use MAP_FAILED instead of NULL?
yea that patch should work fine, i didnt see it go by.
the advantage of MAP_FAILED is it's more fault tolerant.
From: Ray Strode
At the moment, depending on pipe transfer flags, the dumb
buffer map address can end up at either kms_sw_dt->ro_mapped
or kms_sw_dt->mapped.
When it's time to unmap the dumb buffer, both locations get unmapped,
even though one is probably initialized to 0.
That l
Hi,
Just a quick note...
> From: Ray Strode
>
> lp_build_fetch_rgba_soa fetches a texel from a texture.
> Part of that process involves first gathering the element
> together from memory into a packed format, and then breaking
> out the individual color channels into separate,
Hi Emil,
Is this still on your radar?
On Sun, Sep 6, 2015 at 6:09 PM, Ray Strode wrote:
> On Sun, Sep 6, 2015 at 3:04 PM, Emil Velikov wrote:
>> Have you seen an application where this causes problems ? Might if I
>> add it to the commit log before pushing ?
> It caus
Hi,
On Sun, Sep 6, 2015 at 3:04 PM, Emil Velikov wrote:
> Have you seen an application where this causes problems ? Might if I
> add it to the commit log before pushing ?
It caused a problem for a proposed patch to cogl that I ultimately
decided not to push after discussion with Daniel Stone. See
Hey Kristian, Ander,
Can I convince either/both of you to give this a once over and a r-b ?
--Ray
On Fri, Aug 28, 2015 at 2:15 PM, Ray Strode wrote:
> From: Ray Strode
>
> At the moment if a gbm buffer is imported and the gbm buffer
> has an old-style GBM_BO_FORMAT format, the
From: Ray Strode
At the moment if a gbm buffer is imported and the gbm buffer
has an old-style GBM_BO_FORMAT format, the import will crash,
since it's passed directly to DRI functions that expect
a fourcc format (as provided by the newer GBM_FORMAT
definitions)
This commit addresses the pr
Hi,
> + switch (fd_data->format) {
> + case GBM_FORMAT_RGB565:
> + case GBM_FORMAT_XRGB:
> + case GBM_FORMAT_ARGB:
> + case GBM_FORMAT_ABGR:
> + case GBM_FORMAT_ARGB2101010:
> + case GBM_FORMAT_XRGB2101010:
So Rob Clark pointed out on IRC that this mi
From: Ray Strode
At the moment if a gbm buffer is imported and the gbm buffer
has an old-style GBM_BO_FORMAT format, the import will crash,
since it's passed directly to DRI functions that expect
a fourcc format (as provided by the newer GBM_FORMAT
definitions)
This commit addresses the pr
